From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
cc: Michael Paquier <michael@paquier.xyz>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        Justin Pryzby <pryzby@telsasoft.com>
Subject: Re: Internal error codes triggered by regression tests and user
 queries, take 2
In-reply-to: <94ac928b-8370-4db5-ada5-579a9ebc089d@gmail.com>
References: <94ac928b-8370-4db5-ada5-579a9ebc089d@gmail.com>
Comments: In-reply-to Alexander Lakhin <exclusion@gmail.com>
	message dated "Wed, 26 Aug 2026 17:00:00 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <697476.1787754418.1@sss.pgh.pa.us>
Date: Wed, 26 Aug 2026 10:26:58 -0400
Message-ID: <697477.1787754418@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/697477.1787754418%40sss.pgh.pa.us>
Precedence: bulk

Alexander Lakhin <exclusion@gmail.com> writes:
> Please take a look at the follow-up to [0]. I've prepared a patch to
> assign error codes for errors reached by the following queries:

I'm not on board with these proposed changes to [try_]relation_open.
They're basically band-aids rather than fixes of the root problems.
That is, if someone passes OID 0 to relation_open, that IS an internal
bug; labeling it otherwise is a lie and does nothing to fix the real
problem at the caller level.

A lot of these other proposed changes have the same whiff of blaming
the messenger rather than looking for the root cause.

			regards, tom lane