Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1u2bOD-0036E9-FE
	for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Apr 2025 19:47:13 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1u2bOB-006m9P-Jv
	for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Apr 2025 19:47:11 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ilya.evdokimov@tantorlabs.com>)
	id 1u2bOB-006m9G-8q
	for pgsql-hackers@lists.postgresql.org; Wed, 09 Apr 2025 19:47:11 +0000
Received: from forward103a.mail.yandex.net ([178.154.239.86])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ilya.evdokimov@tantorlabs.com>)
	id 1u2bO9-004OYO-0B
	for pgsql-hackers@postgresql.org;
	Wed, 09 Apr 2025 19:47:11 +0000
Received: from mail-nwsmtp-smtp-production-main-84.iva.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-84.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:160c:0:640:ab2b:0])
	by forward103a.mail.yandex.net (Yandex) with ESMTPS id D3E4860B63;
	Wed,  9 Apr 2025 22:47:07 +0300 (MSK)
Received: by mail-nwsmtp-smtp-production-main-84.iva.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 4lkmLt1LfmI0-eN5KWnbZ;
	Wed, 09 Apr 2025 22:47:07 +0300
X-Yandex-Fwd: 1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tantorlabs.com;
	s=mail; t=1744228027;
	bh=CZ17kWVTeGZyjTiLo+cBfoVrt8d1KgrPnqKtjo1ZPts=;
	h=In-Reply-To:Cc:Date:References:To:From:Subject:Message-ID;
	b=IH7O+UkLASgrtaqJaqnHM5jGlIxfqArZsYrkexCojmhBCupgy4KfqBjr3BQKMMmIf
	 BlUg/2LqHlug/6c67w3Mxugsds5GpJKmcwfECDf3TnEQGlwG2lf3x3FV76IRD4ybCp
	 7sLJnzJSeBY12zo9/5Od+8uCWWJGETlq8XUfqKLU=
Authentication-Results: mail-nwsmtp-smtp-production-main-84.iva.yp-c.yandex.net; dkim=pass header.i=@tantorlabs.com
Message-ID: <6983272b-9741-411e-b68a-b06fae2b52aa@tantorlabs.com>
Date: Wed, 9 Apr 2025 22:47:03 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Sample rate added to pg_stat_statements
From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: Alexander Korotkov <aekorotkov@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
 Greg Sabino Mullane <htamfids@gmail.com>,
 Andrey Borodin <x4mmm@yandex-team.ru>,
 Alena Rybakina <a.rybakina@postgrespro.ru>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <fe99e0ca-e564-480e-b865-5f0cee30bc60@tantorlabs.com>
 <CAA5RZ0vxn_UiUkUK5SdngObLZzw40RhafB7SHydxzBw2_xjjiA@mail.gmail.com>
 <cc1beb52-3e4e-4866-8c32-a5967b98c977@tantorlabs.com>
 <18631d46-1741-4edc-b116-8d9631cdf919@tantorlabs.com>
 <4f98ec33-c627-4eb4-84f3-9994a0982277@tantorlabs.com>
 <CAA5RZ0tJjrX6YiQVDZCOA_BDMuhO-po_T8a3PmjxEEH_iL-qMg@mail.gmail.com>
 <623db69f-b40a-4d50-b1bd-bb073fcc4336@tantorlabs.com>
 <3546e2a7-5831-4c0a-996b-358d4ec483a6@tantorlabs.com>
 <6bf3059f-7ebe-4640-8870-1220f83b88ed@tantorlabs.com>
 <7b9df88f-3015-464b-881e-4c6a7b3a5c03@tantorlabs.com>
 <CAA5RZ0vz+Abyck0dn0fHJ5nTfJU7wdLRxfUj481Ga-BGNY0Txg@mail.gmail.com>
 <6f305fd1-44c3-4189-81ef-238777277e5e@tantorlabs.com>
 <CAA5RZ0trJoVqGmELHOc=G2SxHQHKdTb1aAvzf3vHdfVP8UH+Xg@mail.gmail.com>
 <CAA5RZ0vOjQDC=OvUHuKMPYc8UT_peKt_yWpVaEqiP-JG2yqB9w@mail.gmail.com>
 <51e93798-cd3b-4855-aaa4-78985025cd76@tantorlabs.com>
 <fd309469-db3b-45b1-af85-06cef3a610bc@tantorlabs.com>
Content-Language: en-US
In-Reply-To: <fd309469-db3b-45b1-af85-06cef3a610bc@tantorlabs.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/6983272b-9741-411e-b68a-b06fae2b52aa%40tantorlabs.com>
Precedence: bulk

Since at the moment these changes are not a priority, and it's more 
important to address [0] for pg_stat_statements, I'm marking this patch 
as "Returned with Feedback".

[0]: https://www.postgresql.org/message-id/Zz0MFPq1s4WFxxpL%40paquier.xyz

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.