Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fbYK0-0001AP-6M
	for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Jul 2018 21:31:20 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fbYJw-00017Z-S8
	for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Jul 2018 21:31:16 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fbYJw-00017R-LH
	for pgsql-hackers@lists.postgresql.org; Fri, 06 Jul 2018 21:31:16 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fbYJp-0003G8-DV
	for pgsql-hackers@postgresql.org; Fri, 06 Jul 2018 21:31:16 +0000
Received: from pro.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w66LUtI8028912;
	Fri, 6 Jul 2018 17:30:55 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
cc: Artur Zakirov <a.zakirov@postgrespro.ru>,
        Dmitry Dolgov <9erthalion6@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Thomas Munro <thomas.munro@enterprisedb.com>, sulamul@gmail.com,
        Pavel Stehule <pavel.stehule@gmail.com>,
        "David G. Johnston" <david.g.johnston@gmail.com>,
        Alex Ignatov <a.ignatov@postgrespro.ru>,
        Bruce Momjian <bruce@momjian.us>, sul_amul@yahoo.co.in,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Bug in to_timestamp().
In-reply-to: 
 <CAPpHfdsjXhqbPd8L42YMrd+KLdXKzMpVdyaMvDZE46sGqRF2xg@mail.gmail.com>
References: <20180206091648.GA8507@zakirov.localdomain>
 <CA+q6zcVOmcmbDZnrJdxighp=95xdkGYOucabtay+CpWU8UDqkA@mail.gmail.com>
 <CA+q6zcX6Svkn1Cf0GDvSqCEV-SFC6ET2bxjXQpWaoZYWAordUA@mail.gmail.com>
 <20180212114943.GA6629@zakirov.localdomain>
 <CA+q6zcUS3fQGLoeLcuJLtz-gRD6vHqpn1fBe0cnORdx93QtO4w@mail.gmail.com>
 <20180217090239.GA14632@arthur.localdomain>
 <CA+q6zcXLYS4yKRa1n79ORqPUfLJb0mVyJXRfHDcbGZ44o8hCCw@mail.gmail.com>
 <CA+q6zcXjG34kQy_hskZQjhajFCR8XhfHsHXL2orB4te2Vwdmbg@mail.gmail.com>
 <20180302093328.GA18933@zakirov.localdomain>
 <CA+q6zcWfntt2MPZYmzK71UmoWS3DFgYbYhTWU7Fgg1y9CMaOcw@mail.gmail.com>
 <20180302125132.GA25129@zakirov.localdomain>
 <CAPpHfdsjXhqbPd8L42YMrd+KLdXKzMpVdyaMvDZE46sGqRF2xg@mail.gmail.com>
Comments: In-reply-to Alexander Korotkov <a.korotkov@postgrespro.ru>
	message dated "Thu, 05 Jul 2018 16:35:18 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <69859.1530912655.1@sss.pgh.pa.us>
Date: Fri, 06 Jul 2018 17:30:55 -0400
Message-ID: <69860.1530912655@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Alexander Korotkov <a.korotkov@postgrespro.ru> writes:
> I tool a look at this patch.  It looks good for me.  It applies
> cleanly on last master, builds without warnings, passes tests.
> Functionality seems to be well-covered by documentation and regression
> tests.  So, I'm going to commit it if no objections.

AFAIR, the argument was mainly over whether we agreed with the proposed
behavioral changes.  It seems a bit premature to me to commit given that
there's not consensus on that.

			regards, tom lane