From: Daniel Gustafsson <daniel@yesql.se>
Message-Id: <6A9E7815-BD5A-4C31-A515-48159823406B@yesql.se>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_BE6B4CE5-1D98-463D-B890-EBC6235D90A8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.12\))
Subject: Re: libpq: Process buffered SSL read bytes to support records >8kB on
 async API
Date: Thu, 9 Jul 2026 17:06:55 +0200
In-Reply-To: <be2f229a-25e8-4d19-a307-e4ce3312f212@iki.fi>
Cc: solai v <solai.cdac@gmail.com>,
 Jacob Champion <jacob.champion@enterprisedb.com>,
 Mark Dilger <mark.dilger@enterprisedb.com>,
 Andres Freund <andres@anarazel.de>,
 Lars Kanis <lars@greiz-reinsdorf.de>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Merlin Moncure <mmoncure@gmail.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
References: <2039ac58-d3e0-434b-ac1a-2a987f3b4cb1@greiz-reinsdorf.de>
 <CAOYmi+=jZNU9mZ4Z83aR0RiqZ2pF35u5040gCxBgcFqoA4oNbQ@mail.gmail.com>
 <CAOYmi+mpymrgZ76Jre2dx_PwRniS9YZojwH0rZnTuiGHCsj0rA@mail.gmail.com>
 <CAOYmi+=kbb7pV7k7RfWUcFt=CArJmp1R+R1Xnb8UnZLwpFgOwA@mail.gmail.com>
 <CAOYmi+==Y5ZZiwukN-wzGCyxdrL1dU3wOG-j0nza3MC3R2XhcA@mail.gmail.com>
 <kl6inl3iyycxqpiedmnnzaz2ytid5dw6knwwqk5plg6ej34oi6@fbyu4ll7ebzn>
 <CAOYmi+kZhv_LCg=g8Z6xtiueSYdz1fCvrXwAJ-i9m3VMm9_tXw@mail.gmail.com>
 <CAOYmi+mD6EbDEYfwZON0FCUAvGO+2=jR2V4KQYx+d+g0ap0Amg@mail.gmail.com>
 <CAOYmi+=YJ2J_sQ6yS8y1o9AX1Xgz35_r0hApV8QRWwi1K8gC0g@mail.gmail.com>
 <d987a763-09a1-4c7e-844e-bf8596abde43@iki.fi>
 <CAHgHdKseseJG0j_96xrOuP3LgubvGScvXsQyPCYWANnBxTL4tA@mail.gmail.com>
 <57d1e8b1-d016-4cea-9b60-63cbdb40eb81@iki.fi>
 <CAF0whuf=-G3SwXSTWyZNO148qoaEmth71cM7XBuX4X+2PnQkPQ@mail.gmail.com>
 <990a4710-fed1-411a-aba4-ddc25825ee48@iki.fi>
 <be2f229a-25e8-4d19-a307-e4ce3312f212@iki.fi>
Archived-At: 
 <https://www.postgresql.org/message-id/6A9E7815-BD5A-4C31-A515-48159823406B%40yesql.se>
Precedence: bulk


--Apple-Mail=_BE6B4CE5-1D98-463D-B890-EBC6235D90A8
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

> On 7 Jul 2026, at 17:58, Heikki Linnakangas <hlinnaka@iki.fi> wrote:

> Committed and backpatched to all supported versions. Thanks everyone!

Sorry for coming to this thread late.  When compiling against a local =
LibreSSL
on macOS I get an error on INT_MAX missing:

../src/interfaces/libpq/fe-secure-openssl.c:253:22: error: use of =
undeclared identifier 'INT_MAX'
        else if (pending =3D=3D INT_MAX)
                            ^
1 error generated.

AFAICS it's because openssl/conf.h includes openssl/ossl_typ.h which in =
turn
includes <limits.h> but the LibreSSL counterpart does not.  That being =
said, it
clearly works in the buildfarm where we have LibreSSL animals on OpenBSD =
so it
must get pulled in indirectly from somewhere else there.  This might be
isolated to macOS builds, but I don't have other systems with LibreSSL =
handy so
not sure.  My LibreSSL installation is a libressl_portable locally =
compiled
which further may explain differences?

Any objections to the attached to make compilation pass when building =
against
LibreSSL on macOS (and possibly elsewhere)?

--
Daniel Gustafsson


--Apple-Mail=_BE6B4CE5-1D98-463D-B890-EBC6235D90A8
Content-Disposition: attachment;
	filename=0001-ssl-Include-limits.h-to-get-INT_MAX-when-using-Libre.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="0001-ssl-Include-limits.h-to-get-INT_MAX-when-using-Libre.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=20731f58640688005edfaf981b446ae1392e1996ba=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20Daniel=20Gustafsson=20=
<dgustafsson@postgresql.org>=0ADate:=20Thu,=209=20Jul=202026=2017:00:46=20=
+0200=0ASubject:=20[PATCH]=20ssl:=20Include=20limits.h=20to=20get=20=
INT_MAX=20when=20using=20LibreSSL=0A=0AWhen=20compiling=20against=20=
OpenSSL,=20the=20<limits.h>=20header=20is=20indirectly=0Aincluded=20via=20=
openssl/ossl_typ.h=20from=20openssl/conf.h,=20but=20the=20LibreSSL=0A=
version=20of=20ossl_typ.h=20does=20not=20include=20<limits.h>=20which=20=
cause=20compiler=0Afailure=20due=20to=20missing=20symbol=20(since=20=
ffd080d94fe).=20=20Fix=20by=20explicitly=0Aincluding=20<limits.h>.=0A---=0A=
=20src/interfaces/libpq/fe-secure-openssl.c=20|=201=20+=0A=201=20file=20=
changed,=201=20insertion(+)=0A=0Adiff=20--git=20=
a/src/interfaces/libpq/fe-secure-openssl.c=20=
b/src/interfaces/libpq/fe-secure-openssl.c=0Aindex=20=
f8b2184a1ce..c7651c98ab5=20100644=0A---=20=
a/src/interfaces/libpq/fe-secure-openssl.c=0A+++=20=
b/src/interfaces/libpq/fe-secure-openssl.c=0A@@=20-25,6=20+25,7=20@@=0A=20=
#include=20<signal.h>=0A=20#include=20<fcntl.h>=0A=20#include=20=
<ctype.h>=0A+#include=20<limits.h>=0A=20=0A=20#include=20"libpq-fe.h"=0A=20=
#include=20"fe-auth.h"=0A--=20=0A2.39.3=20(Apple=20Git-146)=0A=0A=

--Apple-Mail=_BE6B4CE5-1D98-463D-B890-EBC6235D90A8--