Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\))
Subject: Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE
 statements
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CANxoLDdSqqk8hg1m2=-6dv=23ZpRkfEXkZWpGtQT=aTJ0088yg@mail.gmail.com>
Date: Tue, 23 Jun 2026 10:18:11 +0800
Cc: Zsolt Parragi <zsolt.parragi@percona.com>,
 pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <6ADD1776-F3E4-4BCD-B569-17A61AD411D1@gmail.com>
References: 
 <CANxoLDfjQnhM=E6JSyYo9s9OdjqoN8s_3wE5yL=kaDu_X8j-dA@mail.gmail.com>
 <CANxoLDcxmXNHNyPt5v+LaBJVJmyt=j95D7TDE9SepoM7y15t-w@mail.gmail.com>
 <CAN4CZFNqf41TCg1ENccq6DAYQpArCbnKUSidHnRKaVMWGj5pBA@mail.gmail.com>
 <CANxoLDfL1AxL=k9SsRNReKQ-sJUSy6RvCqeog5HWckFxff=0Pg@mail.gmail.com>
 <CAN4CZFP5-fAGwxMCyKGePgp3N8NCpoFXkruO=5xjTC=gPwqYxw@mail.gmail.com>
 <CANxoLDc6UFMsyzbXKF8SpMoXdoKE=-yRPqtvyBMKKJ2zOUKX4A@mail.gmail.com>
 <CAN4CZFMhnZyQsdLC5iZNego77JHJyP6J_4CpWu=99vKHCd-vzg@mail.gmail.com>
 <CANxoLDco7z7Fj7_pj_3YQLvjq8ZH2Ai4c3GcOamed01fZhJ77Q@mail.gmail.com>
 <CAB-JLwY=RYPJhdFid0YDqk1L1OQPuHFz9J2tOeeVCFLjov+Ktg@mail.gmail.com>
 <CANxoLDdRts-F+QxL+wtM8529Z3+TUJku8PKy3WoxcWBs7zQJ-w@mail.gmail.com>
 <CAB-JLwbyzF+JRPCoLCf-H6dQ_1+-O_wBZcESRdC6_H2z+-d-gg@mail.gmail.com>
 <CANxoLDcWwoWOxvmV_uBBUsbGf+_AZzBV1GkcjoX+omNpcrCNMQ@mail.gmail.com>
 <CAN4CZFM99cGopPJXD_t05+Y9CnocOOTipfXCzoAfBUFSC-i4+A@mail.gmail.com>
 <CANxoLDejn2JFXF7kVMtcznW6XyessrJ7WToSaQau2GxBdAGSUg@mail.gmail.com>
 <983C7B03-D9C3-4F15-8913-7616EC5E6414@gmail.com>
 <CANxoLDe_GOXyyZs7GN3VUJoT+o1DwqZGhid-TWWvS0D8d5ggYw@mail.gmail.com>
 <D7068A62-6A30-44B9-BADD-0FFACEAD110A@gmail.com>
 <CANxoLDdSqqk8hg1m2=-6dv=23ZpRkfEXkZWpGtQT=aTJ0088yg@mail.gmail.com>
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/6ADD1776-F3E4-4BCD-B569-17A61AD411D1%40gmail.com>
Precedence: bulk


> On Jun 22, 2026, at 22:11, Akshay Joshi =
<akshay.joshi@enterprisedb.com> wrote:
>=20
>=20
>=20
> On Mon, Jun 22, 2026 at 7:30=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>=20
>=20
> > On Jun 22, 2026, at 20:40, Akshay Joshi =
<akshay.joshi@enterprisedb.com> wrote:
> >=20
> > You're right, and thanks for spotting this. The existing pattern in =
pg_proc.dat for variadic-text functions (e.g., jsonb_delete, =
json_extract_path) uses _text at the variadic position in both =
proargtypes and proallargtypes, with provariadic =3D> 'text'. That is =
the convention documented by the sanity check in =
src/test/regress/sql/opr_sanity.sql.
> >=20
> > The same issue applies to pg_get_role_ddl, pg_get_tablespace_ddl =
(both variants), and pg_get_database_ddl, but that will require a =
separate patch.
> >=20
>=20
> Thanks for confirming. Then I will file a patch tomorrow to fix those.
>=20
>    I started working on it, but if you want to take the lead, just let =
me know and I won't send my version over=20
>=20

The changes to pg_proc.dat have been in my local tree for some time. =
Today I also fixed the sanity check in opr_sanity so that it can now =
report this mismatch. Could you please take a look at my patch [1]?

[1] =
https://www.postgresql.org/message-id/D41A334E-ED9E-42EE-830D-28D4D36E9317=
%40gmail.com

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/