Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\))
Subject: Re: [PATCH] Two small errhint cleanups in PG19 code
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CA+fm-RMrKbyky_+vi5SDdAVnFVjWh7zW3GoDAVnrp5OpDnW6tw@mail.gmail.com>
Date: Mon, 25 May 2026 13:38:26 +0800
Cc: pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <6CF44A34-3C2E-4D3B-AEE4-FC30EC24B989@gmail.com>
References: 
 <CA+fm-RMrKbyky_+vi5SDdAVnFVjWh7zW3GoDAVnrp5OpDnW6tw@mail.gmail.com>
To: Baji Shaik <baji.pgdev@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/6CF44A34-3C2E-4D3B-AEE4-FC30EC24B989%40gmail.com>
Precedence: bulk


> On May 25, 2026, at 10:38, Baji Shaik <baji.pgdev@gmail.com> wrote:
>=20
> Hi,
>=20
> While exploring new features in PG19, I came across two unrelated
> small errhint issues. Sending them as separate patches in one thread =
since they touch
> unrelated subsystems and can be reviewed/committed independently.
>=20
> Patch 0001 -- Remove stray word in pg_restore_extended_stats() errhint
> The errhint in import_pg_statistic() reads:
>=20
>       Value of element "%s" must be type a null or a string.
>=20
>   The word "type" is a stray word that doesn't belong; the intent is
>   "must be a null or a string".

Agreed.

>=20
> Patch 0002 -- Add missing period to online data checksums errhint
>   The errhint emitted when StartupXLOG() detects an interrupted
>   "enabling data checksums" run is missing a trailing period:
>=20
>       Data checksum processing must be manually restarted for
>       checksums to be enabled
>=20

Yes, a hint message should end with a period.

> Thanks,
> Baji Shaik
> =
<0002-Add-missing-period-to-online-data-checksums-errhint.patch><0001-Remo=
ve-stray-word-in-pg_restore_extended_stats-errhi.patch>


So, both changes look good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/