public inbox for [email protected]
help / color / mirror / Atom feed[PATCH v34 1/7] Use standard crash handler in archiver.
5+ messages / 4 participants
[nested] [flat]
* [PATCH v34 1/7] Use standard crash handler in archiver.
@ 2020-03-16 08:15 Kyotaro Horiguchi <[email protected]>
0 siblings, 0 replies; 5+ messages in thread
From: Kyotaro Horiguchi @ 2020-03-16 08:15 UTC (permalink / raw)
The commit 8e19a82640 changed SIGQUIT handler of almost all processes
not to run atexit callbacks for safety. Archiver process should behave
the same way for the same reason. Exit status changes 1 to 2 but that
doesn't make any behavioral change.
---
src/backend/postmaster/pgarch.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/src/backend/postmaster/pgarch.c b/src/backend/postmaster/pgarch.c
index 01ffd6513c..37be0e2bbb 100644
--- a/src/backend/postmaster/pgarch.c
+++ b/src/backend/postmaster/pgarch.c
@@ -96,7 +96,6 @@ static pid_t pgarch_forkexec(void);
#endif
NON_EXEC_STATIC void PgArchiverMain(int argc, char *argv[]) pg_attribute_noreturn();
-static void pgarch_exit(SIGNAL_ARGS);
static void pgarch_waken(SIGNAL_ARGS);
static void pgarch_waken_stop(SIGNAL_ARGS);
static void pgarch_MainLoop(void);
@@ -229,7 +228,7 @@ PgArchiverMain(int argc, char *argv[])
pqsignal(SIGHUP, SignalHandlerForConfigReload);
pqsignal(SIGINT, SIG_IGN);
pqsignal(SIGTERM, SignalHandlerForShutdownRequest);
- pqsignal(SIGQUIT, pgarch_exit);
+ pqsignal(SIGQUIT, SignalHandlerForCrashExit);
pqsignal(SIGALRM, SIG_IGN);
pqsignal(SIGPIPE, SIG_IGN);
pqsignal(SIGUSR1, pgarch_waken);
@@ -246,14 +245,6 @@ PgArchiverMain(int argc, char *argv[])
exit(0);
}
-/* SIGQUIT signal handler for archiver process */
-static void
-pgarch_exit(SIGNAL_ARGS)
-{
- /* SIGQUIT means curl up and die ... */
- exit(1);
-}
-
/* SIGUSR1 signal handler for archiver process */
static void
pgarch_waken(SIGNAL_ARGS)
--
2.18.2
----Next_Part(Mon_Jun__1_18_00_01_2020_089)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="v34-0002-sequential-scan-for-dshash.patch"
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: --sync-method isn't documented to take an argument
@ 2023-10-04 13:15 Daniel Gustafsson <[email protected]>
2023-10-04 13:22 ` Re: --sync-method isn't documented to take an argument Robert Haas <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Gustafsson @ 2023-10-04 13:15 UTC (permalink / raw)
To: Robert Haas <[email protected]>; +Cc: pgsql-hackers; Nathan Bossart <[email protected]>
> On 4 Oct 2023, at 15:08, Robert Haas <[email protected]> wrote:
> This one should be something like this:
>
> <term><option>--sync-method=<replaceable>method</replaceable></option></term>
Shouldn't it be <replaceable class="parameter">method</replaceable> ?
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: --sync-method isn't documented to take an argument
2023-10-04 13:15 Re: --sync-method isn't documented to take an argument Daniel Gustafsson <[email protected]>
@ 2023-10-04 13:22 ` Robert Haas <[email protected]>
2023-10-04 13:34 ` Re: --sync-method isn't documented to take an argument Daniel Gustafsson <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Robert Haas @ 2023-10-04 13:22 UTC (permalink / raw)
To: Daniel Gustafsson <[email protected]>; +Cc: pgsql-hackers; Nathan Bossart <[email protected]>
On Wed, Oct 4, 2023 at 9:15 AM Daniel Gustafsson <[email protected]> wrote:
> > On 4 Oct 2023, at 15:08, Robert Haas <[email protected]> wrote:
> > This one should be something like this:
> >
> > <term><option>--sync-method=<replaceable>method</replaceable></option></term>
>
> Shouldn't it be <replaceable class="parameter">method</replaceable> ?
Hmm, I think you're probably right. But look at this:
<term><option>-S <replaceable>slotname</replaceable></option></term>
<term><option>--slot=<replaceable
class="parameter">slotname</replaceable></option></term>
But then in the very same file:
<term><option>-r <replaceable
class="parameter">rate</replaceable></option></term>
<term><option>--max-rate=<replaceable
class="parameter">rate</replaceable></option></term>
It doesn't look to me like we're entirely consistent about this. I
also found this in vacuumlo.sgml, and there seem to be various other
examples:
<term><option>-U <replaceable>username</replaceable></option></term>
--
Robert Haas
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: --sync-method isn't documented to take an argument
2023-10-04 13:15 Re: --sync-method isn't documented to take an argument Daniel Gustafsson <[email protected]>
2023-10-04 13:22 ` Re: --sync-method isn't documented to take an argument Robert Haas <[email protected]>
@ 2023-10-04 13:34 ` Daniel Gustafsson <[email protected]>
2023-10-04 14:35 ` Re: --sync-method isn't documented to take an argument Alvaro Herrera <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Gustafsson @ 2023-10-04 13:34 UTC (permalink / raw)
To: Robert Haas <[email protected]>; +Cc: pgsql-hackers; Nathan Bossart <[email protected]>
> On 4 Oct 2023, at 15:22, Robert Haas <[email protected]> wrote:
>
> On Wed, Oct 4, 2023 at 9:15 AM Daniel Gustafsson <[email protected]> wrote:
>>> On 4 Oct 2023, at 15:08, Robert Haas <[email protected]> wrote:
>>> This one should be something like this:
>>>
>>> <term><option>--sync-method=<replaceable>method</replaceable></option></term>
>>
>> Shouldn't it be <replaceable class="parameter">method</replaceable> ?
>
> Hmm, I think you're probably right. But look at this:
>
> <term><option>-S <replaceable>slotname</replaceable></option></term>
> <term><option>--slot=<replaceable
> class="parameter">slotname</replaceable></option></term>
>
> But then in the very same file:
>
> <term><option>-r <replaceable
> class="parameter">rate</replaceable></option></term>
> <term><option>--max-rate=<replaceable
> class="parameter">rate</replaceable></option></term>
Hmm.. that's a bit unfortunate.
> It doesn't look to me like we're entirely consistent about this.
That (sadly) applies to a fair chunk of the docs.
I can take a stab at tidying this up during breaks at the conference. It might
not be the most important bit of markup, but for anyone building the docs who
might want to use this it seems consistency will help.
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: --sync-method isn't documented to take an argument
2023-10-04 13:15 Re: --sync-method isn't documented to take an argument Daniel Gustafsson <[email protected]>
2023-10-04 13:22 ` Re: --sync-method isn't documented to take an argument Robert Haas <[email protected]>
2023-10-04 13:34 ` Re: --sync-method isn't documented to take an argument Daniel Gustafsson <[email protected]>
@ 2023-10-04 14:35 ` Alvaro Herrera <[email protected]>
0 siblings, 0 replies; 5+ messages in thread
From: Alvaro Herrera @ 2023-10-04 14:35 UTC (permalink / raw)
To: Daniel Gustafsson <[email protected]>; +Cc: Robert Haas <[email protected]>; pgsql-hackers; Nathan Bossart <[email protected]>
On 2023-Oct-04, Daniel Gustafsson wrote:
> I can take a stab at tidying this up during breaks at the conference. It might
> not be the most important bit of markup, but for anyone building the docs who
> might want to use this it seems consistency will help.
So for HTML, the result of the pg_basebackup lines are these two lines:
</p></dd><dt><span class="term"><code class="option">-S <em class="replaceable"><code>slotname</code></em></code><br /></span><span class="term"><code class="option">--slot=<em class="replaceable"><code>slotname</code></em></code></span></dt><dd><p>
and
</p></dd><dt><span class="term"><code class="option">-r <em class="replaceable"><code>rate</code></em></code><br /></span><span class="term"><code class="option">--max-rate=<em class="replaceable"><code>rate</code></em></code></span></dt><dd><p>
So I'm not sure that specifying the class="parameter" bit does anything in
reality, or that changing lines to add or remove it will have any effect.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2023-10-04 14:35 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16 08:15 [PATCH v34 1/7] Use standard crash handler in archiver. Kyotaro Horiguchi <[email protected]>
2023-10-04 13:15 Re: --sync-method isn't documented to take an argument Daniel Gustafsson <[email protected]>
2023-10-04 13:22 ` Re: --sync-method isn't documented to take an argument Robert Haas <[email protected]>
2023-10-04 13:34 ` Re: --sync-method isn't documented to take an argument Daniel Gustafsson <[email protected]>
2023-10-04 14:35 ` Re: --sync-method isn't documented to take an argument Alvaro Herrera <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox