Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vQ9LM-00CgfG-3D for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Dec 2025 19:13:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vQ9LL-0043TM-1m for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Dec 2025 19:13:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vQ9LK-0043TD-22 for pgsql-hackers@lists.postgresql.org; Mon, 01 Dec 2025 19:13:51 +0000 Received: from fout-a4-smtp.messagingengine.com ([103.168.172.147]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vQ9LI-002cfI-16 for pgsql-hackers@postgresql.org; Mon, 01 Dec 2025 19:13:50 +0000 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id D138BEC0938; Mon, 1 Dec 2025 14:13:47 -0500 (EST) Received: from phl-imap-05 ([10.202.2.95]) by phl-compute-06.internal (MEProxy); Mon, 01 Dec 2025 14:13:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1764616427; x=1764702827; bh=fnA9svSMvNZtChAMhj43mNBzdFsVbN/UcXiNNCeBeqA=; b= BuKS7yCfA584EWfBgX0L6hY6CN6V2Q3FBOyF0BTp+hpOnc5+yASlFArdsc6WPq5f HFHUIcfCzpLVRPjvumupbKIKKUeAkAmKfvA9Jprb77KRhcJAsKGSGfoFTnU7R6/5 +CHuD8IkbvA1Ela4IgWT299BwGozmxBPmfSTs5KZNMvjL9+NRgaMVayH+A+QSx3K cCLIHPz9OMJ/VuqgOrIeEtX/YSXFLOZe0Qnb0NCQ0+YlAB1VgUWvLhDuJFmfq3ct Jaom9Ne8TueOyIEF9zICPcTUoi76htJCCGln8PIryiZOh5CNUrrp7vEnRhovgVbC T/nS1aFbb/WerK1Y4WtrGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1764616427; x= 1764702827; bh=fnA9svSMvNZtChAMhj43mNBzdFsVbN/UcXiNNCeBeqA=; b=Y Gh7lcc99j5tPf9DjxQVpwFxW1ya1KHdf5nuzC3xT7gaCIxpt9EA4ZC7ZUEfAw19P Be/3ZobTPKdgkMnCFHcwAnMCRClMTqh1H1QxxPmZk9iTsjtNhMpNrANzaAfJY+us JI9iVvZ/n6JFGmvGJCja777BAMVxDLy3oDvTct33kbdg3UP8UTZHaDFlBMNhhYzA LUJUQNIKurbKUo+Zqpsx/DEHYW4pt+EI0jPfThLcuBYLhB4qE0WK7c6eagCH/aX2 vdIjfCkYGIwlvsnnuxKY70lFrm0UEsOBFrLv0crx/u9R4VsnnB5Kyy3uTbFXYSx4 gtC0mYyW4KSF919396yvQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvheekhedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtqhertdertdejnecuhfhrohhmpedfgfhulhgv rhcuvfgrvhgvihhrrgdfuceovghulhgvrhesvghulhgvrhhtohdrtghomheqnecuggftrf grthhtvghrnhepfeekueejgeevteffueegffffgfefhedtgeduffejleduuedvhfeflefg jeegfeelnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomhenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegvuhhlvghrsegvuhhl vghrthhordgtohhmpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprh gtphhtthhopehnrghthhgrnhgusghoshhsrghrthesghhmrghilhdrtghomhdprhgtphht thhopegrlhhvhhgvrhhrvgeskhhurhhilhgvmhhurdguvgdprhgtphhtthhopehpghhsqh hlqdhhrggtkhgvrhhssehpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0c21471d:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 3D47B1820054; Mon, 1 Dec 2025 14:13:47 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 X-ThreadId: A1f41I21h7FF Date: Mon, 01 Dec 2025 16:13:22 -0300 From: "Euler Taveira" To: =?UTF-8?Q?=C3=81lvaro_Herrera?= , "Nathan Bossart" Cc: pgsql-hackers Message-Id: <6a119f95-2309-464f-89d1-e17ff42a1a67@app.fastmail.com> In-Reply-To: <202512011754.hpa4uqkqtq4f@alvherre.pgsql> References: <202512011754.hpa4uqkqtq4f@alvherre.pgsql> Subject: Re: split tablecmds.c Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Dec 1, 2025, at 3:18 PM, =C3=81lvaro Herrera wrote: > My first thought would be to move code that deals with catalog changes > to files in catalog/. Also a couple of functions related to tablespac= es > could be perhaps be moved to commands/tablespace.c. > As Tom said partitioning has a big chunk of lines of code. I bet that's = the biggest portion. It seems a good candidate to be moved to a new file (partitioning and inheritance). Besides your suggestion, I would add thi= ngs that set properties (RLS, reloptions, AM, replica identity, generated co= lumns) to another file (tableutils.c?). --=20 Euler Taveira EDB https://www.enterprisedb.com/