Content-Type: multipart/mixed; boundary="------------FEVHJLOP13tAngGim8SgKqiT"
Message-ID: <6a7c7338-1aa2-4689-d171-0b0b294fdd84@illuminatedcomputing.com>
Date: Fri, 2 Dec 2022 14:18:51 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Content-Language: en-US
To: Pgsql Hackers <pgsql-hackers@postgresql.org>
From: Paul Jungwirth <pj@illuminatedcomputing.com>
Subject: Think-o in foreign key comments
Archived-At: 
 <https://www.postgresql.org/message-id/6a7c7338-1aa2-4689-d171-0b0b294fdd84%40illuminatedcomputing.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------FEVHJLOP13tAngGim8SgKqiT
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello,

I noticed a few places in the new foreign key code where a comment says 
"the ON DELETE SET NULL/DELETE clause". I believe it should say "ON 
DELETE SET NULL/DEFAULT".

These comments were added in d6f96ed94e7, "Allow specifying column list 
for foreign key ON DELETE SET actions." Here is a patch to correct them. 
I don't think you usually create a commitfest entry for tiny fixes like 
this, right? But if you'd like one please let me know and I'll add it.

Yours,

-- 
Paul              ~{:-)
pj@illuminatedcomputing.com
--------------FEVHJLOP13tAngGim8SgKqiT
Content-Type: text/x-patch; charset=UTF-8;
 name="v1-0001-Fix-FK-comment-think-o.patch"
Content-Disposition: attachment;
 filename="v1-0001-Fix-FK-comment-think-o.patch"
Content-Transfer-Encoding: base64

RnJvbSBkYzVlMzE3NzYyMjY2YjkzYmZhNDRiYjMwM2ZlMTg4Mjg1M2Q4ZGU3IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiUGF1bCBBLiBKdW5nd2lydGgiIDxwakBpbGx1bWlu
YXRlZGNvbXB1dGluZy5jb20+CkRhdGU6IEZyaSwgMiBEZWMgMjAyMiAxNDowMjo1NSAtMDgw
MApTdWJqZWN0OiBbUEFUQ0ggdjFdIEZpeCBGSyBjb21tZW50IHRoaW5rLW8KCi0tLQogc3Jj
L2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMgfCA4ICsrKystLS0tCiAxIGZpbGUgY2hh
bmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Ny
Yy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21kcy5jIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMv
dGFibGVjbWRzLmMKaW5kZXggM2U4M2YzNzViNS4uNzE2NzkzZTE1NyAxMDA2NDQKLS0tIGEv
c3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKKysrIGIvc3JjL2JhY2tlbmQvY29t
bWFuZHMvdGFibGVjbWRzLmMKQEAgLTk0NjcsMTAgKzk0NjcsMTAgQEAgdmFsaWRhdGVGa09u
RGVsZXRlU2V0Q29sdW1ucyhpbnQgbnVtZmtzLCBjb25zdCBpbnQxNiAqZmthdHRudW1zLAog
ICogbnVtZmtzIGlzIHRoZSBudW1iZXIgb2YgY29sdW1ucyBpbiB0aGUgZm9yZWlnbiBrZXkK
ICAqIHBrYXR0bnVtIGlzIHRoZSBhdHRudW0gYXJyYXkgb2YgcmVmZXJlbmNlZCBhdHRyaWJ1
dGVzLgogICogZmthdHRudW0gaXMgdGhlIGF0dG51bSBhcnJheSBvZiByZWZlcmVuY2luZyBh
dHRyaWJ1dGVzLgotICogbnVtZmtkZWxzZXRjb2xzIGlzIHRoZSBudW1iZXIgb2YgY29sdW1u
cyBpbiB0aGUgT04gREVMRVRFIFNFVCBOVUxML0RFTEVURQorICogbnVtZmtkZWxzZXRjb2xz
IGlzIHRoZSBudW1iZXIgb2YgY29sdW1ucyBpbiB0aGUgT04gREVMRVRFIFNFVCBOVUxML0RF
RkFVTFQKICAqICAgICAgKC4uLikgY2xhdXNlCiAgKiBma2RlbHNldGNvbHMgaXMgdGhlIGF0
dG51bSBhcnJheSBvZiB0aGUgY29sdW1ucyBpbiB0aGUgT04gREVMRVRFIFNFVAotICogICAg
ICBOVUxML0RFTEVURSBjbGF1c2UKKyAqICAgICAgTlVMTC9ERUZBVUxUIGNsYXVzZQogICog
cGYvcHAvZmZlcW9wZXJhdG9ycyBhcmUgT0lEIGFycmF5IG9mIG9wZXJhdG9ycyBiZXR3ZWVu
IGNvbHVtbnMuCiAgKiBvbGRfY2hlY2tfb2sgc2lnbmFscyB0aGF0IHRoaXMgY29uc3RyYWlu
dCByZXBsYWNlcyBhbiBleGlzdGluZyBvbmUgdGhhdAogICogd2FzIGFscmVhZHkgdmFsaWRh
dGVkICh0aHVzIHRoaXMgb25lIGRvZXNuJ3QgbmVlZCB2YWxpZGF0aW9uKS4KQEAgLTk2ODYs
MTAgKzk2ODYsMTAgQEAgYWRkRmtSZWN1cnNlUmVmZXJlbmNlZChMaXN0ICoqd3F1ZXVlLCBD
b25zdHJhaW50ICpma2NvbnN0cmFpbnQsIFJlbGF0aW9uIHJlbCwKICAqIHBrYXR0bnVtIGlz
IHRoZSBhdHRudW0gYXJyYXkgb2YgcmVmZXJlbmNlZCBhdHRyaWJ1dGVzLgogICogZmthdHRu
dW0gaXMgdGhlIGF0dG51bSBhcnJheSBvZiByZWZlcmVuY2luZyBhdHRyaWJ1dGVzLgogICog
cGYvcHAvZmZlcW9wZXJhdG9ycyBhcmUgT0lEIGFycmF5IG9mIG9wZXJhdG9ycyBiZXR3ZWVu
IGNvbHVtbnMuCi0gKiBudW1ma2RlbHNldGNvbHMgaXMgdGhlIG51bWJlciBvZiBjb2x1bW5z
IGluIHRoZSBPTiBERUxFVEUgU0VUIE5VTEwvREVMRVRFCisgKiBudW1ma2RlbHNldGNvbHMg
aXMgdGhlIG51bWJlciBvZiBjb2x1bW5zIGluIHRoZSBPTiBERUxFVEUgU0VUIE5VTEwvREVG
QVVMVAogICogICAgICAoLi4uKSBjbGF1c2UKICAqIGZrZGVsc2V0Y29scyBpcyB0aGUgYXR0
bnVtIGFycmF5IG9mIHRoZSBjb2x1bW5zIGluIHRoZSBPTiBERUxFVEUgU0VUCi0gKiAgICAg
IE5VTEwvREVMRVRFIGNsYXVzZQorICogICAgICBOVUxML0RFRkFVTFQgY2xhdXNlCiAgKiBv
bGRfY2hlY2tfb2sgc2lnbmFscyB0aGF0IHRoaXMgY29uc3RyYWludCByZXBsYWNlcyBhbiBl
eGlzdGluZyBvbmUgdGhhdAogICoJCXdhcyBhbHJlYWR5IHZhbGlkYXRlZCAodGh1cyB0aGlz
IG9uZSBkb2Vzbid0IG5lZWQgdmFsaWRhdGlvbikuCiAgKiBsb2NrbW9kZSBpcyB0aGUgbG9j
a21vZGUgdG8gYWNxdWlyZSBvbiBwYXJ0aXRpb25zIHdoZW4gcmVjdXJzaW5nLgotLSAKMi4y
NS4xCgo=

--------------FEVHJLOP13tAngGim8SgKqiT--