Content-Type: multipart/alternative;
 boundary="------------20qQHc7fRXzyZQxt49RgfyEy"
Message-ID: <6aa7c5a0-a4c8-dd2c-3a99-946eb7f23155@gmail.com>
Date: Sat, 11 Nov 2023 20:00:01 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: pg_basebackup check vs Windows file path limits
Content-Language: en-US
To: Andrew Dunstan <andrew@dunslane.net>, Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <666ac55b-3400-fb2c-2cea-0281bf36a53c@dunslane.net>
 <76f33a1f-ddce-80a6-6f39-fefa0668f4a6@dunslane.net>
 <3AC47E65-02A0-42BF-8A3E-B38FD09FE702@yesql.se>
 <94341cbe-9491-60e9-f01a-7ed770295cfa@dunslane.net>
 <81023744-772d-889b-99b8-bd1d58bd761b@dunslane.net>
 <67093EFC-3800-48B0-9E20-82A37A5F2A7B@yesql.se>
 <0c1c289c-f55a-1cc3-4ce1-44d7e8353e70@dunslane.net>
 <3B1D0F8A-DB97-462A-937F-73B3FCFE2713@yesql.se>
 <a7496caf-0e5b-d973-bc60-3a4308afd03c@dunslane.net>
 <8e3130c2-5c51-5cd5-9f0d-b0cd938bcd6b@dunslane.net>
 <de60e1b0-e2c9-c61a-c65d-c5b288348fa2@dunslane.net>
 <13663265-cac2-ec5d-d378-0dd44a895f8e@gmail.com>
 <9293e623-1d5e-0bd3-9b61-6129821b6f42@dunslane.net>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <9293e623-1d5e-0bd3-9b61-6129821b6f42@dunslane.net>
Archived-At: <https://www.postgresql.org/message-id/6aa7c5a0-a4c8-dd2c-3a99-946eb7f23155%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------20qQHc7fRXzyZQxt49RgfyEy
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

11.11.2023 18:18, Andrew Dunstan wrote:
>
> Hmm, maybe we should be using File::Copy::move() instead of rename(). The docco for that says:
>
>          If possible, move() will simply rename the file. Otherwise, it
>          copies the file to the new location and deletes the original. If an
>          error occurs during this copy-and-delete process, you may be left
>          with a (possibly partial) copy of the file under the destination
>          name.

Unfortunately, I've stumbled upon inability of File::Copy::move()
to move directories across filesystems, exactly as described here:
https://stackoverflow.com/questions/17628039/filecopy-move-directories-accross-drives-in-windows-not-working

(I'm sorry for not looking above rename() where this stated explicitly:
# On Windows use the short location to avoid path length issues.
# Elsewhere use $tempdir to avoid file system boundary issues with moving.
So this issue affects Windows only.)

Best regards,
Alexander
--------------20qQHc7fRXzyZQxt49RgfyEy
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">11.11.2023 18:18, Andrew Dunstan wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:9293e623-1d5e-0bd3-9b61-6129821b6f42@dunslane.net">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      <p>Hmm, maybe we should be using File::Copy::move() instead of
        rename(). The docco for that says:</p>
      <pre>        If possible, move() will simply rename the file. Otherwise, it
        copies the file to the new location and deletes the original. If an
        error occurs during this copy-and-delete process, you may be left
        with a (possibly partial) copy of the file under the destination
        name.</pre>
    </blockquote>
    <br>
    Unfortunately, I've stumbled upon inability of File::Copy::move()<br>
    to move directories across filesystems, exactly as described here:<br>
<a class="moz-txt-link-freetext" href="https://stackoverflow.com/questions/17628039/filecopy-move-directories-accross-drives-in-windows-not-working">https://stackoverflow.com/questions/17628039/filecopy-move-directories-accross-drives-in-windows-not-working</a><br>
    <br>
    (I'm sorry for not looking above rename() where this stated
    explicitly:<br>
    # On Windows use the short location to avoid path length issues.<br>
    # Elsewhere use $tempdir to avoid file system boundary issues with
    moving.<br>
    So this issue affects Windows only.)<br>
    <br>
    Best regards,<br>
    Alexander<br>
  </body>
</html>

--------------20qQHc7fRXzyZQxt49RgfyEy--