Message-ID: <6afdaff716ea203519076dfd935d86af269acc2c.camel@j-davis.com>
Subject: Re: Export log_line_prefix(); useful for emit_log_hook.
From: Jeff Davis <pgsql@j-davis.com>
To: Michael Paquier <michael@paquier.xyz>, Alvaro Herrera
	 <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@postgresql.org
Date: Mon, 04 Jul 2022 13:24:36 -0700
In-Reply-To: <YsKOtLNJy/nmlcVp@paquier.xyz>
References: <39c8197652f4d3050aedafae79fa5af31096505f.camel@j-davis.com>
	 <20220629130942.dqac3h3746pjvauq@alvherre.pgsql>
	 <YsKOtLNJy/nmlcVp@paquier.xyz>
Content-Type: multipart/mixed; boundary="=-B6+dEdWjW128+AYad3Ji"
Mime-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/6afdaff716ea203519076dfd935d86af269acc2c.camel%40j-davis.com>
Precedence: bulk


--=-B6+dEdWjW128+AYad3Ji
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Mon, 2022-07-04 at 15:54 +0900, Michael Paquier wrote:
> On Wed, Jun 29, 2022 at 03:09:42PM +0200, Alvaro Herrera wrote:
> > Hmm, maybe your hypothetical book would prefer to use a different
> > setting for log line prefix than Log_line_prefix, so it would make
> > sense
> > to pass the format string as a parameter to the function instead of
> > relying on the GUC global.

That is nicer, attached.

I also renamed the function log_status_format(), and made
log_line_prefix() a thin wrapper over that. I think that's less
confusing.

Regards,
	Jeff Davis


--=-B6+dEdWjW128+AYad3Ji
Content-Disposition: attachment;
	filename*0=v2-0001-Provide-log_status_format-useful-for-an-emit_log_hoo.;
	filename*1=patch
Content-Type: text/x-patch;
	name*0=v2-0001-Provide-log_status_format-useful-for-an-emit_log_hoo.patc;
	name*1=h; charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSA0YzY0MDQ5ZTUwMGM4MGFjNDk1NzMyZDM0YWU1NmUwNzM5MzExNWZlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBU
dWUsIDI4IEp1biAyMDIyIDExOjM5OjMzIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gUHJvdmlkZSBs
b2dfc3RhdHVzX2Zvcm1hdCgpLCB1c2VmdWwgZm9yIGFuIGVtaXRfbG9nX2hvb2suCgpSZWZhY3Rv
ciBzbyB0aGF0IGxvZ19saW5lX3ByZWZpeCgpIGlzIGEgdGhpbiB3cmFwcGVyIG92ZXIgYSBuZXcK
ZnVuY3Rpb24gbG9nX3N0YXR1c19mb3JtYXQoKSwgYW5kIG1vdmUgdGhlIGltcGxlbWVudGF0aW9u
IHRvIHRoZQpsYXR0ZXIuIEV4cG9ydCBsb2dfc3RhdHVzX2Zvcm1hdCgpIHNvIHRoYXQgaXQgY2Fu
IGJlIHVzZWQgYnkgYW4KZW1pdF9sb2dfaG9vay4KLS0tCiBzcmMvYmFja2VuZC91dGlscy9lcnJv
ci9lbG9nLmMgfCAxNSArKysrKysrKysrKystLS0KIHNyYy9pbmNsdWRlL3V0aWxzL2Vsb2cuaCAg
ICAgICB8ICAzICsrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAzIGRlbGV0
aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL2Vycm9yL2Vsb2cuYyBiL3Ny
Yy9iYWNrZW5kL3V0aWxzL2Vycm9yL2Vsb2cuYwppbmRleCA1NWVlNTQyM2FmYi4uN2IyYmI5Yzhi
NzUgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0aWxzL2Vycm9yL2Vsb2cuYworKysgYi9zcmMv
YmFja2VuZC91dGlscy9lcnJvci9lbG9nLmMKQEAgLTI0MzksMTAgKzI0MzksMTkgQEAgcHJvY2Vz
c19sb2dfcHJlZml4X3BhZGRpbmcoY29uc3QgY2hhciAqcCwgaW50ICpwcGFkZGluZykKIH0KIAog
LyoKLSAqIEZvcm1hdCB0YWcgaW5mbyBmb3IgbG9nIGxpbmVzOyBhcHBlbmQgdG8gdGhlIHByb3Zp
ZGVkIGJ1ZmZlci4KKyAqIEZvcm1hdCBsb2cgc3RhdHVzIGluZm9ybWF0aW9uIHVzaW5nIExvZ19s
aW5lX3ByZWZpeC4KICAqLwogc3RhdGljIHZvaWQKIGxvZ19saW5lX3ByZWZpeChTdHJpbmdJbmZv
IGJ1ZiwgRXJyb3JEYXRhICplZGF0YSkKK3sKKwlsb2dfc3RhdHVzX2Zvcm1hdChidWYsIExvZ19s
aW5lX3ByZWZpeCwgZWRhdGEpOworfQorCisvKgorICogRm9ybWF0IGxvZyBzdGF0dXMgaW5mbzsg
YXBwZW5kIHRvIHRoZSBwcm92aWRlZCBidWZmZXIuCisgKi8KK3ZvaWQKK2xvZ19zdGF0dXNfZm9y
bWF0KFN0cmluZ0luZm8gYnVmLCBjaGFyICpmb3JtYXQsIEVycm9yRGF0YSAqZWRhdGEpCiB7CiAJ
Lyogc3RhdGljIGNvdW50ZXIgZm9yIGxpbmUgbnVtYmVycyAqLwogCXN0YXRpYyBsb25nIGxvZ19s
aW5lX251bWJlciA9IDA7CkBAIC0yNDY2LDEwICsyNDc1LDEwIEBAIGxvZ19saW5lX3ByZWZpeChT
dHJpbmdJbmZvIGJ1ZiwgRXJyb3JEYXRhICplZGF0YSkKIAl9CiAJbG9nX2xpbmVfbnVtYmVyKys7
CiAKLQlpZiAoTG9nX2xpbmVfcHJlZml4ID09IE5VTEwpCisJaWYgKGZvcm1hdCA9PSBOVUxMKQog
CQlyZXR1cm47CQkJCQkvKiBpbiBjYXNlIGd1YyBoYXNuJ3QgcnVuIHlldCAqLwogCi0JZm9yIChw
ID0gTG9nX2xpbmVfcHJlZml4OyAqcCAhPSAnXDAnOyBwKyspCisJZm9yIChwID0gZm9ybWF0OyAq
cCAhPSAnXDAnOyBwKyspCiAJewogCQlpZiAoKnAgIT0gJyUnKQogCQl7CmRpZmYgLS1naXQgYS9z
cmMvaW5jbHVkZS91dGlscy9lbG9nLmggYi9zcmMvaW5jbHVkZS91dGlscy9lbG9nLmgKaW5kZXgg
ZjVjNmNkOTA0ZGUuLmU4OGUzZjhhODAxIDEwMDY0NAotLS0gYS9zcmMvaW5jbHVkZS91dGlscy9l
bG9nLmgKKysrIGIvc3JjL2luY2x1ZGUvdXRpbHMvZWxvZy5oCkBAIC0xNiw2ICsxNiw4IEBACiAK
ICNpbmNsdWRlIDxzZXRqbXAuaD4KIAorI2luY2x1ZGUgImxpYi9zdHJpbmdpbmZvLmgiCisKIC8q
IEVycm9yIGxldmVsIGNvZGVzICovCiAjZGVmaW5lIERFQlVHNQkJMTAJCQkvKiBEZWJ1Z2dpbmcg
bWVzc2FnZXMsIGluIGNhdGVnb3JpZXMgb2YKIAkJCQkJCQkJICogZGVjcmVhc2luZyBkZXRhaWwu
ICovCkBAIC00MzksNiArNDQxLDcgQEAgZXh0ZXJuIFBHRExMSU1QT1JUIGJvb2wgc3lzbG9nX3Nw
bGl0X21lc3NhZ2VzOwogI2RlZmluZSBMT0dfREVTVElOQVRJT05fSlNPTkxPRwkxNgogCiAvKiBP
dGhlciBleHBvcnRlZCBmdW5jdGlvbnMgKi8KK2V4dGVybiB2b2lkIGxvZ19zdGF0dXNfZm9ybWF0
KFN0cmluZ0luZm8gYnVmLCBjaGFyICpmb3JtYXQsIEVycm9yRGF0YSAqZWRhdGEpOwogZXh0ZXJu
IHZvaWQgRGVidWdGaWxlT3Blbih2b2lkKTsKIGV4dGVybiBjaGFyICp1bnBhY2tfc3FsX3N0YXRl
KGludCBzcWxfc3RhdGUpOwogZXh0ZXJuIGJvb2wgaW5fZXJyb3JfcmVjdXJzaW9uX3Ryb3VibGUo
dm9pZCk7Ci0tIAoyLjE3LjEKCg==


--=-B6+dEdWjW128+AYad3Ji--