User-Agent: Cyrus-JMAP/3.5.0-alpha0-531-g1160beca77-fm-20210705.001-g1160beca
Mime-Version: 1.0
Message-Id: <6b6ef1f8-eaa2-4cdd-8680-14f06f8093fd@www.fastmail.com>
In-Reply-To: <513ffc6c-f8da-a889-9fc7-a7d9499cd72c@enterprisedb.com>
References: 
 <CA+HiwqH+9NK5m-=BOYpzjH5UEpeWjT_3HEm4XBYNrda88naGMQ@mail.gmail.com>
 <7e4b5c48-a3d3-4b7e-b455-2d50c60a0ab7@www.fastmail.com>
 <57373e8b-1264-cd37-404e-8edbcf7884cc@enterprisedb.com>
 <d7483e04-7c5f-4881-a9a0-2363b2e52f78@www.fastmail.com>
 <CAH2L28tvKGLO9ZRFsaA5msXqZzF6wHgxgXNvnCQ2dRQfs1T8XQ@mail.gmail.com>
 <b02b43c7-3b84-4ca4-8218-94ea486c2fce@www.fastmail.com>
 <CAA4eK1Lu7oPHm2j=nLeqZLVoro76E0EWvH+5wmGG39iJNBzUog@mail.gmail.com>
 <86d76e89-9a96-411a-8077-f8918cbae2e1@www.fastmail.com>
 <CAHut+PvrJHz_9HG5jvqHWe=FZLz9A+CxyJDyZKsHmY8THU+pjg@mail.gmail.com>
 <3dbf7241-a417-45c9-9a0e-04a079de9b9f@www.fastmail.com>
 <CAHut+PvCWX8WauZJkXfgL08nn8+rDsTdxQinhyL1z2+E7r06fw@mail.gmail.com>
 <CAA4eK1LPh+KCALU1Eo4itWq+bYU6NzUGr4dwypMynM3Skjvv5A@mail.gmail.com>
 <0ca5b27f-edf8-4ef9-a9e2-533216890f62@www.fastmail.com>
 <CAJcOf-dApxx3mqeHZ_20O-6hGOXmpMuqPpNb+3ZF3ENfb0oHoA@mail.gmail.com>
 <34b61db2-3e26-42ed-bb84-b14a9fe0a60d@www.fastmail.com>
 <849ee491-bba3-c0ae-cc25-4fce1c03f105@enterprisedb.com>
 <513ffc6c-f8da-a889-9fc7-a7d9499cd72c@enterprisedb.com>
Date: Mon, 12 Jul 2021 16:53:08 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Tomas Vondra" <tomas.vondra@enterprisedb.com>,
 "Greg Nancarrow" <gregn4422@gmail.com>
Cc: "Amit Kapila" <amit.kapila16@gmail.com>,
 "Peter Smith" <smithpb2250@gmail.com>,
 "Rahila Syed" <rahilasyed90@gmail.com>,
 "Peter Eisentraut" <peter.eisentraut@enterprisedb.com>,
 =?UTF-8?Q?=C3=96nder_Kalac=C4=B1?= <onderkalaci@gmail.com>,
 japin <japinli@hotmail.com>, "Michael Paquier" <michael@paquier.xyz>,
 "David Steele" <david@pgmasters.net>, "Craig Ringer" <craig@2ndquadrant.com>,
 "Tomas Vondra" <tomas.vondra@2ndquadrant.com>,
 "Amit Langote" <amitlangote09@gmail.com>,
 "PostgreSQL Hackers" <pgsql-hackers@lists.postgresql.org>
Subject: Re: row filtering for logical replication
Content-Type: multipart/alternative;
 boundary=f1039674b13046ada70be14f4653ccc1
Archived-At: 
 <https://www.postgresql.org/message-id/6b6ef1f8-eaa2-4cdd-8680-14f06f8093fd%40www.fastmail.com>
Precedence: bulk

--f1039674b13046ada70be14f4653ccc1
Content-Type: text/plain

On Mon, Jul 12, 2021, at 8:44 AM, Tomas Vondra wrote:
> While looking at the other logrep patch [1] (column filtering) I noticed
> Alvaro's comment regarding a new parsenode (PublicationTable) not having
> read/out/equal/copy funcs. I'd bet the same thing applies here, so
> perhaps see if the patch needs the same fix.
Good catch! I completely forgot about _copyPublicationTable() and
_equalPublicationTable().


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--f1039674b13046ada70be14f4653ccc1
Content-Type: text/html

<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Mon, Jul 12, 2021, at 8:44 AM, Tomas Vondra wrote:<br></div><blockquote type="cite" id="qt" style=""><div>While looking at the other logrep patch [1] (column filtering) I noticed<br></div><div>Alvaro's comment regarding a new parsenode (PublicationTable) not having<br></div><div>read/out/equal/copy funcs. I'd bet the same thing applies here, so<br></div><div>perhaps see if the patch needs the same fix.<br></div></blockquote><div>Good catch! I completely forgot about _copyPublicationTable() and<br></div><div>_equalPublicationTable().<br></div><div><br></div><div><br></div><div id="sig112409080"><div class="signature">--<br></div><div class="signature">Euler Taveira<br></div><div class="signature">EDB&nbsp;&nbsp; <a href="https://www.enterprisedb.com/">https://www.enterprisedb.com/</a><br></div></div><div><br></div></body></html>
--f1039674b13046ada70be14f4653ccc1--