Message-ID: <6b8191a0-e0f6-b204-e6c0-f7f1a5f349c0@enterprisedb.com>
Date: Mon, 24 Jan 2022 21:31:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.0
Subject: Re: PublicationActions - use bit flags.
Content-Language: en-US
To: Greg Nancarrow <gregn4422@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Peter Smith <smithpb2250@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <3b7f2bdd-77ed-00d7-437c-dd9c37e6a2fa@enterprisedb.com>
 <202112201714.ql732mnfdrtc@alvherre.pgsql>
 <CAJcOf-d0T+9jy3ois4eytkX_NPpfWMiSA5a=23_5TXSiU26BEg@mail.gmail.com>
 <2683410.1640048186@sss.pgh.pa.us>
 <CAJcOf-cXspVxTe7pe6QGyCOq6tmftgrxXZ_yRe53mx8L9wqXPw@mail.gmail.com>
 <CAJcOf-d0=vQx1Pzbf+LVarywejJFS5W+M6uR+2d0oeEJ2VQ+Ew@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <CAJcOf-d0=vQx1Pzbf+LVarywejJFS5W+M6uR+2d0oeEJ2VQ+Ew@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/6b8191a0-e0f6-b204-e6c0-f7f1a5f349c0%40enterprisedb.com>
Precedence: bulk


On 21.01.22 01:05, Greg Nancarrow wrote:
> On Tue, Dec 21, 2021 at 12:55 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
>>
>> On Tue, Dec 21, 2021 at 11:56 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>>
>>> Removing this is not good:
>>>
>>>          if (relation->rd_pubactions)
>>> -       {
>>>                  pfree(relation->rd_pubactions);
>>> -               relation->rd_pubactions = NULL;
>>> -       }
>>>
>>> If the subsequent palloc fails, you've created a problem where
>>> there was none before.
>>>
>>
>> Oops, yeah, I got carried away; if palloc() failed and called exit(),
>> then it would end up crashing when trying to use/pfree rd_pubactions
>> again.
>> Better leave that line in ...
>>
> 
> Attaching an updated patch to fix that oversight.
> This patch thus fixes the original palloc issue in a minimal way,
> keeping the same relcache structure.

Why can't GetRelationPublicationActions() have the PublicationActions as 
a return value, instead of changing it to an output argument?