Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tstib-006YS9-Qm for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Mar 2025 01:20:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tstia-00AnVT-BN for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Mar 2025 01:20:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tstiZ-00AnVL-T5 for pgsql-hackers@lists.postgresql.org; Fri, 14 Mar 2025 01:20:08 +0000 Received: from fout-b1-smtp.messagingengine.com ([202.12.124.144]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tstiX-002hvP-2x for pgsql-hackers@lists.postgresql.org; Fri, 14 Mar 2025 01:20:07 +0000 Received: from phl-compute-13.internal (phl-compute-13.phl.internal [10.202.2.53]) by mailfout.stl.internal (Postfix) with ESMTP id 1BCF711401C8; Thu, 13 Mar 2025 21:20:05 -0400 (EDT) Received: from phl-imap-09 ([10.202.2.99]) by phl-compute-13.internal (MEProxy); Thu, 13 Mar 2025 21:20:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1741915204; x=1742001604; bh=UpO658nizE SaNRuHle4kHiPhAx7PIeDpSeN/QG6yogU=; b=CF5oDpboeGY8ts2uwqOk7FXkbl eoTLCRJi8qVv62YgOBfFf1s8HkygCbyNW+DTRwvN8XgjG/rhzGFRezxk+TmrZQ/f Qy2wR7ioaXqGRG/fUOqB4K+drB2U4JkeOvTvV+UdT28l/EQimw30wa1pgJFayUk7 GIspkpijgbHVd0uCLrD6AZAjqcp7JZku0+ZxanOut8tAv+cOwDGp1tp0935x4Psf uz5qHYz+EKsveu8NiFtZf8pJQvkPqZFds04IZYW/f7Ymr5RsHw0WOSVGCQ/F2S4B b42FV9CI1RIJtdgCgAUFjVQGoiQVgwGS0cBaNmrSRx8xpuMsXG+B2SlLsSBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1741915204; x=1742001604; bh=UpO658nizESaNRuHle4kHiPhAx7PIeDpSeN /QG6yogU=; b=W129t9e0ZbpW25Gyjky5DKAJW3rhMjw4jTBYGC1oGsehNimEje1 9HgTl07D46kRBdTYQNcKY6v1yUF/CgnVHl205mpJicwo/2FleRXmGAc98aVnGrsM X2+sDF7oSY5/aNDgyo1Dstkk7g338hM+VhOd9LGuWI2UE/kSycs/Cy5IeW8cAYdO cPoDRYR4e/0YP+ImDie4c4HxHsvORvwVi5MYqs7z4RyzY9QslSuOycPaw6mc5Aya 9mI/6MLYup6P9XJK/c01zHAReJz97fNMgxs7L4VdtcLNnUEdUutcFKp4HCBxFpD7 3CaXH7gkfJA0h35bvwGSZX9Mrd7z5I4QdaA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvdelgeelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgesrgdtreerredt tdenucfhrhhomhepfdfguhhlvghrucfvrghvvghirhgrfdcuoegvuhhlvghrsegvuhhlvg hrthhordgtohhmqeenucggtffrrghtthgvrhhnpeekheetvefggedtudevjeehjeffteeu vdfhfedtvdfgleektdfgfeektdfhheekvdenucffohhmrghinhepvghnthgvrhhprhhish gvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepvghulhgvrhesvghulhgvrhhtohdrtghomhdpnhgspghrtghpthhtohepledpmh houggvpehsmhhtphhouhhtpdhrtghpthhtoheprghnughrvghssegrnhgrrhgriigvlhdr uggvpdhrtghpthhtohepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhgpdhrtghpth htoheprghmihhtrdhkrghpihhlrgduieesghhmrghilhdrtghomhdprhgtphhtthhopegs vghrthhrrghnuggurhhouhhvohhtrdhpghesghhmrghilhdrtghomhdprhgtphhtthhope gshhgrrhgrthhhrdhruhhpihhrvgguugihfhhorhhpohhsthhgrhgvshesghhmrghilhdr tghomhdprhgtphhtthhopehsrgifrggurgdrmhhshhhksehgmhgrihhlrdgtohhmpdhrtg hpthhtohepshhhvhgvthgrrdhmrghlihhksehgmhgrihhlrdgtohhmpdhrtghpthhtohep shhmihhthhhpsgdvvdehtdesghhmrghilhdrtghomhdprhgtphhtthhopehpghhsqhhlqd hhrggtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0c21471d:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id DE88A780068; Thu, 13 Mar 2025 21:20:03 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Thu, 13 Mar 2025 22:19:43 -0300 From: "Euler Taveira" To: "Masahiko Sawada" , "Bertrand Drouvot" Cc: "Amit Kapila" , "Andres Freund" , "Peter Smith" , "Peter Eisentraut" , "shveta.malik@gmail.com" , "Bharath Rupireddy" , pgsql-hackers@lists.postgresql.org Message-Id: <6b9a41c8-ba6e-4cca-a676-d10d9d4e01ad@app.fastmail.com> In-Reply-To: References: <5qbxud4pvnvmtuoi7weiizm5hmumxaeohx4vztfhrwlfhyz6rj@buh4435mllwo> Subject: Re: Add contrib/pg_logicalsnapinspect Content-Type: multipart/alternative; boundary=9e81e91359c445c3ae7124ff51072110 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --9e81e91359c445c3ae7124ff51072110 Content-Type: text/plain Content-Transfer-Encoding: 7bit On Tue, Mar 11, 2025, at 7:34 PM, Masahiko Sawada wrote: > Pushed. pgindent is saying this commit included some extra tabs. git diff diff --git a/contrib/pg_logicalinspect/pg_logicalinspect.c b/contrib/pg_logicalinspect/pg_logicalinspect.c index ff6c682679f..5a44718bea8 100644 --- a/contrib/pg_logicalinspect/pg_logicalinspect.c +++ b/contrib/pg_logicalinspect/pg_logicalinspect.c @@ -86,7 +86,7 @@ parse_error: ereport(ERROR, errmsg("invalid snapshot file name \"%s\"", filename)); - return InvalidXLogRecPtr; /* keep compiler quiet */ + return InvalidXLogRecPtr; /* keep compiler quiet */ } -- Euler Taveira EDB https://www.enterprisedb.com/ --9e81e91359c445c3ae7124ff51072110 Content-Type: text/html Content-Transfer-Encoding: quoted-printable
On Tue, Mar 11,= 2025, at 7:34 PM, Masahiko Sawada wrote:
Pushed.

pgindent is saying this commit included some extra tabs.

git diff
diff --git a/contrib/pg_lo= gicalinspect/pg_logicalinspect.c b/contrib/pg_logicalinspect/pg_logicali= nspect.c
index ff6c6= 82679f..5a44718bea8 100644
--- a/contrib/pg_logicalinspect/pg_logicalinspect.c
+++ b/contrib/pg_logicalinspect/p= g_logicalinspect.c
@= @ -86,7 +86,7 @@ parse_error:
<= /div>
    ereport(ERROR,
        =     errmsg("invalid snapshot file name \"%s\"", filename)= );
 
-   return InvalidXLo= gRecPtr;          &nbs= p;        /* keep compiler quiet */
+   return = InvalidXLogRecPtr;   /* keep compiler quiet */
} 


--
Euler Taveira
EDB   https://www= .enterprisedb.com/

--9e81e91359c445c3ae7124ff51072110--