Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fkOnU-0000x3-Hr for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Jul 2018 07:10:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fkOnS-0003lp-F3 for pgsql-hackers@arkaria.postgresql.org; Tue, 31 Jul 2018 07:10:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fkOnS-0003lX-5O for pgsql-hackers@lists.postgresql.org; Tue, 31 Jul 2018 07:10:18 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fkOnO-0005e5-UY for pgsql-hackers@postgresql.org; Tue, 31 Jul 2018 07:10:17 +0000 Received: by mail-lf1-x144.google.com with SMTP id j143-v6so9950092lfj.12 for ; Tue, 31 Jul 2018 00:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=AjRxXn4m69hHvetniU23hoDPmE+77QjZlNf/weswMLs=; b=Obe47VKqtIzrTpxeLycLPk6Bsu4a231BGsgmI2InaH+UNkMZ2AkpdLMQQqlj/Oran3 m7fPjM7HIFXTCs0Mm9tfHyH/n+XxBuEGox17cBiWGu//C7a/oP/lh9IxFwj9fWnzHeS+ N/6QRNMdQCH1FFD9PZCwRASD6ez0paHYUSCANg8MiV7I3KZ/PsP6JIYthMoU92aNs/kW Sjly5S5Y1gZLGHmMeDc/HdXM6qpV0cyFOEPxgXzOeYZg/nU09JqGBbIMZe2v7wGsc9Zt +Vk4BkI20NOc3DqabOgpNfuPHTestFfQ5Bp551Jganiab88kmrndDRQSdS955iN1F2u3 H9TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=AjRxXn4m69hHvetniU23hoDPmE+77QjZlNf/weswMLs=; b=LcBo6qG3eBZRv/VIcg2Cc/6D8I/Fxb6SZCrRjW0q78uqBiEu4uPNiS34K0qETS63jx qwDj2dQpqdf5PDBHOTMD8okywAB4oDI7884dPBf35BUug9IVG0Ig1lindn7SYYenzKNQ Ia2YnVor7FnZFN37ywvhbLekhXaLceDlSF6lZ0CCtL9W3Sn6raV4jy8CbgChgOytoW4y JtsA8rmliMoQOUbbD/85c5CGya8NXh93uO08RSaispmbVCSRvbJP7320Jicb3mRw4jnZ 93r7DZb1HSMDfjrEtb2b340fbGzGoLxKbILjIXyla+8husF+s7ADyQi+/ntEvta76Tgo /5sA== X-Gm-Message-State: AOUpUlFxWWtkztQpDH9oUeChZZpZFmU4nRh2EP+JPaxAJcpbIfZfxSho IHvxZRBujQQ6Zq0be0LgP3ttpx3T X-Google-Smtp-Source: AAOMgpfYESLCYUtbIqPHjlShmsraKY/ZUEXqSrN0nhNjjN1cmnRKnk+sy0UmeZnNsinNOwxyZSEkaw== X-Received: by 2002:a19:b24e:: with SMTP id b75-v6mr11596019lff.11.1533021013829; Tue, 31 Jul 2018 00:10:13 -0700 (PDT) Received: from [1.0.0.7] ([178.155.4.44]) by smtp.gmail.com with ESMTPSA id n23-v6sm2424253ljh.77.2018.07.31.00.10.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Jul 2018 00:10:13 -0700 (PDT) Subject: Re: make installcheck-world in a clean environment To: Tom Lane Cc: Peter Eisentraut , Robert Haas , "pgsql-hackers@postgresql.org" References: <24834.1525712835@sss.pgh.pa.us> <0401efec-68f1-679d-3ea3-21d4e8dd11af@gmail.com> <15981.1532988967@sss.pgh.pa.us> From: Alexander Lakhin Message-ID: <6c7747ab-e99b-c537-d8c5-9be8378573ee@gmail.com> Date: Tue, 31 Jul 2018 10:10:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <15981.1532988967@sss.pgh.pa.us> Content-Type: multipart/alternative; boundary="------------40728DEBB7FD38A5AAC64B31" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------40728DEBB7FD38A5AAC64B31 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hello Tom, 31.07.2018 01:16, Tom Lane wrote: > Alexander Lakhin writes: >> 14.07.2018 13:57, Peter Eisentraut wrote: >>> On 06.07.18 09:45, Alexander Lakhin wrote: >>>> ./configure --enable-tap-tests >>>> make install >>>> make install -C contrib >>>> chown -R postgres:postgres /usr/local/pgsql/ >>>> /usr/local/pgsql/bin/initdb -D /usr/local/pgsql/data >>>> /usr/local/pgsql/bin/pg_ctl start -l logfile -D /usr/local/pgsql/data >>>> /make clean/ >>>> # Also you can just install binary packages to get the same state. >>>> >>>> make installcheck-world >>>> # This check fails. > I remain pretty skeptical that this is a sensible way to proceed, > especially not if what you're testing is installed binary packages. > You're creating yet *another* hazard for version-skew-like problems, > namely that there's no certainty that you gave configure arguments > that're compatible with what the installed packages used. I believe that `installed_instance_path\bin\pg_config --configure` can show the arguments, which can be used to perform ./configure and then make installcheck for binary packages. I understand that it should be done on the same platform and with exactly the same PG version, but I think it's the only right way to check the binaries (to perform user-centric testing). Best regards, ------ Alexander Lakhin Postgres Professional: http://www.postgrespro.com The Russian Postgres Company --------------40728DEBB7FD38A5AAC64B31 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
Hello Tom,

31.07.2018 01:16, Tom Lane wrote:
Alexander Lakhin <exclusion@gmail.com> writes:

14.07.2018 13:57, Peter Eisentraut wrote:

On 06.07.18 09:45, Alexander Lakhin wrote:

./configure --enable-tap-tests
make install
make install -C contrib
chown -R postgres:postgres /usr/local/pgsql/
/usr/local/pgsql/bin/initdb -D /usr/local/pgsql/data
/usr/local/pgsql/bin/pg_ctl start -l logfile -D /usr/local/pgsql/data
/make clean/
# Also you can just install binary packages to get the same state.

make installcheck-world
# This check fails.

I remain pretty skeptical that this is a sensible way to proceed,
especially not if what you're testing is installed binary packages.
You're creating yet *another* hazard for version-skew-like problems,
namely that there's no certainty that you gave configure arguments
that're compatible with what the installed packages used.
I believe that `installed_instance_path\bin\pg_config --configure` can show the arguments, which can be used to perform ./configure and then make installcheck for binary packages.
I understand that it should be done on the same platform and with exactly the same PG version, but I think it's the only right way to check the binaries (to perform user-centric testing).

Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company --------------40728DEBB7FD38A5AAC64B31--