Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXfcL-00025h-V9 for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Sep 2022 09:20:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oXfcK-0002UW-EE for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Sep 2022 09:20:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXfcK-0002UN-4L for pgsql-hackers@lists.postgresql.org; Mon, 12 Sep 2022 09:20:36 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXfcH-0007NQ-Bc for pgsql-hackers@postgresql.org; Mon, 12 Sep 2022 09:20:35 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 1A73E6099B; Mon, 12 Sep 2022 18:20:30 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.7 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_d0a458914af5c9db7c16086b268bc9d3" Content-Transfer-Encoding: 7bit Date: Mon, 12 Sep 2022 18:20:30 +0900 From: bt22kawamotok To: Shinya Kato Cc: pgsql-hackers@postgresql.org Subject: Re: [PATCH]Feature improvement for MERGE tab completion In-Reply-To: <7d7eef0f596e449746766ff4fb7c9061@oss.nttdata.com> References: <9f1ad2a87a58cd5e7d64f3993130958d@oss.nttdata.com> <359a46c295eae938d84552c11818ab62@oss.nttdata.com> <7d7eef0f596e449746766ff4fb7c9061@oss.nttdata.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <6c943aa7b6064b56e7ebeb901f7c24b4@oss.nttdata.com> X-Sender: bt22kawamotok@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_d0a458914af5c9db7c16086b268bc9d3 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Other than this correction, the parts that can be put together in OR were corrected in fix_tab_completion_merge_v4.patch. Kotaro Kawamoto --=_d0a458914af5c9db7c16086b268bc9d3 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=fix_tab_completion_merge_v4.patch Content-Disposition: attachment; filename=fix_tab_completion_merge_v4.patch; size=3330 ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUuYyBiL3NyYy9iaW4vcHNxbC90 YWItY29tcGxldGUuYwppbmRleCA2MmEzOTc3OWI5Li44YjQ5OGY2YTg2IDEwMDY0NAotLS0gYS9z cmMvYmluL3BzcWwvdGFiLWNvbXBsZXRlLmMKKysrIGIvc3JjL2Jpbi9wc3FsL3RhYi1jb21wbGV0 ZS5jCkBAIC00MDY2LDIwICs0MDY2LDE2IEBAIHBzcWxfY29tcGxldGlvbihjb25zdCBjaGFyICp0 ZXh0LCBpbnQgc3RhcnQsIGludCBlbmQpCiAJZWxzZSBpZiAoVGFpbE1hdGNoZXMoIk1FUkdFIiwg IklOVE8iLCBNYXRjaEFueSwgIlVTSU5HIikpCiAJCUNPTVBMRVRFX1dJVEhfU0NIRU1BX1FVRVJZ KFF1ZXJ5X2Zvcl9saXN0X29mX3RhYmxlcyk7CiAJLyogd2l0aCBbQVNdIGFsaWFzICovCi0JZWxz ZSBpZiAoVGFpbE1hdGNoZXMoIk1FUkdFIiwgIklOVE8iLCBNYXRjaEFueSwgIkFTIiwgTWF0Y2hB bnkpKQorCWVsc2UgaWYgKFRhaWxNYXRjaGVzKCJNRVJHRSIsICJJTlRPIiwgTWF0Y2hBbnksICJB UyIsIE1hdGNoQW55KSB8fAorCQkJIChUYWlsTWF0Y2hlcygiTUVSR0UiLCAiSU5UTyIsIE1hdGNo QW55LCBNYXRjaEFueSkgJiYgIVRhaWxNYXRjaGVzKCJBUyIpKSkKIAkJQ09NUExFVEVfV0lUSCgi VVNJTkciKTsKLQllbHNlIGlmIChUYWlsTWF0Y2hlcygiTUVSR0UiLCAiSU5UTyIsIE1hdGNoQW55 LCBNYXRjaEFueSkpCi0JCUNPTVBMRVRFX1dJVEgoIlVTSU5HIik7Ci0JZWxzZSBpZiAoVGFpbE1h dGNoZXMoIk1FUkdFIiwgIklOVE8iLCBNYXRjaEFueSwgIkFTIiwgTWF0Y2hBbnksICJVU0lORyIp KQotCQlDT01QTEVURV9XSVRIX1NDSEVNQV9RVUVSWShRdWVyeV9mb3JfbGlzdF9vZl90YWJsZXMp OwotCWVsc2UgaWYgKFRhaWxNYXRjaGVzKCJNRVJHRSIsICJJTlRPIiwgTWF0Y2hBbnksIE1hdGNo QW55LCAiVVNJTkciKSkKKwllbHNlIGlmIChUYWlsTWF0Y2hlcygiTUVSR0UiLCAiSU5UTyIsIE1h dGNoQW55LCAiQVMiLCBNYXRjaEFueSwgIlVTSU5HIikgfHwKKwkJCSBUYWlsTWF0Y2hlcygiTUVS R0UiLCAiSU5UTyIsIE1hdGNoQW55LCBNYXRjaEFueSwgIlVTSU5HIikpCiAJCUNPTVBMRVRFX1dJ VEhfU0NIRU1BX1FVRVJZKFF1ZXJ5X2Zvcl9saXN0X29mX3RhYmxlcyk7CiAJLyogT04gKi8KLQll bHNlIGlmIChUYWlsTWF0Y2hlcygiTUVSR0UiLCAiSU5UTyIsIE1hdGNoQW55LCAiVVNJTkciLCBN YXRjaEFueSkpCi0JCUNPTVBMRVRFX1dJVEgoIk9OIik7Ci0JZWxzZSBpZiAoVGFpbE1hdGNoZXMo IklOVE8iLCBNYXRjaEFueSwgIkFTIiwgTWF0Y2hBbnksICJVU0lORyIsIE1hdGNoQW55LCAiQVMi LCBNYXRjaEFueSkpCi0JCUNPTVBMRVRFX1dJVEgoIk9OIik7Ci0JZWxzZSBpZiAoVGFpbE1hdGNo ZXMoIklOVE8iLCBNYXRjaEFueSwgTWF0Y2hBbnksICJVU0lORyIsIE1hdGNoQW55LCBNYXRjaEFu eSkpCisJZWxzZSBpZiAoVGFpbE1hdGNoZXMoIk1FUkdFIiwgIklOVE8iLCBNYXRjaEFueSwgIlVT SU5HIiwgTWF0Y2hBbnkpIHx8CisJCQkgVGFpbE1hdGNoZXMoIklOVE8iLCBNYXRjaEFueSwgIkFT IiwgTWF0Y2hBbnksICJVU0lORyIsIE1hdGNoQW55LCAiQVMiLCBNYXRjaEFueSkgfHwKKwkJCSBU YWlsTWF0Y2hlcygiSU5UTyIsIE1hdGNoQW55LCBNYXRjaEFueSwgIlVTSU5HIiwgTWF0Y2hBbnks IE1hdGNoQW55KSkKIAkJQ09NUExFVEVfV0lUSCgiT04iKTsKIAkvKiBPTiBjb25kaXRpb24gKi8K IAllbHNlIGlmIChUYWlsTWF0Y2hlcygiSU5UTyIsIE1hdGNoQW55LCAiVVNJTkciLCBNYXRjaEFu eSwgIk9OIikpCkBAIC00MDg5LDE4ICs0MDg1LDE5IEBAIHBzcWxfY29tcGxldGlvbihjb25zdCBj aGFyICp0ZXh0LCBpbnQgc3RhcnQsIGludCBlbmQpCiAJZWxzZSBpZiAoVGFpbE1hdGNoZXMoIklO VE8iLCBNYXRjaEFueSwgTWF0Y2hBbnksICJVU0lORyIsIE1hdGNoQW55LCBNYXRjaEFueSwgIk9O IikpCiAJCUNPTVBMRVRFX1dJVEhfQVRUUihwcmV2Nl93ZCk7CiAJLyogV0hFTiBbTk9UXSBNQVRD SEVEICovCi0JZWxzZSBpZiAoVGFpbE1hdGNoZXMoIlVTSU5HIiwgTWF0Y2hBbnksICJPTiIsIE1h dGNoQW55KSkKKwllbHNlIGlmIChUYWlsTWF0Y2hlcygiVVNJTkciLCBNYXRjaEFueSwgIk9OIiwg TWF0Y2hBbnkpIHx8IAorCSAgICAgICAgIFRhaWxNYXRjaGVzKCJVU0lORyIsIE1hdGNoQW55LCAi QVMiLCBNYXRjaEFueSwgIk9OIiwgTWF0Y2hBbnkpIHx8CisJICAgICAgICAgVGFpbE1hdGNoZXMo IlVTSU5HIiwgTWF0Y2hBbnksIE1hdGNoQW55LCAiT04iLCBNYXRjaEFueSkpCiAJCUNPTVBMRVRF X1dJVEgoIldIRU4gTUFUQ0hFRCIsICJXSEVOIE5PVCBNQVRDSEVEIik7Ci0JZWxzZSBpZiAoVGFp bE1hdGNoZXMoIlVTSU5HIiwgTWF0Y2hBbnksICJBUyIsIE1hdGNoQW55LCAiT04iLCBNYXRjaEFu eSkpCi0JCUNPTVBMRVRFX1dJVEgoIldIRU4gTUFUQ0hFRCIsICJXSEVOIE5PVCBNQVRDSEVEIik7 Ci0JZWxzZSBpZiAoVGFpbE1hdGNoZXMoIlVTSU5HIiwgTWF0Y2hBbnksIE1hdGNoQW55LCAiT04i LCBNYXRjaEFueSkpCi0JCUNPTVBMRVRFX1dJVEgoIldIRU4gTUFUQ0hFRCIsICJXSEVOIE5PVCBN QVRDSEVEIik7Ci0JZWxzZSBpZiAoVGFpbE1hdGNoZXMoIldIRU4iLCAiTUFUQ0hFRCIpKQotCQlD T01QTEVURV9XSVRIKCJUSEVOIiwgIkFORCIpOwotCWVsc2UgaWYgKFRhaWxNYXRjaGVzKCJXSEVO IiwgIk5PVCIsICJNQVRDSEVEIikpCisJZWxzZSBpZiAoVGFpbE1hdGNoZXMoIlVTSU5HIiwgTWF0 Y2hBbnksICJPTiIsIE1hdGNoQW55LCAiV0hFTiIpIHx8CisJCQkgVGFpbE1hdGNoZXMoIlVTSU5H IiwgTWF0Y2hBbnksICJBUyIsIE1hdGNoQW55LCAiT04iLCBNYXRjaEFueSwgIldIRU4iKSB8fAor CQkJIFRhaWxNYXRjaGVzKCJVU0lORyIsIE1hdGNoQW55LCBNYXRjaEFueSwgIk9OIiwgTWF0Y2hB bnksICJXSEVOIikpCisJCUNPTVBMRVRFX1dJVEgoIk1BVENIRUQiLCAiTk9UIE1BVENIRUQiKTsK KwllbHNlIGlmIChUYWlsTWF0Y2hlcygiV0hFTiIsICJNQVRDSEVEIikgfHwgCisJCQkgVGFpbE1h dGNoZXMoIldIRU4iLCAiTk9UIiwgIk1BVENIRUQiKSkKIAkJQ09NUExFVEVfV0lUSCgiVEhFTiIs ICJBTkQiKTsKIAllbHNlIGlmIChUYWlsTWF0Y2hlcygiV0hFTiIsICJNQVRDSEVEIiwgIlRIRU4i KSkKLQkJQ09NUExFVEVfV0lUSCgiVVBEQVRFIiwgIkRFTEVURSIpOworCQlDT01QTEVURV9XSVRI KCJVUERBVEUiLCAiREVMRVRFIiwgIkRPIE5PVEhJTkciKTsKIAllbHNlIGlmIChUYWlsTWF0Y2hl cygiV0hFTiIsICJOT1QiLCAiTUFUQ0hFRCIsICJUSEVOIikpCiAJCUNPTVBMRVRFX1dJVEgoIklO U0VSVCIsICJETyBOT1RISU5HIik7CiAK --=_d0a458914af5c9db7c16086b268bc9d3--