MIME-Version: 1.0
Date: Wed, 21 Sep 2022 14:10:42 +0700
From: a.kozhemyakin@postgrespro.ru
To: Amul Sul <sulamul@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 thomas.munro@gmail.com, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org,
 sulamul@gmail.com, noah@leadboat.com
Subject: Re: tweak to a few index tests to hits ambuildempty() routine.
In-Reply-To: 
 <CAAJ_b97etWoGCxOGrtZSZ4sZAh-7NjZvLQbmnqi0ka3Lg2=mQA@mail.gmail.com>
References: 
 <CAAJ_b95nneRCLM-=qELEdgCYSk6W_++-C+Q_t+wH3SW-hF50iw@mail.gmail.com>
 <b00c8ee096ee46cd25c183125562a1a7@postgrespro.ru>
 <fa00047064f0eed81ab47a70fe90abea@postgrespro.ru>
 <CAAJ_b97etWoGCxOGrtZSZ4sZAh-7NjZvLQbmnqi0ka3Lg2=mQA@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <6c9ec3889fb13b7ffcd9e1dc3e1f1e08@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/6c9ec3889fb13b7ffcd9e1dc3e1f1e08%40postgrespro.ru>
Precedence: bulk

After analyzing this, I found out why we don't reach that Assert but we 
have coverage shown - firstly, it reached via another test, vacuum; 
secondly, it depends on the gcc optimization flag. We reach that Assert 
only when using -O0.
If we build with -O2 or -Og that function is not reached (due to 
different results of the heap_prune_satisfies_vacuum() check inside 
heap_page_prune()).
But as  the make checks mostly (including the buildfarm testing) 
performed  with -O2/-Og, it looks like that after 4fb5c794e5 we have 
lost the coverage provided by the 4c51a2d1e4.

Amul Sul писал 2022-09-14 14:28:
> On Wed, Sep 14, 2022 at 12:16 PM <a.kozhemyakin@postgrespro.ru> wrote:
>> 
>> I still wonder, if assert doesn't catch why that place is marked as
>> covered here?
>> https://coverage.postgresql.org/src/backend/access/gin/ginvacuum.c.gcov.html
>> 
> 
> Probably other tests cover that.
> 
> Regards,
> Amul