Feedback-ID: i0c21471d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-522-ga39cca1d5-fm-20240610.002-ga39cca1d
MIME-Version: 1.0
Message-Id: <6cc75dab-07bd-44bd-94a0-fe49ae550f34@app.fastmail.com>
In-Reply-To: <3c024250-3f13-4f4d-b8e9-55f176db4abf@eisentraut.org>
References: <9a9c7e65-c47b-4400-a63e-ac6169c0860e@app.fastmail.com>
 <CALj2ACV85cn-cTNCTP=bPehYo9d2ddvZtfGhGq==0K+65SvufQ@mail.gmail.com>
 <65b841a8-0c2f-4953-b9cd-240fce84b90b@eisentraut.org>
 <TYCPR01MB12077907C052EC329C45AE198F5362@TYCPR01MB12077.jpnprd01.prod.outlook.com>
 <c8e92bcb-69c3-477e-93d4-6f39e030cab0@app.fastmail.com>
 <47524383-6fd1-4b13-8c4e-fb918b1d35ba@enterprisedb.com>
 <bbbeed26-41f9-468c-ac24-ad99f429ccd7@app.fastmail.com>
 <CAA4eK1KPoLUUGzjw9eEQd56LUAf2QQj8BqMcsoSe6vycB5CYUQ@mail.gmail.com>
 <2e86cf53-c806-49d2-9a10-1a1257776d1f@app.fastmail.com>
 <CAA4eK1JJq_ER6Kq_H=jKHR75QPRd8y9_D=RtYw=aPYKMfqLi9A@mail.gmail.com>
 <CAA4eK1KdCb+5sjYu6qCMXXdCX1y_ihr8kFzMozq0=P=auYxgog@mail.gmail.com>
 <CANhcyEV6q1Vhd37i1axUeScLi0UAGVxta1LDa0BV0Eh--TcPMg@mail.gmail.com>
 <CAA4eK1JaQcAZ=n513-4VDW4ujE9T9f007fczNCpVDbg1smhT4g@mail.gmail.com>
 <5da4b286-e570-4341-8262-92d763f6b1a4@app.fastmail.com>
 <776c5cac-5ef5-4001-b1bc-5b698bc0c62a@app.fastmail.com>
 <3c024250-3f13-4f4d-b8e9-55f176db4abf@eisentraut.org>
Date: Tue, 18 Jun 2024 04:23:52 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Peter Eisentraut" <peter@eisentraut.org>,
 "Amit Kapila" <amit.kapila16@gmail.com>,
 "Shlok Kyal" <shlok.kyal.oss@gmail.com>
Cc: "Tomas Vondra" <tomas.vondra@enterprisedb.com>,
 "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>,
 "Bharath Rupireddy" <bharath.rupireddyforpostgres@gmail.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 "Michael Paquier" <michael@paquier.xyz>,
 "Andres Freund" <andres@anarazel.de>,
 "Ashutosh Bapat" <ashutosh.bapat.oss@gmail.com>,
 =?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= <fabriziomello@gmail.com>,
 "vignesh C" <vignesh21@gmail.com>
Subject: Re: speed up a logical replica setup
Content-Type: multipart/mixed;
 boundary=0d675d610d1d4a9ab8b249aab8e8fe72
Archived-At: <https://www.postgresql.org/message-id/6cc75dab-07bd-44bd-94a0-fe49ae550f34%40app.fastmail.com>
Precedence: bulk

--0d675d610d1d4a9ab8b249aab8e8fe72
Content-Type: multipart/alternative;
 boundary=e5998a47d6154a7097582f812db7e260

--e5998a47d6154a7097582f812db7e260
Content-Type: text/plain

On Mon, Jun 17, 2024, at 8:04 AM, Peter Eisentraut wrote:
> On 07.06.24 05:49, Euler Taveira wrote:
> > Here it is a patch series to fix the issues reported in recent 
> > discussions. The
> > patches 0001 and 0003 aim to fix the buildfarm issues. The patch 0002 
> > removes
> > synchronized failover slots on subscriber since it has no use. I also 
> > included
> > an optional patch 0004 that improves the usability by checking both 
> > servers if
> > it already failed in any subscriber check.
> 
> I have committed 0001, 0002, and 0003.  Let's keep an eye on the 
> buildfarm to see if that stabilizes things.  So far it looks good.

Thanks.

> For 0004, I suggest inverting the result values from check_publisher() 
> and create_subscriber() so that it returns true if the check is ok.
> 

Yeah, the order doesn't matter after the commit b963913826. I thought about
changing the order but I didn't; I provided a minimal patch. Since you think
it is an improvement, I'm attaching another patch with this change.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--e5998a47d6154a7097582f812db7e260
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Mon, Jun 17,=
 2024, at 8:04 AM, Peter Eisentraut wrote:<br></div><blockquote type=3D"=
cite" id=3D"qt" style=3D""><div>On 07.06.24 05:49, Euler Taveira wrote:<=
br></div><div>&gt; Here it is a patch series to fix the issues reported =
in recent&nbsp;<br></div><div>&gt; discussions. The<br></div><div>&gt; p=
atches 0001 and 0003 aim to fix the buildfarm issues. The patch 0002&nbs=
p;<br></div><div>&gt; removes<br></div><div>&gt; synchronized failover s=
lots on subscriber since it has no use. I also&nbsp;<br></div><div>&gt; =
included<br></div><div>&gt; an optional patch 0004 that improves the usa=
bility by checking both&nbsp;<br></div><div>&gt; servers if<br></div><di=
v>&gt; it already failed in any subscriber check.<br></div><div><br></di=
v><div>I have committed 0001, 0002, and 0003.&nbsp; Let's keep an eye on=
 the&nbsp;<br></div><div>buildfarm to see if that stabilizes things.&nbs=
p; So far it looks good.<br></div></blockquote><div><br></div><div>Thank=
s.</div><div><br></div><blockquote type=3D"cite" id=3D"qt" style=3D""><d=
iv>For 0004, I suggest inverting the result values from check_publisher(=
)&nbsp;<br></div><div>and create_subscriber() so that it returns true if=
 the check is ok.<br></div><div><br></div></blockquote><div><br></div><d=
iv>Yeah, the order doesn't matter after the commit b963913826. I thought=
 about<br></div><div>changing the order but I didn't; I provided a minim=
al patch. Since you think<br></div><div>it is an improvement, I'm attach=
ing another patch with this change.<br></div><div><br></div><div><br></d=
iv><div id=3D"sig112409080"><div class=3D"signature">--<br></div><div cl=
ass=3D"signature">Euler Taveira<br></div><div class=3D"signature">EDB&nb=
sp;&nbsp; <a href=3D"https://www.enterprisedb.com/">https://www.enterpri=
sedb.com/</a><br></div></div><div><br></div></body></html>
--e5998a47d6154a7097582f812db7e260--

--0d675d610d1d4a9ab8b249aab8e8fe72
Content-Disposition: attachment;
	filename*0="0001-Check-both-servers-before-exiting.patch"
Content-Type: text/x-patch; name="0001-Check-both-servers-before-exiting.patch"
Content-Transfer-Encoding: BASE64

RnJvbSBlYzk2NTg2ZmEzNWJlM2Y4NTVmYjg4NDRhMTk3ZjM3NGFjODJhNjIyIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBFdWxlciBUYXZlaXJhIDxldWxlci50YXZlaXJhQGVu
dGVycHJpc2VkYi5jb20+CkRhdGU6IEZyaSwgMjQgTWF5IDIwMjQgMTQ6Mjk6MDYgLTAzMDAK
U3ViamVjdDogW1BBVENIXSBDaGVjayBib3RoIHNlcnZlcnMgYmVmb3JlIGV4aXRpbmcKClRo
ZSBjdXJyZW50IGNvZGUgcHJvdmlkZXMgbXVsdGlwbGUgZXJyb3JzIGZvciBlYWNoIHNlcnZl
ci4gSWYgYW55CnN1YnNjcmliZXIgY29uZGl0aW9uIGlzIG5vdCBtZXQsIGl0IHRlcm1pbmF0
ZXMgd2l0aG91dCBjaGVja2luZyB0aGUKcHVibGlzaGVyIGNvbmRpdGlvbnMuClRoaXMgY2hh
bmdlIGFsbG93cyBpdCB0byBjaGVjayBib3RoIHNlcnZlcnMgYmVmb3JlIHRlcm1pbmF0aW5n
IGlmIGFueQpjb25kaXRpb24gaXMgbm90IG1ldC4gSXQgc2F2ZXMgYXQgbGVhc3Qgb25lIGRy
eSBydW4gZXhlY3V0aW9uLgoKVGhlIG9yZGVyIGl0IGNhbGxzIHRoZSBjaGVjayBmdW5jdGlv
bnMgZG9uJ3QgbWF0dGVyIGFmdGVyIGNvbW1pdApiOTYzOTEzODI2MjYzMDZjMzAxYjY3Y2Jk
MmQyODMxM2Q5Njc0MWYzIChiZWNhdXNlIHRoZXJlIGlzIG5vCnByaW1hcnlfc2xvdF9uYW1l
IGNoZWNrIGFueW1vcmUpIHNvIGNoZWNrIHRoZSBwdWJsaXNoZXIgZmlyc3QuCi0tLQogc3Jj
L2Jpbi9wZ19iYXNlYmFja3VwL3BnX2NyZWF0ZXN1YnNjcmliZXIuYyB8IDI4ICsrKysrKysr
KysrKy0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDEyIGRl
bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfYmFzZWJhY2t1cC9wZ19jcmVh
dGVzdWJzY3JpYmVyLmMgYi9zcmMvYmluL3BnX2Jhc2ViYWNrdXAvcGdfY3JlYXRlc3Vic2Ny
aWJlci5jCmluZGV4IDU0OTllNmQ5NmEuLjI2YjQwODdmZjcgMTAwNjQ0Ci0tLSBhL3NyYy9i
aW4vcGdfYmFzZWJhY2t1cC9wZ19jcmVhdGVzdWJzY3JpYmVyLmMKKysrIGIvc3JjL2Jpbi9w
Z19iYXNlYmFja3VwL3BnX2NyZWF0ZXN1YnNjcmliZXIuYwpAQCAtNzYsOSArNzYsOSBAQCBz
dGF0aWMgdWludDY0IGdldF9zdGFuZGJ5X3N5c2lkKGNvbnN0IGNoYXIgKmRhdGFkaXIpOwog
c3RhdGljIHZvaWQgbW9kaWZ5X3N1YnNjcmliZXJfc3lzaWQoY29uc3Qgc3RydWN0IENyZWF0
ZVN1YnNjcmliZXJPcHRpb25zICpvcHQpOwogc3RhdGljIGJvb2wgc2VydmVyX2lzX2luX3Jl
Y292ZXJ5KFBHY29ubiAqY29ubik7CiBzdGF0aWMgY2hhciAqZ2VuZXJhdGVfb2JqZWN0X25h
bWUoUEdjb25uICpjb25uKTsKLXN0YXRpYyB2b2lkIGNoZWNrX3B1Ymxpc2hlcihjb25zdCBz
dHJ1Y3QgTG9naWNhbFJlcEluZm8gKmRiaW5mbyk7CitzdGF0aWMgYm9vbCBjaGVja19wdWJs
aXNoZXIoY29uc3Qgc3RydWN0IExvZ2ljYWxSZXBJbmZvICpkYmluZm8pOwogc3RhdGljIGNo
YXIgKnNldHVwX3B1Ymxpc2hlcihzdHJ1Y3QgTG9naWNhbFJlcEluZm8gKmRiaW5mbyk7Ci1z
dGF0aWMgdm9pZCBjaGVja19zdWJzY3JpYmVyKGNvbnN0IHN0cnVjdCBMb2dpY2FsUmVwSW5m
byAqZGJpbmZvKTsKK3N0YXRpYyBib29sIGNoZWNrX3N1YnNjcmliZXIoY29uc3Qgc3RydWN0
IExvZ2ljYWxSZXBJbmZvICpkYmluZm8pOwogc3RhdGljIHZvaWQgc2V0dXBfc3Vic2NyaWJl
cihzdHJ1Y3QgTG9naWNhbFJlcEluZm8gKmRiaW5mbywKIAkJCQkJCQkgY29uc3QgY2hhciAq
Y29uc2lzdGVudF9sc24pOwogc3RhdGljIHZvaWQgc2V0dXBfcmVjb3ZlcnkoY29uc3Qgc3Ry
dWN0IExvZ2ljYWxSZXBJbmZvICpkYmluZm8sIGNvbnN0IGNoYXIgKmRhdGFkaXIsCkBAIC04
MDMsNyArODAzLDcgQEAgc2VydmVyX2lzX2luX3JlY292ZXJ5KFBHY29ubiAqY29ubikKICAq
CiAgKiBYWFggRG9lcyBpdCBub3QgYWxsb3cgYSBzeW5jaHJvbm91cyByZXBsaWNhPwogICov
Ci1zdGF0aWMgdm9pZAorc3RhdGljIGJvb2wKIGNoZWNrX3B1Ymxpc2hlcihjb25zdCBzdHJ1
Y3QgTG9naWNhbFJlcEluZm8gKmRiaW5mbykKIHsKIAlQR2Nvbm4JICAgKmNvbm47CkBAIC05
MDgsOCArOTA4LDcgQEAgY2hlY2tfcHVibGlzaGVyKGNvbnN0IHN0cnVjdCBMb2dpY2FsUmVw
SW5mbyAqZGJpbmZvKQogCiAJcGdfZnJlZSh3YWxfbGV2ZWwpOwogCi0JaWYgKGZhaWxlZCkK
LQkJZXhpdCgxKTsKKwlyZXR1cm4gZmFpbGVkOwogfQogCiAvKgpAQCAtOTIzLDcgKzkyMiw3
IEBAIGNoZWNrX3B1Ymxpc2hlcihjb25zdCBzdHJ1Y3QgTG9naWNhbFJlcEluZm8gKmRiaW5m
bykKICAqIHRoZXJlIGlzIG5vdCBhIHJlbGlhYmxlIHdheSB0byBwcm92aWRlIGEgc3VpdGFi
bGUgZXJyb3Igc2F5aW5nIHRoZSBzZXJ2ZXIgQwogICogd2lsbCBiZSBicm9rZW4gYXQgdGhl
IGVuZCBvZiB0aGlzIHByb2Nlc3MgKGR1ZSB0byBwZ19yZXNldHdhbCkuCiAgKi8KLXN0YXRp
YyB2b2lkCitzdGF0aWMgYm9vbAogY2hlY2tfc3Vic2NyaWJlcihjb25zdCBzdHJ1Y3QgTG9n
aWNhbFJlcEluZm8gKmRiaW5mbykKIHsKIAlQR2Nvbm4JICAgKmNvbm47CkBAIC0xMDE0LDgg
KzEwMTMsNyBAQCBjaGVja19zdWJzY3JpYmVyKGNvbnN0IHN0cnVjdCBMb2dpY2FsUmVwSW5m
byAqZGJpbmZvKQogCQlmYWlsZWQgPSB0cnVlOwogCX0KIAotCWlmIChmYWlsZWQpCi0JCWV4
aXQoMSk7CisJcmV0dXJuIGZhaWxlZDsKIH0KIAogLyoKQEAgLTE3NzEsNiArMTc2OSw5IEBA
IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogCiAJY2hhcgkJcGlkZmlsZVtNQVhQR1BB
VEhdOwogCisJYm9vbAkJcHViX2ZhaWxlZCA9IGZhbHNlOworCWJvb2wJCXN1Yl9mYWlsZWQg
PSBmYWxzZTsKKwogCXBnX2xvZ2dpbmdfaW5pdChhcmd2WzBdKTsKIAlwZ19sb2dnaW5nX3Nl
dF9sZXZlbChQR19MT0dfV0FSTklORyk7CiAJcHJvZ25hbWUgPSBnZXRfcHJvZ25hbWUoYXJn
dlswXSk7CkBAIC0yMDYxLDExICsyMDYyLDE0IEBAIG1haW4oaW50IGFyZ2MsIGNoYXIgKiph
cmd2KQogCXBnX2xvZ19pbmZvKCJzdGFydGluZyB0aGUgc3RhbmRieSB3aXRoIGNvbW1hbmQt
bGluZSBvcHRpb25zIik7CiAJc3RhcnRfc3RhbmRieV9zZXJ2ZXIoJm9wdCwgdHJ1ZSk7CiAK
LQkvKiBDaGVjayBpZiB0aGUgc3RhbmRieSBzZXJ2ZXIgaXMgcmVhZHkgZm9yIGxvZ2ljYWwg
cmVwbGljYXRpb24gKi8KLQljaGVja19zdWJzY3JpYmVyKGRiaW5mbyk7Ci0KIAkvKiBDaGVj
ayBpZiB0aGUgcHJpbWFyeSBzZXJ2ZXIgaXMgcmVhZHkgZm9yIGxvZ2ljYWwgcmVwbGljYXRp
b24gKi8KLQljaGVja19wdWJsaXNoZXIoZGJpbmZvKTsKKwlwdWJfZmFpbGVkID0gY2hlY2tf
cHVibGlzaGVyKGRiaW5mbyk7CisKKwkvKiBDaGVjayBpZiB0aGUgc3RhbmRieSBzZXJ2ZXIg
aXMgcmVhZHkgZm9yIGxvZ2ljYWwgcmVwbGljYXRpb24gKi8KKwlzdWJfZmFpbGVkID0gY2hl
Y2tfc3Vic2NyaWJlcihkYmluZm8pOworCisJaWYgKHB1Yl9mYWlsZWQgfHwgc3ViX2ZhaWxl
ZCkKKwkJZXhpdCgxKTsKIAogCS8qCiAJICogU3RvcCB0aGUgdGFyZ2V0IHNlcnZlci4gVGhl
IHJlY292ZXJ5IHByb2Nlc3MgcmVxdWlyZXMgdGhhdCB0aGUgc2VydmVyCi0tIAoyLjMwLjIK
Cg==

--0d675d610d1d4a9ab8b249aab8e8fe72--