Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kG4iN-0001o6-M7 for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Sep 2020 18:21:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kG4iL-00086C-93 for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Sep 2020 18:21:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kG4iL-000865-1r for pgsql-hackers@lists.postgresql.org; Wed, 09 Sep 2020 18:21:01 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kG4iI-0006Ae-63 for pgsql-hackers@lists.postgresql.org; Wed, 09 Sep 2020 18:20:59 +0000 Received: from hnk.local (p12054-ipngn2901funabasi.chiba.ocn.ne.jp [153.212.171.54]) by oss.nttdata.com (Postfix) with ESMTPSA id 4C3EE601C0; Thu, 10 Sep 2020 03:20:55 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com Subject: Re: Remove line length restriction in passwordFromFile() To: Tom Lane Cc: pgsql-hackers@lists.postgresql.org, Fujii Masao References: <4187382.1598909041@sss.pgh.pa.us> <90aed8c6-a171-4cf7-4e4a-0d4d9593f6c5@oss.nttdata.com> <54742.1598973287@sss.pgh.pa.us> <12eff40e-80df-244e-86b8-c60b0e88bc75@oss.nttdata.com> <41713.1599670097@sss.pgh.pa.us> <42800.1599671793@sss.pgh.pa.us> From: Fujii Masao Message-ID: <6cf14b04-86c6-e34a-4479-062c4bd448e3@oss.nttdata.com> Date: Thu, 10 Sep 2020 03:20:54 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <42800.1599671793@sss.pgh.pa.us> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020/09/10 2:16, Tom Lane wrote: > Fujii Masao writes: >> On 2020/09/10 1:48, Tom Lane wrote: >>> We could adjust the release-note entry for your patch to say >>> "Improve comment detection for .pgpass files", or we could decide >>> it's not worth documenting that part and just drop the entry. > >> "Improve comment detection for .pgpass files" is also the material for >> minor version release because that change was also back-patched? >> If so, I agree to drop the entry. > > Hm, in a quick search I only see 2eb3bc588 which was not back-patched > ... which commits are you thinking of? I thought your commit b55b4dad99 included the improvement on comment detection and was back-patched.... Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION