Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g8P19-00050M-VL for pgsql-hackers@arkaria.postgresql.org; Fri, 05 Oct 2018 12:15:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1g8P16-0004UL-VG for pgsql-hackers@arkaria.postgresql.org; Fri, 05 Oct 2018 12:15:36 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g8P16-0004Tp-KQ for pgsql-hackers@lists.postgresql.org; Fri, 05 Oct 2018 12:15:36 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g8P13-00042Y-WA for pgsql-hackers@postgresql.org; Fri, 05 Oct 2018 12:15:35 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B7DC321EF6; Fri, 5 Oct 2018 08:15:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 05 Oct 2018 08:15:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=E3UF2Q 9FxzSv9VQkWX11AuFfFX5m6ekhtXHliZ3yabY=; b=TqW0nuupjlX5d5DNih394r duhqe3+loKy4ZHfqLGsiZ/K0fQX7r5NyKt1bDFYKe9tmgYkLmh7JBOsK+93CHc8f MoEyCk47nxfO3eSOl2JVh4uU1fE5BzS4XliPP9GP1BiNIMrEb3sJnp8ZwrYesNnM XeRfHq462slcKnGzl15IayiwPjWi4wAI+MQPh/kmy203rCOHlwN7sMPiX3VXYI/Z GA796p35gLXi2lRIy7O/0ACQxct00SdYl/RgCW7yvoIr0r4mS8LS6OOD6jGce/Xv 5vG02rDib6vGFy0HPidMfIlsRK7PwMeSD+PgOIdLbaVRSjauhIAy3Ug/XP1BBvSA == X-ME-Sender: X-ME-Proxy: Received: from april.pezone.net (p5df2a2d9.dip0.t-ipconnect.de [93.242.162.217]) by mail.messagingengine.com (Postfix) with ESMTPA id 2C04E102DE; Fri, 5 Oct 2018 08:15:31 -0400 (EDT) Subject: Re: Procedure calls are not tracked in pg_stat_user_functions / track_functions To: Andres Freund , Lukas Fittl References: <20181004200715.7cgrxyaxnep3mveu@alap3.anarazel.de> Cc: Pg Hackers From: Peter Eisentraut Openpgp: preference=signencrypt Autocrypt: addr=peter.eisentraut@2ndquadrant.com; prefer-encrypt=mutual; keydata= xsFNBFUUt6kBEADZd9NNTBJbHmAXXJgPGOdd6Q73l80oifIVgn2tRxP9dYkCfTlo/yLqbKTl JNqTcyM6XrJDnB2sMEUGYCewYZXl+9C4bBJWyNqcEI1ae9u71vEq/fknFLArJ+2wN+f7QuRx Q8d94ZJAiJQ5g3fNk2HVeedCQCKP5dCzU+ZLt2dbsx1PDZLjTO9gf+JswWuGFb5wY5PZVM5V hq66Xk7ZJzHuARacza2RT7J2fkMmQBY+kr7L98Perb0GhafnlhXB0PvUB+N3xpmggMfwuhTu BngS/G/r3GvemxJuFxouw8xsMqrsfdksJXA2gLXYtwRCssdPV3PO0rlD9twqDo8URfIJ5fb6 1g/MV8aTOKjg3Q8MpJPtkwJqN4o3PvbwYdedeFnOVkkYAJdu/aX1v1BeCBDu7Hy3sF52scD3 pQbyQSl9vUDpTLarASAxNbAV0NRJE8dp4vfW6AH1ccryGiFqw/czPK/iN0+MT8wsjAW6WW4w hvjm5UPA1KTwi3ZT8eT5uycuH7QpuNk7LnGGXQ6KaRALFywzkr0A0V0AvFNa+l4wstMaXaB6 dmMXyF0/hfryqyOeu1gAdq4q0/PNC2dPgb/6uoh4eMjN6A5GXcprilhz5DulmsilY21hfSoU S64ODed96pKhprsOxjZiDRsN1QM5MwB+uwVWUNfsX7fIxE0BrwARAQABzSdQZXRlciBFaXNl bnRyYXV0IDxwZXRlckBlaXNlbnRyYXV0Lm9yZz7CwXoEEwEIACQCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AFAlUUuKQCGQEACgkQoZ8SQ+xBJp8llw//RbGoXnF72FZTlOFsnNyxnWbF vViPCfdAlZl1GGK9OYCvV1dp/956HuhB0wpaGQHiBmQfOPJf/jLOPjXFYm2iEChEycrBChuE j4TSYemMp5BSPILYk9Uwd16kVD/+U6fQfK6H5pOhfBvbM6asMnmpY2wQuvktxHvaGlytFw84 EzFWNZtAZfxkw28w3AhIQkKe9hJanfyDL750RcbyEr8AAHty5IErrvS7tM5vQwIeh5BF26ND CyKPRdZgOgMpcwFfROKBDpAt052CgWIpNdhBdfIKlkCs4/ILxmC3rT/Mb/qZiHcoMMwEu6k+ T7vRAFZZAk62Yrr/U8/vUGKlzRZQoo86fyojCfI0ibCIc0z8rwCVY9P40G9wD9BTCZS/z8Vh jjpBlNnIKw2hM6hbxavKndCJjFFJD08rXrTyrLF/of18xD37vNdYooP9VATB5QjOWFRrscSZ 4a89e+to3m7YVnd4xdXwGp47dYusoax84C8tg1gZrH38ol9dPmnKX6GZrXeS7tH9k8VeUpJ8 HQbRThQRWAT936QpYbLConBmOtmbLmjQOGtiXPo1oK57X/7U/WBja5vWmm2q+Yxtt+3uHGVg DdDU4CJpXo4lX0v2n3QV5EBSW9hjdF3bNfl6GFBb1pPEhqNcMDUc7zkx/2uENdAdk/BnqMgH umip7b0pVfvOwU0EVRS3qQEQAJf6p0P7D+hMYUgCPkvgrcz6OJYsAYdUMUmokfqmkKwK0oJM ew8TNGM53ocKAgQGma5f10rwbZNPlpVPNRX5hwUmwVlcwSut0oE+JfUBH7mpysWvpF05RKIy q9RCoJZrAbXS7Tig56A1QD8IcM00rERZMcCOlI1+q9m4u9AOI+0LyGGSH+VvoyDHD/Jew4R2 TmPEF8Pu7lYiNYK88Q6u0kBkc+Tz3BNlyc6fi3HxnFfp0b75HLXPSTu2SwA/0Q31wHZXwrEU BR9KgSn/qbgy8ydPc97i82fhiFE3cbGexfPrQSMYmDGi+dcQ0s+AMQwC3XyMC0JkHpYUuFkR QdlIvaIhgFUUN2Vr4xF2ADaNTNFc4DYaiPHFAgHZw+3pZWqS4uIiWgJynrEaHw4F3QWU8/JB iyEWDhNq4WBrRA0u914TCCAoFOOKMnRdl8eJrRQKM/5/lXbHFjjlI/LDKhLRFsuQsnJJ3331 RjCzpHPZG5/p5KR1RHiAXa0p/DW5lXyq21hS3kjDlleoHqOxCN/cy0Jgz7qLDq1vZoCl67Sy RAH60c2Xu4may9SVltmot0OzWVHdrfS+85FQGp9580DaeLio7YMFKy2bfEvwQJ/c9xD2QPB+ oSb3V8ueSznXBG5+dyfOsZFRPxceA0wA2rSWZSjxLdKxvyGTj9vsCjaDu13rABEBAAHCwV8E GAEIAAkFAlUUt6kCGwwACgkQoZ8SQ+xBJp+HJhAAxmSTsC5y7p9Zu+nnLpucv/h88oEx985e qWeXzQiwM3pfRZS+PdTH9TyzHK0KOgKoAiubk0vt+BrT91D9d0G5kVQaTctAErGBoMkTaZJT XVEcNphiPzysdSqvprjojMp1y7rG8AP+Xd6m0rE1LRnkRRm8HyI8vdXsuLQPITGWXDLMjaNq AOV3BUnzkgtjMuIYw7SCr+12ZOb5dEKvaG4kjC4kaJ/TLbuBhVANcXkC90yp0AOZLs/cB1Dj OAXno/RUUruJ3r27a+pFv768UAi9QWcdw58yPxreMNMLqAgsS9oTHwHfGNWcB2dJ4UW+GMLJ hTf9TjQ2f+N/sIx5XMQ9pYw6CAJMK29qPx6/ZayrPxf22EXf0D3zTwIEZgwfSkynFVwV25L7 awQq60fifdMYheSxq7GbhpsixmcD+e161cCmLIt75YDt5bQ0B1yf7EmxG8n7pGZAOM6LoNsU fkSldba5XVwh8LuN5mK0nQBELGW6Os4TDq4REggLpfcvFC215zpuo0iCGnmE/Bns4nowqUSP u4tkWL+nxW4qgv8wo8HJ52jd79EJ8iqfIBoidBfy9AIUiEUApGQzWPu6yWcI8fY0rN5D+tc+ Yw1Zt6Mm+huYJpgCRsTcfzEcahnBn521CWcWvhW1ff3KFileFMtNmnBBhMncmRKHphtTKEpN 3jI= Organization: 2ndQuadrant Message-ID: <6d01afee-2a3b-2871-ef41-d3fcd984b192@2ndquadrant.com> Date: Fri, 5 Oct 2018 14:15:30 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181004200715.7cgrxyaxnep3mveu@alap3.anarazel.de> Content-Type: multipart/mixed; boundary="------------BAA4AE9838B8AA6E9FC97D4D" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------BAA4AE9838B8AA6E9FC97D4D Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 04/10/2018 22:07, Andres Freund wrote: > On 2018-10-04 12:15:28 -0700, Lukas Fittl wrote: >> Was this intentional, or an oversight? >> >> If welcome, I would be happy to work on a patch. Whilst slightly confusing >> in terms of naming, we could just track this together with functions, since >> one can always join with pg_proc to determine whether something is a >> function or a procedure. > > Yea, that sounds wrong / not ideal to me. I think we should just fix > this, should be easy enough. Here is a patch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --------------BAA4AE9838B8AA6E9FC97D4D Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-Track-procedure-calls-in-pg_stat_user_functions.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Track-procedure-calls-in-pg_stat_user_functions.patch" RnJvbSA0ZjllODhlNjhlZjViMjlkOTE4MzBiMzMzMDY3NTJkYmExZDI1ZTBhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlcl9lQGdteC5u ZXQ+CkRhdGU6IEZyaSwgNSBPY3QgMjAxOCAxNDoxNDowMyArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIFRyYWNrIHByb2NlZHVyZSBjYWxscyBpbiBwZ19zdGF0X3VzZXJfZnVuY3Rpb25zCgot LS0KIHNyYy9iYWNrZW5kL2NvbW1hbmRzL2Z1bmN0aW9uY21kcy5jIHwgNCArKysrCiAxIGZp bGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQv Y29tbWFuZHMvZnVuY3Rpb25jbWRzLmMgYi9zcmMvYmFja2VuZC9jb21tYW5kcy9mdW5jdGlv bmNtZHMuYwppbmRleCA2ODEwOWJmZGEwLi44MGFkM2M3NzBhIDEwMDY0NAotLS0gYS9zcmMv YmFja2VuZC9jb21tYW5kcy9mdW5jdGlvbmNtZHMuYworKysgYi9zcmMvYmFja2VuZC9jb21t YW5kcy9mdW5jdGlvbmNtZHMuYwpAQCAtNjAsNiArNjAsNyBAQAogI2luY2x1ZGUgInBhcnNl ci9wYXJzZV9leHByLmgiCiAjaW5jbHVkZSAicGFyc2VyL3BhcnNlX2Z1bmMuaCIKICNpbmNs dWRlICJwYXJzZXIvcGFyc2VfdHlwZS5oIgorI2luY2x1ZGUgInBnc3RhdC5oIgogI2luY2x1 ZGUgInV0aWxzL2FjbC5oIgogI2luY2x1ZGUgInV0aWxzL2J1aWx0aW5zLmgiCiAjaW5jbHVk ZSAidXRpbHMvZm1ncm9pZHMuaCIKQEAgLTIyMTksNiArMjIyMCw3IEBAIEV4ZWN1dGVDYWxs U3RtdChDYWxsU3RtdCAqc3RtdCwgUGFyYW1MaXN0SW5mbyBwYXJhbXMsIGJvb2wgYXRvbWlj LCBEZXN0UmVjZWl2ZXIKIAlFU3RhdGUJICAgKmVzdGF0ZTsKIAlFeHByQ29udGV4dCAqZWNv bnRleHQ7CiAJSGVhcFR1cGxlCXRwOworCVBnU3RhdF9GdW5jdGlvbkNhbGxVc2FnZSBmY3Vz YWdlOwogCURhdHVtCQlyZXR2YWw7CiAKIAlmZXhwciA9IHN0bXQtPmZ1bmNleHByOwpAQCAt MjMwMiw3ICsyMzA0LDkgQEAgRXhlY3V0ZUNhbGxTdG10KENhbGxTdG10ICpzdG10LCBQYXJh bUxpc3RJbmZvIHBhcmFtcywgYm9vbCBhdG9taWMsIERlc3RSZWNlaXZlcgogCQlpKys7CiAJ fQogCisJcGdzdGF0X2luaXRfZnVuY3Rpb25fdXNhZ2UoJmZjaW5mbywgJmZjdXNhZ2UpOwog CXJldHZhbCA9IEZ1bmN0aW9uQ2FsbEludm9rZSgmZmNpbmZvKTsKKwlwZ3N0YXRfZW5kX2Z1 bmN0aW9uX3VzYWdlKCZmY3VzYWdlLCB0cnVlKTsKIAogCWlmIChmZXhwci0+ZnVuY3Jlc3Vs dHR5cGUgPT0gVk9JRE9JRCkKIAl7CgpiYXNlLWNvbW1pdDogZmYzNDdmOGFmZjA0ODY1Njgw YzE5ZmZjODE4NDYwYmIyYWZhYWQ1YgotLSAKMi4xOS4wCgo= --------------BAA4AE9838B8AA6E9FC97D4D--