Reply-To: jesper.pedersen@redhat.com
Subject: Re: [HACKERS] Proposal: Local indexes for partitioned table
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Robert Haas <robertmhaas@gmail.com>,
 David Rowley <david.rowley@2ndquadrant.com>,
 Simon Riggs <simon@2ndquadrant.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>,
 Maksim Milyutin <milyutinma@gmail.com>
References: <20171222151023.ie4zrbgwtva7flij@alvherre.pgsql>
From: Jesper Pedersen <jesper.pedersen@redhat.com>
Organization: Red Hat
Message-ID: <6d0e39e9-58c8-3333-5ed5-7b0b45405e71@redhat.com>
Date: Tue, 2 Jan 2018 10:44:20 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171222151023.ie4zrbgwtva7flij@alvherre.pgsql>
Content-Type: multipart/mixed;
 boundary="------------66D6CB918D861C9B11929B09"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------66D6CB918D861C9B11929B09
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

Hi Alvaro,

On 12/22/2017 10:10 AM, Alvaro Herrera wrote:
> I believe these are all fixed by the attached delta patch.
>

Thanks.

> If you have wording suggestions for the doc changes, please send them
> along.
> 

Maybe we should make the default index name more explicit under the 
'name' parameter as attached.

Best regards,
  Jesper

--------------66D6CB918D861C9B11929B09
Content-Type: text/x-patch;
 name="doc-changes.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="doc-changes.patch"

diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_index.sgml
index 5137fe6383..7d32c5556d 100644
--- a/doc/src/sgml/ref/create_index.sgml
+++ b/doc/src/sgml/ref/create_index.sgml
@@ -146,7 +146,11 @@ CREATE [ UNIQUE ] INDEX [ CONCURRENTLY ] [ [ IF NOT EXISTS ] <replaceable class=
         here; the index is always created in the same schema as its parent
         table.  If the name is omitted, <productname>PostgreSQL</productname> chooses a
         suitable name based on the parent table's name and the indexed column
-        name(s).
+        name(s) using the following formular <literal>{tablename}_{columnname(s)}_{suffix}</literal>
+        where <literal>{suffix}</literal> is <literal>pkey</literal> for a primary key constraint,
+        <literal>key</literal> for a unique constraint, <literal>excl</literal> for an exclusion constraint,
+        <literal>idx</literal> or any other kind of index, <literal>fkey</literal> for a foreign key and
+        <literal>check</literal> for a check constraint.
        </para>
       </listitem>
      </varlistentry>

--------------66D6CB918D861C9B11929B09--