Message-ID: <6db86e0b-697a-4e4b-860a-7ad9736a8e81@postgresfriends.org>
Date: Sat, 27 Sep 2025 20:14:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] GROUP BY ALL
To: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter@eisentraut.org>
Cc: David Christensen <david@pgguru.net>,
 Andrey Borodin <x4mmm@yandex-team.ru>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 "David G. Johnston" <david.g.johnston@gmail.com>,
 Jelte Fennema-Nio <postgres@jeltef.nl>
References: <4D2047B0-E8D8-472B-B7E8-61206B1E6AFA@yandex-team.ru>
 <F694DABC-6A42-4614-B254-643180B9D6F6@pgguru.net>
 <CAHM0NXj1Gv_96WxZkiLKhxJVaYOGcmdZ2hApNcvWQ5HxV84Q=A@mail.gmail.com>
 <4083063.1758902694@sss.pgh.pa.us>
 <CAHM0NXgPhe_OF81MyA9ocWZ=b+oEAHtQHoDXw4DverPdbkXzpg@mail.gmail.com>
 <4085064.1758903815@sss.pgh.pa.us>
 <cf397a8c-49cf-4839-9a3f-992ea49feb12@eisentraut.org>
 <167505.1758988990@sss.pgh.pa.us>
Content-Language: en-US
From: Vik Fearing <vik@postgresfriends.org>
In-Reply-To: <167505.1758988990@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/6db86e0b-697a-4e4b-860a-7ad9736a8e81%40postgresfriends.org>
Precedence: bulk


On 27/09/2025 18:03, Tom Lane wrote:
> So according to the standard, this:
>
> 	select a+b, count(*) from ... group by all;
>
> would be invalid because a+b couldn't be written directly in
> GROUP BY?


Correct.


> I can't see us rejecting that though, since we do
> allow a+b in GROUP BY.


No, nor do I.  Also, there were rumors about adding expressions to group 
by in the standard but no formal proposal yet.


FWIW, I opposed adding this GROUP BY ALL feature, but I was 
outnumbered.  I hope to never see it in production.

-- 

Vik Fearing