Message-ID: <6dc1587f-2ca6-4dd6-b389-94a05912fda5@gmail.com>
Date: Tue, 29 Aug 2023 08:17:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Autogenerate some wait events code and documentation
To: Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
References: <ZKo4b1bDI5+FoTex@paquier.xyz>
 <1f74adab-5ed8-450a-853a-f0b4bfe0e751@gmail.com>
 <ZKpjawSAHIjYV2+Q@paquier.xyz>
 <9682e829-4120-a3d5-4834-d909ad4b49d8@gmail.com>
 <ZKuVKPB+rwYH5cuw@paquier.xyz>
 <e318fee2-ab72-9d71-6b8b-c99753f4cecc@gmail.com>
 <ZK9S3jFEV1X797Ll@paquier.xyz> <ZLDT0kOh0tuh6IpV@paquier.xyz>
 <20230716192120.t53prl2uruingo6z@awork3.anarazel.de>
 <ZLSWUh3dpZPlvrso@paquier.xyz> <ZOxVHQwEC/9X/p/z@paquier.xyz>
Content-Language: en-US
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <ZOxVHQwEC/9X/p/z@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/6dc1587f-2ca6-4dd6-b389-94a05912fda5%40gmail.com>
Precedence: bulk

Hi,

On 8/28/23 10:04 AM, Michael Paquier wrote:
> On Mon, Jul 17, 2023 at 10:16:02AM +0900, Michael Paquier wrote:
>> So you mean to switch a line that now looks like that:
>> WAIT_EVENT_FOO_BAR   FooBar        "Waiting on Foo Bar."
>> To that:
>> FOO_BAR   "Waiting on Foo Bar."
>> Or even that:
>> WAIT_EVENT_FOO_BAR   "Waiting on Foo Bar."
>>
>> Sure, it is an improvement for any wait events that use WAIT_EVENT_
>> when searching them, but this adds more magic into the LWLock and Lock
>> areas if the same conversion is applied there.  Or am I right to
>> assume that you'd mean to *not* do any of that for these two classes?
>> These can be treated as exceptions in the script when generating the
>> wait event names from the enum elements, of course.
> 
> I have looked again at that, and switching wait_event_names.txt to use
> two columns made of the typedef definitions and the docs like is not a
> problem:
> FOO_BAR   "Waiting on Foo Bar."
> 
> WAIT_EVENT_ is appended to the typedef definitions in the script.  The
> wait event names like "FooBar" are generated from the enums by
> splitting using their underscores and doing some lc().  Lock and
> LWLock don't need to change.  This way, it is easy to grep the wait
> events from the source code and match them with wait_event_names.txt.
> 
> Thoughts or comments?

Agree that done that way one could easily grep the events from the source code and
match them with wait_event_names.txt. Then I don't think the "search" issue in the code
is still a concern with the current proposal.

FWIW, I'm getting:

$ git am v3-000*
Applying: Rename wait events with more consistent camelcase style
Applying: Remove column for wait event names in wait_event_names.txt
error: patch failed: src/backend/utils/activity/wait_event_names.txt:261
error: src/backend/utils/activity/wait_event_names.txt: patch does not apply
Patch failed at 0002 Remove column for wait event names in wait_event_names.txt

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com