Feedback-ID: ie0a040ee:Fastmail
Message-ID: <6dd0f118-ce86-4b98-af2c-1319e1593a15@eisentraut.org>
Date: Wed, 25 Sep 2024 16:04:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add contrib/pg_logicalsnapinspect
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 Peter Smith <smithpb2250@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>,
 Amit Kapila <amit.kapila16@gmail.com>,
 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: <ZuF2Okt7aBR//bxu@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAJpy0uCgAQ5JeunSV2cXiLSegxKK5=DzRZOnJLcbyS82pwZjeg@mail.gmail.com>
 <ZuhBsL/GuMWF2RoW@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAJpy0uCzAY3r42vB3nUa+HongRrFmfNQan1Y2Bs6XQEfuDSo2A@mail.gmail.com>
 <ZuksXCkdmueSnVyq@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAHut+PuWLzfXO0ZDNEHhgz013OR-w8U_C+F+gpP+hu7eivGDPA@mail.gmail.com>
 <ZusgK0/B8F/1rqft@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAHut+PuqW+Xz_m5oYYNfBk5DjKJRS6t=5pnNKZnP21geBPMR_Q@mail.gmail.com>
 <Zu0bod6+zj0v+7wd@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAHut+PsVj9+DO6_zQrW8-n47DxuxFzwHKXOJi6AE3M9Yki9XPA@mail.gmail.com>
 <ZvLuDfEUow6gw2Hr@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <ZvLuDfEUow6gw2Hr@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/6dd0f118-ce86-4b98-af2c-1319e1593a15%40eisentraut.org>
Precedence: bulk

Is there a reason for this elaborate error handling:

+	fd = OpenTransientFile(path, O_RDONLY | PG_BINARY);
+
+	if (fd < 0 && errno == ENOENT)
+		ereport(ERROR,
+				errmsg("file \"%s\" does not exist", path));
+	else if (fd < 0)
+		ereport(ERROR,
+				(errcode_for_file_access(),
+				 errmsg("could not open file \"%s\": %m", path)));

Couldn't you just use the second branch for all errno's?