Content-Type: multipart/alternative;
 boundary="------------d7fRRZBKs3fs1TZHCm0bCtdS"
Message-ID: <6e049195-7bf4-4f5f-932d-51f1251b2d92@dunslane.net>
Date: Thu, 18 Jun 2026 09:43:09 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Non-text mode for pg_dumpall
To: Noah Misch <noah@leadboat.com>
Cc: jian he <jian.universality@gmail.com>,
 Mahendra Singh Thalor <mahi6run@gmail.com>,
 tushar <tushar.ahuja@enterprisedb.com>,
 Vaibhav Dalvi <vaibhav.dalvi@enterprisedb.com>,
 pgsql-hackers@lists.postgresql.org
References: 
 <CACJufxFs9NXXTeb78i2MD+pnZootayAtiGcNHNeU35SmQgMjbA@mail.gmail.com>
 <59d3616f-6d6d-40d5-87e2-e019e350b52d@dunslane.net>
 <CACJufxEnmJ8otfmN7Kp110Wqi=M4YE0-zn-W6SK+eTpWuZw_fg@mail.gmail.com>
 <CAKYtNAqxjQMLVPfz6XESqszhxZKgigi7UEBzBhz_Wj_Bnasdag@mail.gmail.com>
 <7faf3a59-cfe1-45cb-a972-55e05560b414@dunslane.net>
 <CACJufxE-zJiBAaZABtJBJr8FZdj=xP5adf_excmu9S6Op=KpLA@mail.gmail.com>
 <2e7ada75-422c-4153-9437-ea0ce8d63521@dunslane.net>
 <84764ef6-2bcb-43f7-9037-d7b589857da9@dunslane.net>
 <20260607000218.96.noahmisch@microsoft.com>
 <cfc6ae07-a161-4ada-bf8c-57eed960e5ff@dunslane.net>
 <20260617215952.1f.noahmisch@microsoft.com>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAlwQTAQgAQQIbAwIX
 gAIZAQULCQgHAwUVCgkICwUWAgMBAAIeBRYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNGd
 BQkdEO8nAAoJEJn6f8tZ/DuBq74H/jkTR4Zi3stbw+xC7v2u3QozssK7MYPL2AsVfh7OealS
 h182fiWXpfvmmAB7WUHbhk9GC2RAOnHI/2d2jgKaMLAHsGYOT0YopTVIwRY43fCw/mK67yxc
 wmDcX+zyKfLaivNbf5A7QPLNwda98bEAMSJ8Sn652Uc6cA8t3uKGsVzbRBQOoYzjgvBCfSrE
 9ql3PDNg0l4BfAqabd2f70ZUm9VAMEPrgv/v2xI7M2XiL4g5BVmqLCOwxLM8RMCotCuoweUr
 VO43DeBCIDwLxotMJKvGWDjBzQYlU1NPUAtNcz/gN9ITUe1VUGjyvGj4u1lxBOcQQUw7l1+T
 5moZ4iZxXzvOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oKWaqf+wmW4tpDe/VV
 cxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7llV0xSSoFiieQBsr
 GvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8BoVrRFcdzlIY/NFN
 hFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C4R+M6w7o2PLGOjdZ
 +kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaYL++LAEOqrlvm2Tvq
 QqZRtnEAEQEAAcLAfAQYAQgAJgIbDBYhBOQ+WEYd/Hy/RGkVpZn6f8tZ/DuBBQJoGNI2BQkd
 EODdAAoJEJn6f8tZ/DuBfw0IAKTsfD40teP/pp+bsLLMSxPXUYrrprTj7WFB5v61p6dkpSr/
 qXmMlyahdxQFaPmfVgVirB1Vk/kHiWNnnGjfUV9nB2Zg9LI0Xb9/ts3LsUiRWXzG3tkMY6XL
 vsVOxW4XFRND9l2q+WW93aZ1DZl+fqWfYgMvsusFRhmGFOKTRfKPta2Pkv+AhA24N4+PrR5p
 bU4k2MO8PAGiK8eaYKGFG1bHKuAvoDoF7WXJ3FHxuWqLnKEt4dfOLm5pAe3zq1Lt6q8azT9i
 QWGpSAK5vQUWQHBHpiDjdPeqKZ6HiAXIIKfSmb+jrvXBqoP+D6/K7rUjG2aXiRtTIAXms9sm
 VRu7cmw=
In-Reply-To: <20260617215952.1f.noahmisch@microsoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/6e049195-7bf4-4f5f-932d-51f1251b2d92%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------d7fRRZBKs3fs1TZHCm0bCtdS
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2026-06-17 We 5:59 PM, Noah Misch wrote:
> On Mon, Jun 15, 2026 at 04:11:16PM -0400, Andrew Dunstan wrote:
>> On 2026-06-06 Sa 8:02 PM, Noah Misch wrote:
>>> On Thu, Feb 26, 2026 at 09:02:48AM -0500, Andrew Dunstan wrote:
>>>> pushed with a slight tweak.
>>> Having now reviewed commit 763aaa0, I don't think it's ready to remain part of
>>> v19.  While some points from my v18 review are now resolved, other points
>>> still seem unresolved.  I didn't find discussion of the unresolved points.  I
>>> also see new issues.
>> OK, here's a reversion path. It's a bit messy, and I didn't touch the
>> release notes, but apart from that I think it does the right thing.
> I checked "git diff 763aaa06f03^ src/bin/pg_dump/{*.c,*.h,t}" and I agree this
> reverts everything.  Thanks for working through the revert.


Thanks for checking. Pushed with the release notes update.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------d7fRRZBKs3fs1TZHCm0bCtdS
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2026-06-17 We 5:59 PM, Noah Misch
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:20260617215952.1f.noahmisch@microsoft.com">
      <pre wrap="" class="moz-quote-pre">On Mon, Jun 15, 2026 at 04:11:16PM -0400, Andrew Dunstan wrote:
</pre>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">On 2026-06-06 Sa 8:02 PM, Noah Misch wrote:
</pre>
        <blockquote type="cite">
          <pre wrap="" class="moz-quote-pre">On Thu, Feb 26, 2026 at 09:02:48AM -0500, Andrew Dunstan wrote:
</pre>
          <blockquote type="cite">
            <pre wrap="" class="moz-quote-pre">pushed with a slight tweak.
</pre>
          </blockquote>
          <pre wrap="" class="moz-quote-pre">Having now reviewed commit 763aaa0, I don't think it's ready to remain part of
v19.  While some points from my v18 review are now resolved, other points
still seem unresolved.  I didn't find discussion of the unresolved points.  I
also see new issues.
</pre>
        </blockquote>
        <pre wrap="" class="moz-quote-pre">
OK, here's a reversion path. It's a bit messy, and I didn't touch the
release notes, but apart from that I think it does the right thing.
</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">
I checked "git diff 763aaa06f03^ src/bin/pg_dump/{*.c,*.h,t}" and I agree this
reverts everything.  Thanks for working through the revert.</pre>
    </blockquote>
    <p><br>
    </p>
    <p><span style="white-space: pre-wrap">Thanks for checking. Pushed with the release notes update.</span></p>
    <p><span style="white-space: pre-wrap">
</span></p>
    <p><span style="white-space: pre-wrap">cheers</span></p>
    <p><span style="white-space: pre-wrap">
</span></p>
    <p><span style="white-space: pre-wrap">andrew</span></p>
    <p><span style="white-space: pre-wrap">
</span></p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------d7fRRZBKs3fs1TZHCm0bCtdS--