Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pghyC-00035X-20 for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Mar 2023 08:12:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pghyA-0003DN-Pb for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Mar 2023 08:12:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pghyA-0003DB-Cs for pgsql-hackers@lists.postgresql.org; Mon, 27 Mar 2023 08:12:46 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pghy3-00086I-G3 for pgsql-hackers@lists.postgresql.org; Mon, 27 Mar 2023 08:12:46 +0000 Received: by mail-wm1-x332.google.com with SMTP id q7-20020a05600c46c700b003ef6e809574so1286660wmo.4 for ; Mon, 27 Mar 2023 01:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679904758; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=eWLfhhJ/iphoD2+mkFamZb+z+rnOnCVrlIGWufrzFIQ=; b=ZVwPYPGh2mZ43WYioBsHlUj3rcFrZ0QDojvMzNs6NMqDUPvsNwpY6htb+PpzIgnlOe Q5fYEc5G/MspNy8QfFdESwBUF70yTUcumQwgizcNHFueN9oRPt+Hy+3mdk5PlZjqZa0U sQbURmu6msCJiRWQa8AjdZ2LyN+JS3fFmR3n2NfsFoJ9KotJ/ntIU5+5ctx5z9uQgZDM tpf9vb+FjPihH/cODKtLLXP3z0J8huJu+XEBB7U5LFf6JEIBh/bwSMyUM/atT0jNXThP OgPW5Ultg5Ao4ntwvuUCqVTvPncXxImV1B5AzJqatZfyQMg5Zedb++ca7vcruyof+CV0 PSoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679904758; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=eWLfhhJ/iphoD2+mkFamZb+z+rnOnCVrlIGWufrzFIQ=; b=Hkce6+AiPanYcIiZL4rNERAvJzYHFl20nzjw4M0t1oRUWnCnmssMUogO0PZN1chh09 NakCsKnTUljD1/qOt1hP/PYTYGX3xmy9EU3FmmQNk4MWqPGO9AF9tras/wPic9bafV10 2bhLjgg5/73Ugb5oEh+8eKzrLo27BK4fAYWHINphht1N1HxcZkhzJw8B5okytJ95IUo0 tDSrPRUBuqobrnwkBhjbHUedPkT4WJ+Va20sDOiYRru8dXXTbGlZkGNiOiYKSp17ExrS PuYcAljTgmOML1AsN4TriU/jWMyRTDagUGyd6mbqwViMenSAIPM1NtJOlFEIBrAMYgeu oaWA== X-Gm-Message-State: AO0yUKWADrAB42pVx8s1JV9WkLtCSm3GwexMIzW+5oVcqYKSHZo+7syy ygZSzL6q/tcLmOthpA9OfmA= X-Google-Smtp-Source: AK7set/l1aeVgLxLWxOGyyIGZ/8Yql/S3OQV3q0IDlSnGdnI37PQKSLNMPFUGjqogc2cZS7O7A9R2g== X-Received: by 2002:a7b:c8d0:0:b0:3eb:39e7:35fe with SMTP id f16-20020a7bc8d0000000b003eb39e735femr8312186wml.30.1679904758494; Mon, 27 Mar 2023 01:12:38 -0700 (PDT) Received: from [192.168.5.158] ([54.239.6.184]) by smtp.gmail.com with ESMTPSA id g19-20020a05600c311300b003ee74c25f12sm7907167wmo.35.2023.03.27.01.12.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 01:12:37 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------2wqaAcOEvM2Ned0CRUIjFxj0" Message-ID: <6e2efb4f-6fd0-807e-f6bf-94207db8183a@gmail.com> Date: Mon, 27 Mar 2023 10:11:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: Generate pg_stat_get_xact*() functions with Macros Content-Language: en-US To: Michael Paquier Cc: "Gregory Stark (as CFM)" , Andres Freund , Michael Paquier , PostgreSQL Hackers References: <20230113183746.zyncqr2zz3gk6yh6@awork3.anarazel.de> <11744b0e-5f7f-aba8-7d9c-2ff0a0c6e2b2@gmail.com> <631e3084-c5d9-8463-7540-fcff4674caa5@gmail.com> <442ba19a-6e8a-3fe3-d404-e9101dfbfcbb@gmail.com> From: "Drouvot, Bertrand" In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------2wqaAcOEvM2Ned0CRUIjFxj0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/27/23 9:23 AM, Michael Paquier wrote: > On Mon, Mar 27, 2023 at 08:54:13AM +0200, Drouvot, Bertrand wrote: >> Yes, something like V1 up-thread was doing. I think it can be added with your current proposal. > > Sure, I can write that. Or perhaps you'd prefer write something > yourself? Please find attached V2 adding pg_stat_get_xact_function_total_time() and pg_stat_get_xact_function_self_time() to the party. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com --------------2wqaAcOEvM2Ned0CRUIjFxj0 Content-Type: text/plain; charset=UTF-8; name="v2-0001-pgstatfuncs-more-macros.patch" Content-Disposition: attachment; filename="v2-0001-pgstatfuncs-more-macros.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5jcy5jIGIvc3Jj L2JhY2tlbmQvdXRpbHMvYWR0L3Bnc3RhdGZ1bmNzLmMKaW5kZXggZTFkZDFlMGFkMy4uZDBi ZjYxY2M2NCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3Bnc3RhdGZ1bmNz LmMKKysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3Bnc3RhdGZ1bmNzLmMKQEAgLTE1Miwy OSArMTUyLDI2IEBAIHBnX3N0YXRfZ2V0X2Z1bmN0aW9uX2NhbGxzKFBHX0ZVTkNUSU9OX0FS R1MpCiAJUEdfUkVUVVJOX0lOVDY0KGZ1bmNlbnRyeS0+bnVtY2FsbHMpOwogfQogCi1EYXR1 bQotcGdfc3RhdF9nZXRfZnVuY3Rpb25fdG90YWxfdGltZShQR19GVU5DVElPTl9BUkdTKQot ewotCU9pZAkJCWZ1bmNpZCA9IFBHX0dFVEFSR19PSUQoMCk7Ci0JUGdTdGF0X1N0YXRGdW5j RW50cnkgKmZ1bmNlbnRyeTsKLQotCWlmICgoZnVuY2VudHJ5ID0gcGdzdGF0X2ZldGNoX3N0 YXRfZnVuY2VudHJ5KGZ1bmNpZCkpID09IE5VTEwpCi0JCVBHX1JFVFVSTl9OVUxMKCk7Ci0J LyogY29udmVydCBjb3VudGVyIGZyb20gbWljcm9zZWMgdG8gbWlsbGlzZWMgZm9yIGRpc3Bs YXkgKi8KLQlQR19SRVRVUk5fRkxPQVQ4KCgoZG91YmxlKSBmdW5jZW50cnktPnRvdGFsX3Rp bWUpIC8gMTAwMC4wKTsKLX0KLQotRGF0dW0KLXBnX3N0YXRfZ2V0X2Z1bmN0aW9uX3NlbGZf dGltZShQR19GVU5DVElPTl9BUkdTKQotewotCU9pZAkJCWZ1bmNpZCA9IFBHX0dFVEFSR19P SUQoMCk7Ci0JUGdTdGF0X1N0YXRGdW5jRW50cnkgKmZ1bmNlbnRyeTsKLQotCWlmICgoZnVu Y2VudHJ5ID0gcGdzdGF0X2ZldGNoX3N0YXRfZnVuY2VudHJ5KGZ1bmNpZCkpID09IE5VTEwp Ci0JCVBHX1JFVFVSTl9OVUxMKCk7Ci0JLyogY29udmVydCBjb3VudGVyIGZyb20gbWljcm9z ZWMgdG8gbWlsbGlzZWMgZm9yIGRpc3BsYXkgKi8KLQlQR19SRVRVUk5fRkxPQVQ4KCgoZG91 YmxlKSBmdW5jZW50cnktPnNlbGZfdGltZSkgLyAxMDAwLjApOwotfQorLyogY29udmVydCBj b3VudGVyIGZyb20gbWljcm9zZWMgdG8gbWlsbGlzZWMgZm9yIGRpc3BsYXkgKi8KKyNkZWZp bmUgUEdfU1RBVF9HRVRfRlVOQ0VOVFJZX0ZMT0FUOF9NUyhzdGF0KQkJCQkJCVwKK0RhdHVt CQkJCQkJCQkJCQkJCQkJCVwKK0NwcENvbmNhdChwZ19zdGF0X2dldF9mdW5jdGlvbl8sc3Rh dCkoUEdfRlVOQ1RJT05fQVJHUykJCQkJXAorewkJCQkJCQkJCQkJCQkJCQkJXAorCU9pZAkJ CWZ1bmNpZCA9IFBHX0dFVEFSR19PSUQoMCk7CQkJCQkJCVwKKwlkb3VibGUJCXJlc3VsdDsJ CQkJCQkJCQkJCQlcCisJUGdTdGF0X1N0YXRGdW5jRW50cnkgKmZ1bmNlbnRyeTsJCQkJCQkJ CVwKKwkJCQkJCQkJCQkJCQkJCQkJXAorCWlmICgoZnVuY2VudHJ5ID0gcGdzdGF0X2ZldGNo X3N0YXRfZnVuY2VudHJ5KGZ1bmNpZCkpID09IE5VTEwpCVwKKwkJUEdfUkVUVVJOX05VTEwo KTsJCQkJCQkJCQkJCVwKKwlyZXN1bHQgPSAoKGRvdWJsZSkgZnVuY2VudHJ5LT5zdGF0KSAv IDEwMDAuMDsJCQkJCVwKKwlQR19SRVRVUk5fRkxPQVQ4KHJlc3VsdCk7CQkJCQkJCQkJCVwK K30KKworLyogcGdfc3RhdF9nZXRfZnVuY3Rpb25fdG90YWxfdGltZSAqLworUEdfU1RBVF9H RVRfRlVOQ0VOVFJZX0ZMT0FUOF9NUyh0b3RhbF90aW1lKQorCisvKiBwZ19zdGF0X2dldF9m dW5jdGlvbl9zZWxmX3RpbWUgKi8KK1BHX1NUQVRfR0VUX0ZVTkNFTlRSWV9GTE9BVDhfTVMo c2VsZl90aW1lKQogCiBEYXR1bQogcGdfc3RhdF9nZXRfYmFja2VuZF9pZHNldChQR19GVU5D VElPTl9BUkdTKQpAQCAtMTE0Nyw3ICsxMTQ0LDggQEAgcGdfc3RhdF9nZXRfZGJfY2hlY2tz dW1fbGFzdF9mYWlsdXJlKFBHX0ZVTkNUSU9OX0FSR1MpCiAJCVBHX1JFVFVSTl9USU1FU1RB TVBUWihyZXN1bHQpOwogfQogCi0jZGVmaW5lIFBHX1NUQVRfR0VUX0RCRU5UUllfRkxPQVQ4 KHN0YXQpCQkJCQkJXAorLyogY29udmVydCBjb3VudGVyIGZyb20gbWljcm9zZWMgdG8gbWls bGlzZWMgZm9yIGRpc3BsYXkgKi8KKyNkZWZpbmUgUEdfU1RBVF9HRVRfREJFTlRSWV9GTE9B VDhfTVMoc3RhdCkJCQkJCQlcCiBEYXR1bQkJCQkJCQkJCQkJCQkJCVwKIENwcENvbmNhdChw Z19zdGF0X2dldF9kYl8sc3RhdCkoUEdfRlVOQ1RJT05fQVJHUykJCQkJXAogewkJCQkJCQkJ CQkJCQkJCQlcCkBAIC0xMTY0LDE5ICsxMTYyLDE5IEBAIENwcENvbmNhdChwZ19zdGF0X2dl dF9kYl8sc3RhdCkoUEdfRlVOQ1RJT05fQVJHUykJCQkJXAogfQogCiAvKiBwZ19zdGF0X2dl dF9kYl9hY3RpdmVfdGltZSAqLwotUEdfU1RBVF9HRVRfREJFTlRSWV9GTE9BVDgoYWN0aXZl X3RpbWUpCitQR19TVEFUX0dFVF9EQkVOVFJZX0ZMT0FUOF9NUyhhY3RpdmVfdGltZSkKIAog LyogcGdfc3RhdF9nZXRfZGJfYmxrX3JlYWRfdGltZSAqLwotUEdfU1RBVF9HRVRfREJFTlRS WV9GTE9BVDgoYmxrX3JlYWRfdGltZSkKK1BHX1NUQVRfR0VUX0RCRU5UUllfRkxPQVQ4X01T KGJsa19yZWFkX3RpbWUpCiAKIC8qIHBnX3N0YXRfZ2V0X2RiX2Jsa193cml0ZV90aW1lICov Ci1QR19TVEFUX0dFVF9EQkVOVFJZX0ZMT0FUOChibGtfd3JpdGVfdGltZSkKK1BHX1NUQVRf R0VUX0RCRU5UUllfRkxPQVQ4X01TKGJsa193cml0ZV90aW1lKQogCiAvKiBwZ19zdGF0X2dl dF9kYl9pZGxlX2luX3RyYW5zYWN0aW9uX3RpbWUgKi8KLVBHX1NUQVRfR0VUX0RCRU5UUllf RkxPQVQ4KGlkbGVfaW5fdHJhbnNhY3Rpb25fdGltZSkKK1BHX1NUQVRfR0VUX0RCRU5UUllf RkxPQVQ4X01TKGlkbGVfaW5fdHJhbnNhY3Rpb25fdGltZSkKIAogLyogcGdfc3RhdF9nZXRf ZGJfc2Vzc2lvbl90aW1lICovCi1QR19TVEFUX0dFVF9EQkVOVFJZX0ZMT0FUOChzZXNzaW9u X3RpbWUpCitQR19TVEFUX0dFVF9EQkVOVFJZX0ZMT0FUOF9NUyhzZXNzaW9uX3RpbWUpCiAK IERhdHVtCiBwZ19zdGF0X2dldF9iZ3dyaXRlcl90aW1lZF9jaGVja3BvaW50cyhQR19GVU5D VElPTl9BUkdTKQpAQCAtMTYwOSwyOCArMTYwNywyMyBAQCBwZ19zdGF0X2dldF94YWN0X2Z1 bmN0aW9uX2NhbGxzKFBHX0ZVTkNUSU9OX0FSR1MpCiAJUEdfUkVUVVJOX0lOVDY0KGZ1bmNl bnRyeS0+bnVtY2FsbHMpOwogfQogCi1EYXR1bQotcGdfc3RhdF9nZXRfeGFjdF9mdW5jdGlv bl90b3RhbF90aW1lKFBHX0ZVTkNUSU9OX0FSR1MpCi17Ci0JT2lkCQkJZnVuY2lkID0gUEdf R0VUQVJHX09JRCgwKTsKLQlQZ1N0YXRfRnVuY3Rpb25Db3VudHMgKmZ1bmNlbnRyeTsKLQot CWlmICgoZnVuY2VudHJ5ID0gZmluZF9mdW5jc3RhdF9lbnRyeShmdW5jaWQpKSA9PSBOVUxM KQotCQlQR19SRVRVUk5fTlVMTCgpOwotCVBHX1JFVFVSTl9GTE9BVDgoSU5TVFJfVElNRV9H RVRfTUlMTElTRUMoZnVuY2VudHJ5LT50b3RhbF90aW1lKSk7Ci19Ci0KLURhdHVtCi1wZ19z dGF0X2dldF94YWN0X2Z1bmN0aW9uX3NlbGZfdGltZShQR19GVU5DVElPTl9BUkdTKQotewot CU9pZAkJCWZ1bmNpZCA9IFBHX0dFVEFSR19PSUQoMCk7Ci0JUGdTdGF0X0Z1bmN0aW9uQ291 bnRzICpmdW5jZW50cnk7CisjZGVmaW5lIFBHX1NUQVRfR0VUX1hBQ1RfRlVOQ0VOVFJZX0ZM T0FUOF9NUyhzdGF0KQkJCQlcCitEYXR1bQkJCQkJCQkJCQkJCQkJCVwKK0NwcENvbmNhdChw Z19zdGF0X2dldF94YWN0X2Z1bmN0aW9uXyxzdGF0KShQR19GVU5DVElPTl9BUkdTKQlcCit7 CQkJCQkJCQkJCQkJCQkJCVwKKwlPaWQJCQlmdW5jaWQgPSBQR19HRVRBUkdfT0lEKDApOwkJ CQkJCVwKKwlQZ1N0YXRfRnVuY3Rpb25Db3VudHMgKmZ1bmNlbnRyeTsJCQkJCQkJXAorCQkJ CQkJCQkJCQkJCQkJCVwKKwlpZiAoKGZ1bmNlbnRyeSA9IGZpbmRfZnVuY3N0YXRfZW50cnko ZnVuY2lkKSkgPT0gTlVMTCkJCVwKKwkJUEdfUkVUVVJOX05VTEwoKTsJCQkJCQkJCQkJXAor CVBHX1JFVFVSTl9GTE9BVDgoSU5TVFJfVElNRV9HRVRfTUlMTElTRUMoZnVuY2VudHJ5LT5z dGF0KSk7CVwKK30JCQkJCQkJCQkJCQkJCQkJXAogCi0JaWYgKChmdW5jZW50cnkgPSBmaW5k X2Z1bmNzdGF0X2VudHJ5KGZ1bmNpZCkpID09IE5VTEwpCi0JCVBHX1JFVFVSTl9OVUxMKCk7 Ci0JUEdfUkVUVVJOX0ZMT0FUOChJTlNUUl9USU1FX0dFVF9NSUxMSVNFQyhmdW5jZW50cnkt PnNlbGZfdGltZSkpOwotfQorLyogcGdfc3RhdF9nZXRfeGFjdF9mdW5jdGlvbl90b3RhbF90 aW1lICovCitQR19TVEFUX0dFVF9YQUNUX0ZVTkNFTlRSWV9GTE9BVDhfTVModG90YWxfdGlt ZSkKIAorLyogcGdfc3RhdF9nZXRfeGFjdF9mdW5jdGlvbl9zZWxmX3RpbWUgKi8KK1BHX1NU QVRfR0VUX1hBQ1RfRlVOQ0VOVFJZX0ZMT0FUOF9NUyhzZWxmX3RpbWUpCiAKIC8qIEdldCB0 aGUgdGltZXN0YW1wIG9mIHRoZSBjdXJyZW50IHN0YXRpc3RpY3Mgc25hcHNob3QgKi8KIERh dHVtCg== --------------2wqaAcOEvM2Ned0CRUIjFxj0--