Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXSn3-0007qG-GB for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Mar 2022 19:06:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nXSn2-0005PI-D8 for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Mar 2022 19:06:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXSn2-0005P9-4C for pgsql-hackers@lists.postgresql.org; Thu, 24 Mar 2022 19:06:32 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXSmz-0001R6-Eo for pgsql-hackers@postgresql.org; Thu, 24 Mar 2022 19:06:31 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 3A6C46000B; Thu, 24 Mar 2022 19:06:22 +0000 (UTC) Message-ID: <6e514873-0185-d3b0-e3b2-4546be5e76f8@dunslane.net> Date: Thu, 24 Mar 2022 15:06:21 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: Granting SET and ALTER SYSTE privileges for GUCs Content-Language: en-US To: Mark Dilger Cc: Tom Lane , Peter Eisentraut , Joshua Brindle , Robert Haas , Jeff Davis , PostgreSQL-development , Joe Conway References: <3D691E20-C1D5-4B80-8BA5-6BEB63AF3029@enterprisedb.com> <2D6C1081-DB7D-4260-8987-5B4912E95917@enterprisedb.com> <1A6DA47B-2D5F-427E-AD72-1D8BD23BF94C@enterprisedb.com> <79685.1646604824@sss.pgh.pa.us> <83814.1646607430@sss.pgh.pa.us> <78889A65-CA7A-4015-866D-33460967071D@enterprisedb.com> <92485.1646609263@sss.pgh.pa.us> <43857434-3f9b-3! 66f-0401-7aea558827e1@dunslane.net> <664799.1647456444@sss.pgh.pa.us> <771410.1647528423@sss.pgh.pa.us> <9b37fa41-a068-8166-78c3-4503a867de07@dunslane.net> From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/24/22 12:49, Mark Dilger wrote: > >> On Mar 17, 2022, at 8:41 AM, Andrew Dunstan wrote: >> >> If we abandoned that for this form of GRANT/REVOKE I think we could >> probably get away with >> >> >> GRANT { SET | ALTER SYSTEM } ON setting_name ... >> >> >> I haven't tried it, so I could be all wrong. > Version 12 of the patch uses SET and ALTER SYSTEM as the names of the privileges, and PARAMETER as the name of the thing on which the privilege is granted. The catalog table which tracks these grants is now named pg_parameter_acl, and various other parts of the patch have been adjusted to use a "parameter" based, rather than a "setting" based, naming scheme. One exception to this rule is the "setacl" column in pg_parameter_acl, which is much more compact than the "parameteracl" name would be, so that remains under the old name. I can live with it I guess, but it seems perverse to me to have pg_settings but pg_paramater_acl effectively referring to the same set of things. If we're going to do this perhaps we should create a pg_parameters view which is identical to pg_settings and deprecate pg_settings. I don;t want to hold up this patch, I think this can probably be managed as a follow up item. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com