public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ilia Evdokimov <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: [PATCH] Fix incorrect range in pg_regress comment
Date: Sun, 2 Feb 2025 21:46:25 +0300
Message-ID: <[email protected]> (raw)

Hi hackers,

I noticed that a comment in pg_regress incorrectly states that 
alternative output files can be named filename{_i}.out with 0 < i <= 9. 
However, the actual valid range is 0 <= i <= 9. This patch corrects the 
comment.

The fix is trivial but ensures that the documentation in the code 
accurately reflects the behavior of pg_regress.

Attached is a small patch correcting this.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.


Attachments:

  [text/x-patch] v1-0001-Fix-incorrect-range-in-pg_regress-comment.patch (948B, ../[email protected]/3-v1-0001-Fix-incorrect-range-in-pg_regress-comment.patch)
  download | inline diff:
From d2ef1b2ff2f42bc38eb2d2d87201a2822d53d8b5 Mon Sep 17 00:00:00 2001
From: Ilia Evdokimov <[email protected]>
Date: Sun, 2 Feb 2025 21:35:10 +0300
Subject: [PATCH v1] Fix incorrect range in pg_regress comment

The comment in pg_regress incorrectly stated that alternative
output files could be named test{_i}.out with 0 < i <= 9.
However, the valid range is actually 0 <= i <= 9.
---
 src/test/regress/pg_regress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
index 61a234ae21..5d85dcc62f 100644
--- a/src/test/regress/pg_regress.c
+++ b/src/test/regress/pg_regress.c
@@ -1335,7 +1335,7 @@ make_directory(const char *dir)
 }
 
 /*
- * In: filename.ext, Return: filename_i.ext, where 0 < i <= 9
+ * In: filename.ext, Return: filename_i.ext, where 0 <= i <= 9
  */
 static char *
 get_alternative_expectfile(const char *expectfile, int i)
-- 
2.34.1

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [PATCH] Fix incorrect range in pg_regress comment
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox