Feedback-ID: ie0a040ee:Fastmail
Message-ID: <6e928f3b-c1fd-c2bb-bfc5-20cb641c7252@eisentraut.org>
Date: Wed, 31 May 2023 17:24:01 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.11.2
Subject: Re: generate syscache info automatically
Content-Language: en-US
To: =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?= <ilmari@ilmari.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <75ae5875-3abc-dafc-8aec-73247ed41cde@eisentraut.org>
 <871qiwtovy.fsf@wibble.ilmari.org>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <871qiwtovy.fsf@wibble.ilmari.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/6e928f3b-c1fd-c2bb-bfc5-20cb641c7252%40eisentraut.org>
Precedence: bulk

On 31.05.23 13:02, Dagfinn Ilmari Mannsåker wrote:
> For other patterns without the optional bits in the keyword, it becomes
> even simpler, e.g.
> 
> 		if (/^DECLARE_TOAST\(\s*
> 			 (?<parent_table>\w+),\s*
> 			 (?<toast_oid>\d+),\s*
> 			 (?<toast_index_oid>\d+)\s*
> 			 \)/x
> 		  )
> 		{
> 			push @{ $catalog{toasting} }, {%+};
> 	   	}
> 
> 
> I'd be happy to submit a patch to do this for all the ParseHeader()
> regexes (in a separate thread) if others agree this is an improvement.

I would welcome such a patch.