Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wV4Di-001ezu-1G for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Jun 2026 09:18:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wV4Dh-005llX-0x for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Jun 2026 09:18:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wV4Dg-005llO-0x for pgsql-hackers@lists.postgresql.org; Thu, 04 Jun 2026 09:18:33 +0000 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wV4Dd-00000001DA2-18VL for pgsql-hackers@lists.postgresql.org; Thu, 04 Jun 2026 09:18:32 +0000 Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 5018814000E4; Thu, 4 Jun 2026 05:18:27 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Thu, 04 Jun 2026 05:18:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm3; t=1780564707; x=1780651107; bh=URw7yXrY5E5baSZsSYyMTlJld4+Zi1pE w3OlX6AsYq4=; b=Yec7kKJ5NGUL7cKfguCh9/rAOfXY9Tf/XBAWMtcoqXxxkuHA OIkZd6LPlgNIDYhJoMNlJm5bGcCIKIZy6k9IhFzw16d4mVEdo84RrpiZGNZIzc37 ECoYbj1O7+uDp4BuTZUmpdogbCqloKX0bFHfZ6YRLH8r8kwPM+cPIJ+pkSJDIDRN VyBEE1nOEcFol/X3q/3AwEnJ4Zn0irzIhfZMqaSpgZ8kR9Mz8xUz98yMVPs4VBRA vX9NqJrx2gcsl0IUCmzbwnu+MdtvdnQb0uWhQk1S5orj+x112YSFCy+sX3F5xSuh mXWNggGRx7v/O9n1ScVfNzjfIJdH+iOFx8EW0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1780564707; x= 1780651107; bh=URw7yXrY5E5baSZsSYyMTlJld4+Zi1pEw3OlX6AsYq4=; b=a V4Pxhk2x6ljcRIERxKOpKAaVM7H4lsXkbc8UnQs5Ezcp4zwkqAQcmmhsaxyorRIR 59dfOiipY4ZGVbrgkJbtHe7bXYTIRIMXGMuhrcJtoOl6QHKGP3FQrXOC3NMNAbtl Z6zgmyZ9Lcs03fZd6at8OCc++N4T/Hd3TtxNQvQZi/J0AXDoZJ8G6QuuYIhEQ39+ VEzEbx0ySxnUKkIAHCNl/HEejFyrNaidGfrZrrJXxg0nwV5Ylo9cXbenfj/jvmGx 57smLMN2b6TuL7G9T/HKdHRo50AvGTGi4Duy4+fx2HhdP6uzhLBJnCm+ck0ZkWe6 g14I0cTx0hQ/PPdAP3g0Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGQuJpLoccULUw2VQSj1eIMUYdXE1M2y/eH0WzrnktRH7DqRVXyB584Gnim9R1vtL 5PmOfsBeaROqPOIUgfXCP75ylbuxFM2fA9JX43tHE9Jg1ne1GcfzQto2A1g3Rh5JJ5LQqD WmeZHiEXni0fvUsH0K2CRhryxvvQlStBaIgfMvSLc0OckfO5P5uFENI6gzeDfrWjSBnOr1 SIJYsHDwsY5KrbH9gcqLWeuWrwc7InA44HwKEo6tnrRrA28ve+Bn9s0IYjh1T7amgJBjaD snh8rYnLRwPA0JZxztkl+kej7B4qybms1uAiTLtgNOR+1+CvhLxn8frAfAWFgUctHSfoPP V5qAocZjzz9DbuGOfKQmk74qWwmhGXEaC/cWOTVBNoMHac0OBjXGVYkvpnMIFnIKgNLQcI hBPsB+L7YKeXddK2+pGMdWvlNaG+xZVuhhPDmd9nCIo96jENtL1zHrgqYi/xBoS3IWgq/X S8hqsWa2zAwzeed1kD9175VUA0tu2mfEvRkoHlxidTaR3x0vhapZ19V1NlFWCptXwaWW78 O97yNVEsV4ZQUkiLj7Tboe1UZvHKRo1uSxZVGTX1I4Gfe4jFwoNgjxhbC+9amy7dVsPC95 G8KAMSywE2HN5d/Rmf1rqgyAKwh2jtvHxx8MpinSSy9TiiM0y8VIgE7NEIRA X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 Jun 2026 05:18:26 -0400 (EDT) Message-ID: <6f0b82b0-4084-4bc8-95b2-237945d35e0a@eisentraut.org> Date: Thu, 4 Jun 2026 11:18:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Inconsistent trigger behavior between two temporal leftovers To: Paul A Jungwirth , Zsolt Parragi Cc: Sergei Patiakin , pgsql-hackers@lists.postgresql.org References: Content-Language: en-US From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 05.05.26 23:48, Paul A Jungwirth wrote: > On Tue, May 5, 2026 at 2:16 PM Zsolt Parragi wrote: >> >> + /* >> + * Re-copy the original row into leftoverSlot because >> + * ExecInsert may pass leftoverSlot to BEFORE INSERT >> + * triggers, which can modify the slot contents. >> + */ >> >> Shouldn't this mention BEFORE ROW INSERT triggers? Everywhere else the >> comments/commit message/test is specific about this. > > I agree being specific is helpful. Here is an updated patch. committed