Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHMXj-0004oG-W4 for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Jan 2023 10:16:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pHMXi-00038T-Tc for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Jan 2023 10:16:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHMXi-00038K-Jy for pgsql-hackers@lists.postgresql.org; Mon, 16 Jan 2023 10:16:42 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHMXg-0006Aj-BK for pgsql-hackers@postgresql.org; Mon, 16 Jan 2023 10:16:41 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id B72195818E9; Mon, 16 Jan 2023 05:16:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 16 Jan 2023 05:16:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673864199; x= 1673871399; bh=xOQXhZtjETTUa5IIiJ1uhvd9NU/FlCTfnCrWP4v9SFM=; b=d X+egLA64TbVrXv8gcMaXyTuQTkIpmz7vFB4RXdRS2c6OksRO9L43+Us8U7VZtBNW hCr26JEKr1ESQp0P8oV4FEI+MfFTI1ZrD6WOCUFj9pJ6SUGrgg6eMrJX6wz6+T9d 6snMSxc0rNiCzp/6TdcEBNUOEjGzEmTOCSFFYLlJYzGKkHznnByB7Fo19kDEpdC4 XV7Gl3Vf/fl1ion5qYGYH2EcS57g033SpOH1rsuPXZlD601QMRjMgeQ/sQFOUEGB yqhoeyqW7rZiXonU8vdyfMZ5DuDdT7UMmeM3qanCvzqmHQWLkydSRXnhTOVDJ2FY aVZqN8UNzZLhrWxFgdxJA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtgedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehleffgeegudejteei hfelteduvdeifffhffdvjedvffegjeekudeludehudeifeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 16 Jan 2023 05:16:39 -0500 (EST) Message-ID: <6f144e04-13e8-bd87-4ec7-2fa4db30c7e5@enterprisedb.com> Date: Mon, 16 Jan 2023 11:16:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Add BufFileRead variants with short read and EOF detection Content-Language: en-US To: Amit Kapila Cc: pgsql-hackers References: <9f980a18-8842-5efd-16b3-dd72e860b5a2@enterprisedb.com> <105210a5-8194-700b-5411-7002420013e4@enterprisedb.com> From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 14.01.23 07:01, Amit Kapila wrote: > On Thu, Jan 12, 2023 at 2:44 PM Peter Eisentraut > wrote: >> >> On 10.01.23 07:20, Amit Kapila wrote: >>> Yeah, we can do that but not sure if it is worth doing any of those >>> because there are already other places that don't use the exact >>> context. >> >> Ok, updated patches attached. > > Both the patches look good to me. Committed, and the first part backpatched.