Content-Type: multipart/alternative;
 boundary="------------Wfunn08FL2A2Exqb0n2eU49k"
Message-ID: <6f435023-8ab6-47c2-ba07-035d0c4212f9@gmail.com>
Date: Sat, 4 Apr 2026 17:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: TupleDescAttr bounds checks
To: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CA+TgmoacixUZVvi00hOjk_d9B4iYKswWP1gNqQ8Vfray-AcOCA@mail.gmail.com>
 <1628959.1774023745@sss.pgh.pa.us>
 <CA+TgmoaiPqnV2ePY-DyQUVGnK5sJ5ryPCDYpn_+1Ua4JwfoqRw@mail.gmail.com>
 <1631625.1774025167@sss.pgh.pa.us> <3429884.1774238081@sss.pgh.pa.us>
 <CA+TgmoZgc1m5Z7RFf9U7s_DgXE8GqnOB95fEWurdKFMR_U2xpQ@mail.gmail.com>
Content-Language: en-US
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: 
 <CA+TgmoZgc1m5Z7RFf9U7s_DgXE8GqnOB95fEWurdKFMR_U2xpQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/6f435023-8ab6-47c2-ba07-035d0c4212f9%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------Wfunn08FL2A2Exqb0n2eU49k
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hello Robert,

24.03.2026 12:45, Robert Haas wrote:
> On Sun, Mar 22, 2026 at 11:54 PM Tom Lane<tgl@sss.pgh.pa.us> wrote:
>>   Anyway, you should get this fix pushed.
> Done, and I'll plan to commit the other patches later today.

I've found a way to trigger the Assert added in c98ad086a:
CREATE TABLE t(i int);
COPY t FROM stdin WHERE tableoid > 0;
server closed the connection unexpectedly

(gdb) bt
#0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:44
#1  __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
#2  __GI___pthread_kill (threadid=<optimized out>, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
#3  0x00007066d0e4527e in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#4  0x00007066d0e288ff in __GI_abort () at ./stdlib/abort.c:79
#5  0x0000609680cc7fcf in ExceptionalCondition (
     conditionName=conditionName@entry=0x609680d2c104 "i >= 0 && i < tupdesc->natts",
     fileName=fileName@entry=0x609680d84568 "../../../src/include/access/tupdesc.h", lineNumber=lineNumber@entry=182)
     at assert.c:65
#6  0x00006096808c8f68 in TupleDescAttr (tupdesc=<optimized out>, i=<optimized out>)
     at ../../../src/include/access/tupdesc.h:182
#7  TupleDescAttr (i=<optimized out>, tupdesc=<optimized out>) at ../../../src/include/access/tupdesc.h:178
#8  DoCopy (pstate=0x6096a749dc90, stmt=0x6096a74ca120, stmt_location=0, stmt_len=40, processed=0x7ffd3b09b450) at 
copy.c:180
#9  0x0000609680b6b82a in standard_ProcessUtility (pstmt=0x6096a74ca1f0,
     queryString=0x6096a74c9520 "COPY t FROM stdin WHERE tableoid > 0;", readOnlyTree=<optimized out>,
     context=PROCESS_UTILITY_TOPLEVEL, params=0x0, queryEnv=0x0, dest=0x6096a74ca5b0, qc=0x7ffd3b09b6f0) at utility.c:743
#10 0x0000609680b6990c in PortalRunUtility (portal=portal@entry=0x6096a756a070, pstmt=pstmt@entry=0x6096a74ca1f0,
     isTopLevel=isTopLevel@entry=true, setHoldSnapshot=setHoldSnapshot@entry=false, dest=dest@entry=0x6096a74ca5b0,
     qc=qc@entry=0x7ffd3b09b6f0) at pquery.c:1148
...

Best regards,
Alexander
--------------Wfunn08FL2A2Exqb0n2eU49k
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Hello Robert,<br>
      <br>
      24.03.2026 12:45, Robert Haas wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CA+TgmoZgc1m5Z7RFf9U7s_DgXE8GqnOB95fEWurdKFMR_U2xpQ@mail.gmail.com">
      <pre wrap="" class="moz-quote-pre">On Sun, Mar 22, 2026 at 11:54 PM Tom Lane <a class="moz-txt-link-rfc2396E" href="mailto:tgl@sss.pgh.pa.us">&lt;tgl@sss.pgh.pa.us&gt;</a> wrote:
</pre>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre"> Anyway, you should get this fix pushed.
</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">
Done, and I'll plan to commit the other patches later today.
</pre>
    </blockquote>
    <br>
    I've found a way to trigger the Assert added in c98ad086a:<br>
    CREATE TABLE t(i int);<br>
    COPY t FROM stdin WHERE tableoid &gt; 0;<br>
    server closed the connection unexpectedly<br>
    <br>
    (gdb) bt<br>
    #0  __pthread_kill_implementation (no_tid=0, signo=6,
    threadid=&lt;optimized out&gt;) at ./nptl/pthread_kill.c:44<br>
    #1  __pthread_kill_internal (signo=6, threadid=&lt;optimized
    out&gt;) at ./nptl/pthread_kill.c:78<br>
    #2  __GI___pthread_kill (threadid=&lt;optimized out&gt;,
    signo=signo@entry=6) at ./nptl/pthread_kill.c:89<br>
    #3  0x00007066d0e4527e in __GI_raise (sig=sig@entry=6) at
    ../sysdeps/posix/raise.c:26<br>
    #4  0x00007066d0e288ff in __GI_abort () at ./stdlib/abort.c:79<br>
    #5  0x0000609680cc7fcf in ExceptionalCondition (<br>
        conditionName=conditionName@entry=0x609680d2c104 "i &gt;= 0
    &amp;&amp; i &lt; tupdesc-&gt;natts", <br>
        fileName=fileName@entry=0x609680d84568
    "../../../src/include/access/tupdesc.h",
    lineNumber=lineNumber@entry=182)<br>
        at assert.c:65<br>
    #6  0x00006096808c8f68 in TupleDescAttr (tupdesc=&lt;optimized
    out&gt;, i=&lt;optimized out&gt;)<br>
        at ../../../src/include/access/tupdesc.h:182<br>
    #7  TupleDescAttr (i=&lt;optimized out&gt;, tupdesc=&lt;optimized
    out&gt;) at ../../../src/include/access/tupdesc.h:178<br>
    #8  DoCopy (pstate=0x6096a749dc90, stmt=0x6096a74ca120,
    stmt_location=0, stmt_len=40, processed=0x7ffd3b09b450) at
    copy.c:180<br>
    #9  0x0000609680b6b82a in standard_ProcessUtility
    (pstmt=0x6096a74ca1f0, <br>
        queryString=0x6096a74c9520 "COPY t FROM stdin WHERE tableoid
    &gt; 0;", readOnlyTree=&lt;optimized out&gt;, <br>
        context=PROCESS_UTILITY_TOPLEVEL, params=0x0, queryEnv=0x0,
    dest=0x6096a74ca5b0, qc=0x7ffd3b09b6f0) at utility.c:743<br>
    #10 0x0000609680b6990c in PortalRunUtility
    (portal=portal@entry=0x6096a756a070,
    pstmt=pstmt@entry=0x6096a74ca1f0, <br>
        isTopLevel=isTopLevel@entry=true,
    setHoldSnapshot=setHoldSnapshot@entry=false,
    dest=dest@entry=0x6096a74ca5b0, <br>
        qc=qc@entry=0x7ffd3b09b6f0) at pquery.c:1148<br>
    ...<br>
    <br>
    Best regards,<br>
    Alexander<br>
  </body>
</html>

--------------Wfunn08FL2A2Exqb0n2eU49k--