Subject: Re: clean up obsolete initdb locale handling
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <eeaf2f99-a1a6-8aca-3f43-9ab0b2fb112a@2ndquadrant.com>
 <27394.1565276193@sss.pgh.pa.us> <30434.1565279505@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Openpgp: preference=signencrypt
Autocrypt: addr=peter.eisentraut@2ndquadrant.com; prefer-encrypt=mutual;
 keydata=
 xsFNBFUUt6kBEADZd9NNTBJbHmAXXJgPGOdd6Q73l80oifIVgn2tRxP9dYkCfTlo/yLqbKTl
 JNqTcyM6XrJDnB2sMEUGYCewYZXl+9C4bBJWyNqcEI1ae9u71vEq/fknFLArJ+2wN+f7QuRx
 Q8d94ZJAiJQ5g3fNk2HVeedCQCKP5dCzU+ZLt2dbsx1PDZLjTO9gf+JswWuGFb5wY5PZVM5V
 hq66Xk7ZJzHuARacza2RT7J2fkMmQBY+kr7L98Perb0GhafnlhXB0PvUB+N3xpmggMfwuhTu
 BngS/G/r3GvemxJuFxouw8xsMqrsfdksJXA2gLXYtwRCssdPV3PO0rlD9twqDo8URfIJ5fb6
 1g/MV8aTOKjg3Q8MpJPtkwJqN4o3PvbwYdedeFnOVkkYAJdu/aX1v1BeCBDu7Hy3sF52scD3
 pQbyQSl9vUDpTLarASAxNbAV0NRJE8dp4vfW6AH1ccryGiFqw/czPK/iN0+MT8wsjAW6WW4w
 hvjm5UPA1KTwi3ZT8eT5uycuH7QpuNk7LnGGXQ6KaRALFywzkr0A0V0AvFNa+l4wstMaXaB6
 dmMXyF0/hfryqyOeu1gAdq4q0/PNC2dPgb/6uoh4eMjN6A5GXcprilhz5DulmsilY21hfSoU
 S64ODed96pKhprsOxjZiDRsN1QM5MwB+uwVWUNfsX7fIxE0BrwARAQABzSdQZXRlciBFaXNl
 bnRyYXV0IDxwZXRlckBlaXNlbnRyYXV0Lm9yZz7CwXoEEwEIACQCGwMFCwkIBwMFFQoJCAsF
 FgIDAQACHgECF4AFAlUUuKQCGQEACgkQoZ8SQ+xBJp8llw//RbGoXnF72FZTlOFsnNyxnWbF
 vViPCfdAlZl1GGK9OYCvV1dp/956HuhB0wpaGQHiBmQfOPJf/jLOPjXFYm2iEChEycrBChuE
 j4TSYemMp5BSPILYk9Uwd16kVD/+U6fQfK6H5pOhfBvbM6asMnmpY2wQuvktxHvaGlytFw84
 EzFWNZtAZfxkw28w3AhIQkKe9hJanfyDL750RcbyEr8AAHty5IErrvS7tM5vQwIeh5BF26ND
 CyKPRdZgOgMpcwFfROKBDpAt052CgWIpNdhBdfIKlkCs4/ILxmC3rT/Mb/qZiHcoMMwEu6k+
 T7vRAFZZAk62Yrr/U8/vUGKlzRZQoo86fyojCfI0ibCIc0z8rwCVY9P40G9wD9BTCZS/z8Vh
 jjpBlNnIKw2hM6hbxavKndCJjFFJD08rXrTyrLF/of18xD37vNdYooP9VATB5QjOWFRrscSZ
 4a89e+to3m7YVnd4xdXwGp47dYusoax84C8tg1gZrH38ol9dPmnKX6GZrXeS7tH9k8VeUpJ8
 HQbRThQRWAT936QpYbLConBmOtmbLmjQOGtiXPo1oK57X/7U/WBja5vWmm2q+Yxtt+3uHGVg
 DdDU4CJpXo4lX0v2n3QV5EBSW9hjdF3bNfl6GFBb1pPEhqNcMDUc7zkx/2uENdAdk/BnqMgH
 umip7b0pVfvOwU0EVRS3qQEQAJf6p0P7D+hMYUgCPkvgrcz6OJYsAYdUMUmokfqmkKwK0oJM
 ew8TNGM53ocKAgQGma5f10rwbZNPlpVPNRX5hwUmwVlcwSut0oE+JfUBH7mpysWvpF05RKIy
 q9RCoJZrAbXS7Tig56A1QD8IcM00rERZMcCOlI1+q9m4u9AOI+0LyGGSH+VvoyDHD/Jew4R2
 TmPEF8Pu7lYiNYK88Q6u0kBkc+Tz3BNlyc6fi3HxnFfp0b75HLXPSTu2SwA/0Q31wHZXwrEU
 BR9KgSn/qbgy8ydPc97i82fhiFE3cbGexfPrQSMYmDGi+dcQ0s+AMQwC3XyMC0JkHpYUuFkR
 QdlIvaIhgFUUN2Vr4xF2ADaNTNFc4DYaiPHFAgHZw+3pZWqS4uIiWgJynrEaHw4F3QWU8/JB
 iyEWDhNq4WBrRA0u914TCCAoFOOKMnRdl8eJrRQKM/5/lXbHFjjlI/LDKhLRFsuQsnJJ3331
 RjCzpHPZG5/p5KR1RHiAXa0p/DW5lXyq21hS3kjDlleoHqOxCN/cy0Jgz7qLDq1vZoCl67Sy
 RAH60c2Xu4may9SVltmot0OzWVHdrfS+85FQGp9580DaeLio7YMFKy2bfEvwQJ/c9xD2QPB+
 oSb3V8ueSznXBG5+dyfOsZFRPxceA0wA2rSWZSjxLdKxvyGTj9vsCjaDu13rABEBAAHCwV8E
 GAEIAAkFAlUUt6kCGwwACgkQoZ8SQ+xBJp+HJhAAxmSTsC5y7p9Zu+nnLpucv/h88oEx985e
 qWeXzQiwM3pfRZS+PdTH9TyzHK0KOgKoAiubk0vt+BrT91D9d0G5kVQaTctAErGBoMkTaZJT
 XVEcNphiPzysdSqvprjojMp1y7rG8AP+Xd6m0rE1LRnkRRm8HyI8vdXsuLQPITGWXDLMjaNq
 AOV3BUnzkgtjMuIYw7SCr+12ZOb5dEKvaG4kjC4kaJ/TLbuBhVANcXkC90yp0AOZLs/cB1Dj
 OAXno/RUUruJ3r27a+pFv768UAi9QWcdw58yPxreMNMLqAgsS9oTHwHfGNWcB2dJ4UW+GMLJ
 hTf9TjQ2f+N/sIx5XMQ9pYw6CAJMK29qPx6/ZayrPxf22EXf0D3zTwIEZgwfSkynFVwV25L7
 awQq60fifdMYheSxq7GbhpsixmcD+e161cCmLIt75YDt5bQ0B1yf7EmxG8n7pGZAOM6LoNsU
 fkSldba5XVwh8LuN5mK0nQBELGW6Os4TDq4REggLpfcvFC215zpuo0iCGnmE/Bns4nowqUSP
 u4tkWL+nxW4qgv8wo8HJ52jd79EJ8iqfIBoidBfy9AIUiEUApGQzWPu6yWcI8fY0rN5D+tc+
 Yw1Zt6Mm+huYJpgCRsTcfzEcahnBn521CWcWvhW1ff3KFileFMtNmnBBhMncmRKHphtTKEpN
 3jI=
Organization: 2ndQuadrant
Message-ID: <6f738422-ffb2-5e75-1227-8815ee84998f@2ndquadrant.com>
Date: Mon, 12 Aug 2019 20:11:55 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <30434.1565279505@sss.pgh.pa.us>
Content-Type: multipart/mixed;
 boundary="------------7CDD63FB2A8550EDDF1C51B8"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------7CDD63FB2A8550EDDF1C51B8
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 2019-08-08 17:51, Tom Lane wrote:
> However, I don't much like the choice to set LC_COLLATE and LC_CTYPE
> differently.  That seems to be risking weird behavior, and for what?
> I'd be inclined to just remove the WIN32 stanza, initialize all
> three of these variables with "", and explain it along the lines of
> 
>     * In the postmaster, absorb the environment values for LC_COLLATE
>     * and LC_CTYPE.  Individual backends will change these later to
>     * settings taken from pg_database, but the postmaster cannot do
>     * that.  If we leave these set to "C" then message localization
>     * might not work well in the postmaster.

OK, let's do it like that.  Updated patch attached.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--------------7CDD63FB2A8550EDDF1C51B8
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="v2-0001-initdb-Remove-obsolete-locale-handling.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="v2-0001-initdb-Remove-obsolete-locale-handling.patch"

RnJvbSBlM2RlY2E1YjcyMzZkMWY4M2EyODZmMzQ3MzM4ZjMyMGNhOTUyMTQ3IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogTW9uLCAxMiBBdWcgMjAxOSAyMDowOTo0MCArMDIwMApTdWJqZWN0
OiBbUEFUQ0ggdjJdIGluaXRkYjogUmVtb3ZlIG9ic29sZXRlIGxvY2FsZSBoYW5kbGluZwoK
VGhlIG1ldGhvZCBvZiBwYXNzaW5nIExDX0NPTExBVEUgYW5kIExDX0NUWVBFIHRvIHRoZSBi
YWNrZW5kIGR1cmluZwppbml0ZGIgaXMgb2Jzb2xldGUgYXMgb2YgNjFkOTY3NDk4ODAyYWI4
NmQ4ODk3Y2IzYzYxNzQwZDdlOWQ3MTJmNi4KVGhpcyBjYW4gYWxsIGJlIHJlbW92ZWQuCgpE
aXNjdXNzaW9uOiBodHRwczovL3d3dy5wb3N0Z3Jlc3FsLm9yZy9tZXNzYWdlLWlkL2ZsYXQv
ZWVhZjJmOTktYTFhNi04YWNhLTNmNDMtOWFiMGIyZmIxMTJhJTQwMm5kcXVhZHJhbnQuY29t
Ci0tLQogc3JjL2JhY2tlbmQvbWFpbi9tYWluLmMgfCAzOCArKysrKysrKysrLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLQogc3JjL2Jpbi9pbml0ZGIvaW5pdGRiLmMgfCAxNCAtLS0t
LS0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA0MiBkZWxl
dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9tYWluL21haW4uYyBiL3NyYy9i
YWNrZW5kL21haW4vbWFpbi5jCmluZGV4IDdiMThmOGM3NTguLmE5ZWRiZmQ0YTQgMTAwNjQ0
Ci0tLSBhL3NyYy9iYWNrZW5kL21haW4vbWFpbi5jCisrKyBiL3NyYy9iYWNrZW5kL21haW4v
bWFpbi5jCkBAIC05OSw0MiArOTksMjQgQEAgbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltd
KQogCU1lbW9yeUNvbnRleHRJbml0KCk7CiAKIAkvKgotCSAqIFNldCB1cCBsb2NhbGUgaW5m
b3JtYXRpb24gZnJvbSBlbnZpcm9ubWVudC4gIE5vdGUgdGhhdCBMQ19DVFlQRSBhbmQKLQkg
KiBMQ19DT0xMQVRFIHdpbGwgYmUgb3ZlcnJpZGRlbiBsYXRlciBmcm9tIHBnX2NvbnRyb2wg
aWYgd2UgYXJlIGluIGFuCi0JICogYWxyZWFkeS1pbml0aWFsaXplZCBkYXRhYmFzZS4gIFdl
IHNldCB0aGVtIGhlcmUgc28gdGhhdCB0aGV5IHdpbGwgYmUKLQkgKiBhdmFpbGFibGUgdG8g
ZmlsbCBwZ19jb250cm9sIGR1cmluZyBpbml0ZGIuICBMQ19NRVNTQUdFUyB3aWxsIGdldCBz
ZXQKLQkgKiBsYXRlciBkdXJpbmcgR1VDIG9wdGlvbiBwcm9jZXNzaW5nLCBidXQgd2Ugc2V0
IGl0IGhlcmUgdG8gYWxsb3cgc3RhcnR1cAotCSAqIGVycm9yIG1lc3NhZ2VzIHRvIGJlIGxv
Y2FsaXplZC4KKwkgKiBTZXQgdXAgbG9jYWxlIGluZm9ybWF0aW9uCiAJICovCi0KIAlzZXRf
cGdsb2NhbGVfcGdzZXJ2aWNlKGFyZ3ZbMF0sIFBHX1RFWFRET01BSU4oInBvc3RncmVzIikp
OwogCi0jaWZkZWYgV0lOMzIKLQogCS8qCi0JICogV2luZG93cyB1c2VzIGNvZGVwYWdlcyBy
YXRoZXIgdGhhbiB0aGUgZW52aXJvbm1lbnQsIHNvIHdlIHdvcmsgYXJvdW5kCi0JICogdGhh
dCBieSBxdWVyeWluZyB0aGUgZW52aXJvbm1lbnQgZXhwbGljaXRseSBmaXJzdCBmb3IgTENf
Q09MTEFURSBhbmQKLQkgKiBMQ19DVFlQRS4gV2UgaGF2ZSB0byBkbyB0aGlzIGJlY2F1c2Ug
aW5pdGRiIHBhc3NlcyB0aG9zZSB2YWx1ZXMgaW4gdGhlCi0JICogZW52aXJvbm1lbnQuIElm
IHRoZXJlIGlzIG5vdGhpbmcgdGhlcmUgd2UgZmFsbCBiYWNrIG9uIHRoZSBjb2RlcGFnZS4K
KwkgKiBJbiB0aGUgcG9zdG1hc3RlciwgYWJzb3JiIHRoZSBlbnZpcm9ubWVudCB2YWx1ZXMg
Zm9yIExDX0NPTExBVEUgYW5kCisJICogTENfQ1RZUEUuICBJbmRpdmlkdWFsIGJhY2tlbmRz
IHdpbGwgY2hhbmdlIHRoZXNlIGxhdGVyIHRvIHNldHRpbmdzCisJICogdGFrZW4gZnJvbSBw
Z19kYXRhYmFzZSwgYnV0IHRoZSBwb3N0bWFzdGVyIGNhbm5vdCBkbyB0aGF0LiAgSWYgd2Ug
bGVhdmUKKwkgKiB0aGVzZSBzZXQgdG8gIkMiIHRoZW4gbWVzc2FnZSBsb2NhbGl6YXRpb24g
bWlnaHQgbm90IHdvcmsgd2VsbCBpbiB0aGUKKwkgKiBwb3N0bWFzdGVyLgogCSAqLwotCXsK
LQkJY2hhcgkgICAqZW52X2xvY2FsZTsKLQotCQlpZiAoKGVudl9sb2NhbGUgPSBnZXRlbnYo
IkxDX0NPTExBVEUiKSkgIT0gTlVMTCkKLQkJCWluaXRfbG9jYWxlKCJMQ19DT0xMQVRFIiwg
TENfQ09MTEFURSwgZW52X2xvY2FsZSk7Ci0JCWVsc2UKLQkJCWluaXRfbG9jYWxlKCJMQ19D
T0xMQVRFIiwgTENfQ09MTEFURSwgIiIpOwotCi0JCWlmICgoZW52X2xvY2FsZSA9IGdldGVu
digiTENfQ1RZUEUiKSkgIT0gTlVMTCkKLQkJCWluaXRfbG9jYWxlKCJMQ19DVFlQRSIsIExD
X0NUWVBFLCBlbnZfbG9jYWxlKTsKLQkJZWxzZQotCQkJaW5pdF9sb2NhbGUoIkxDX0NUWVBF
IiwgTENfQ1RZUEUsICIiKTsKLQl9Ci0jZWxzZQogCWluaXRfbG9jYWxlKCJMQ19DT0xMQVRF
IiwgTENfQ09MTEFURSwgIiIpOwogCWluaXRfbG9jYWxlKCJMQ19DVFlQRSIsIExDX0NUWVBF
LCAiIik7Ci0jZW5kaWYKIAorCS8qCisJICogTENfTUVTU0FHRVMgd2lsbCBnZXQgc2V0IGxh
dGVyIGR1cmluZyBHVUMgb3B0aW9uIHByb2Nlc3NpbmcsIGJ1dCB3ZSBzZXQKKwkgKiBpdCBo
ZXJlIHRvIGFsbG93IHN0YXJ0dXAgZXJyb3IgbWVzc2FnZXMgdG8gYmUgbG9jYWxpemVkLgor
CSAqLwogI2lmZGVmIExDX01FU1NBR0VTCiAJaW5pdF9sb2NhbGUoIkxDX01FU1NBR0VTIiwg
TENfTUVTU0FHRVMsICIiKTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9pbml0ZGIv
aW5pdGRiLmMgYi9zcmMvYmluL2luaXRkYi9pbml0ZGIuYwppbmRleCA1NTFkMzc5ZDg1Li44
OGEyNjFkOWJkIDEwMDY0NAotLS0gYS9zcmMvYmluL2luaXRkYi9pbml0ZGIuYworKysgYi9z
cmMvYmluL2luaXRkYi9pbml0ZGIuYwpAQCAtMTQxNywyMCArMTQxNyw2IEBAIGJvb3RzdHJh
cF90ZW1wbGF0ZTEodm9pZCkKIAlia2lfbGluZXMgPSByZXBsYWNlX3Rva2VuKGJraV9saW5l
cywgIkxDX0NUWVBFIiwKIAkJCQkJCQkgIGVzY2FwZV9xdW90ZXNfYmtpKGxjX2N0eXBlKSk7
CiAKLQkvKgotCSAqIFBhc3MgY29ycmVjdCBMQ194eHggZW52aXJvbm1lbnQgdG8gYm9vdHN0
cmFwLgotCSAqCi0JICogVGhlIHNoZWxsIHNjcmlwdCBhcnJhbmdlZCB0byByZXN0b3JlIHRo
ZSBMQyBzZXR0aW5ncyBhZnRlcndhcmRzLCBidXQKLQkgKiB0aGVyZSBkb2Vzbid0IHNlZW0g
dG8gYmUgYW55IGNvbXBlbGxpbmcgcmVhc29uIHRvIGRvIHRoYXQuCi0JICovCi0Jc25wcmlu
dGYoY21kLCBzaXplb2YoY21kKSwgIkxDX0NPTExBVEU9JXMiLCBsY19jb2xsYXRlKTsKLQlw
dXRlbnYocGdfc3RyZHVwKGNtZCkpOwotCi0Jc25wcmludGYoY21kLCBzaXplb2YoY21kKSwg
IkxDX0NUWVBFPSVzIiwgbGNfY3R5cGUpOwotCXB1dGVudihwZ19zdHJkdXAoY21kKSk7Ci0K
LQl1bnNldGVudigiTENfQUxMIik7Ci0KIAkvKiBBbHNvIGVuc3VyZSBiYWNrZW5kIGlzbid0
IGNvbmZ1c2VkIGJ5IHRoaXMgZW52aXJvbm1lbnQgdmFyOiAqLwogCXVuc2V0ZW52KCJQR0NM
SUVOVEVOQ09ESU5HIik7CiAKLS0gCjIuMjIuMAoK
--------------7CDD63FB2A8550EDDF1C51B8--