Message-ID: <6f7701b0-ce5c-d01c-18f2-5de3a02ff6b6@enterprisedb.com>
Date: Thu, 24 Feb 2022 10:53:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: Design of pg_stat_subscription_workers vs pgstats
Content-Language: en-US
To: Masahiko Sawada <sawada.mshk@gmail.com>,
 Peter Smith <smithpb2250@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Andres Freund
 <andres@anarazel.de>, "David G. Johnston" <david.g.johnston@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <20220215182641.2cejma6tcgeoqyw2@alap3.anarazel.de>
 <CAA4eK1Jwn5hhgHJWZ9n+wYyQEk+brfR1zkuqLjh=waji8RYWAw@mail.gmail.com>
 <CAD21AoAqEt=TbUDY96Uhf9pNuh-NDR_3-CByd+xR=tFEq==1NA@mail.gmail.com>
 <CAD21AoA-MVZcMA1iYwbtvTCOHx1SwG8amQUTT8j2ssh2zuc6OQ@mail.gmail.com>
 <20220218203255.d3evl6qi2n6gxy6b@alap3.anarazel.de>
 <CAD21AoDTO3bJvrc39Tv3VCeyUzZpimXnJuRhHQhKyjOWorHeOA@mail.gmail.com>
 <20220219160203.y5w2ktc2utthn7pe@alap3.anarazel.de>
 <CAD21AoA_r+Wc-zJZdy4Lii3oOvvdGcLwrY=2Y4y63HueYSd6Eg@mail.gmail.com>
 <20220221053453.lo6fzmji23ennvgj@alap3.anarazel.de>
 <CAA4eK1+j00Pc+p=AfJLXh-a+OJ-a0UD4adMr2tRkQvKG_LggHA@mail.gmail.com>
 <20220221074806.nyhdberpuwbcbudp@alap3.anarazel.de>
 <CAA4eK1J3dhfMRNQ6Q585nFr1vmXaTXVW9qv4hmUxLwDwJp-9RQ@mail.gmail.com>
 <CAD21AoAtrgBEUU08VvfzRnGS+=9rS=MEq1cTLaZ1OT51xX34dQ@mail.gmail.com>
 <CAHut+PtH-uN5rbGRh-=kCd8xvQYDf_JCcjLcVjW3OXGz6T+xCw@mail.gmail.com>
 <CAD21AoCCaQfGzDCAJgYH=yo72GXozpoMF4fau=5gViXK+uquWw@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <CAD21AoCCaQfGzDCAJgYH=yo72GXozpoMF4fau=5gViXK+uquWw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/6f7701b0-ce5c-d01c-18f2-5de3a02ff6b6%40enterprisedb.com>
Precedence: bulk

On 24.02.22 02:32, Masahiko Sawada wrote:
> On Wed, Feb 23, 2022 at 12:08 PM Peter Smith <smithpb2250@gmail.com> wrote:
>>
>> Hi. Below are my review comments for the v1 patch.
> 
> Thank you for the comments! I've attached the latest version patch
> that incorporated all comments I got so far. The primary change from
> the previous version is that the subscription statistics live globally
> rather than per-database.

I don't think the name pg_stat_subscription_activity is a good choice.

We have a view called pg_stat_activity, which is very well known.  From 
that perspective, "activity" means what is happening right now or what 
has happened most recently.  The reworked view in this patch does not 
contain that (we already have pg_stat_subscription for that), but it 
contains accumulated counters.