Subject: Re: Retiring support for pre-7.3 FK constraint triggers
To: Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
 Postgres hackers <pgsql-hackers@lists.postgresql.org>
References: <20200305143041.GA7031@alvherre.pgsql>
 <1154.1583419325@sss.pgh.pa.us>
 <B3B93FAD-5B8C-4594-A33B-CAE504520530@yesql.se>
 <3685.1583422389@sss.pgh.pa.us>
From: Vik Fearing <vik@postgresfriends.org>
Message-ID: <6f973fcb-64e6-341f-50c4-c467e8901c1d@postgresfriends.org>
Date: Thu, 5 Mar 2020 18:19:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <3685.1583422389@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05/03/2020 16:33, Tom Lane wrote:
> Elsewhere in indexcmds.c, there's this:
> 
>         /*
>          * Hack to provide more-or-less-transparent updating of old RTREE
>          * indexes to GiST: if RTREE is requested and not found, use GIST.
>          */
>         if (strcmp(accessMethodName, "rtree") == 0)
>         {
>             ereport(NOTICE,
>                     (errmsg("substituting access method \"gist\" for obsolete method \"rtree\"")));
>             accessMethodName = "gist";
>             tuple = SearchSysCache1(AMNAME, PointerGetDatum(accessMethodName));
>         }

Aww, this one is in my list of gotcha trivia questions.

That's not a reason not to remove it, of course.
-- 
Vik Fearing