Feedback-ID: i131946ab:Fastmail
Message-ID: <6f9eff5c-ecc6-c0d5-df8e-8df9e2f10534@enterprisedb.com>
Date: Tue, 13 Sep 2022 16:11:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.2.2
Subject: Re: [PATCH] Log details for client certificate failures
Content-Language: en-US
To: Jacob Champion <jchampion@timescale.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <2878aee8-a4a6-8078-9740-efe90fcf8328@timescale.com>
 <1d3d62a0-2d7f-4592-bf76-ba59a77e61cc@timescale.com>
 <20220715234519.7o4mlpxapmqmv6p7@awork3.anarazel.de>
 <CAAWbhmiH2dPpRUnpS6pe9Fge--gj_az4ra2AJO1JvTKeiFuAug@mail.gmail.com>
 <20220719161432.qha3s76vyc6k4v5m@awork3.anarazel.de>
 <c0eca922-59db-ad5c-193f-09bc36b92468@timescale.com>
 <1212792.1658248783@sss.pgh.pa.us>
 <20220719170954.nshvmok3tymxdpl3@awork3.anarazel.de>
 <CAAWbhmiVZgfAUc=BuahotfHokWuJXLD6KQs8gYVvp_twFgQ-xg@mail.gmail.com>
 <20220719223823.pj4z36ce3zb27qdb@alap3.anarazel.de>
 <CAAWbhmhGOh_1C6x1A8K5hsMuSeOF5hxQ4ZMGkFhqmVTZ0otzRQ@mail.gmail.com>
 <2007344.1658355307@sss.pgh.pa.us>
 <CAAWbhmj3q=RbGwurus5V3Dh7u5q9msVmQ=61mZptoWxBBuWJug@mail.gmail.com>
 <2012342.1658356951@sss.pgh.pa.us>
 <CAAWbhmgsvHrH9wLU2kYc3pOi1KSenHSLAHBbCVmmddW6-mc_=w@mail.gmail.com>
 <CAAWbhmisCf9qzPhQamYUobJvC7r1A1sCeZWJZpDBWh+FHJ=RGQ@mail.gmail.com>
 <CAAWbhmhrEd2wcnmf4KxAXyx+Rj7nm+oiaxQSjfAzC5qU4_e8ng@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <CAAWbhmhrEd2wcnmf4KxAXyx+Rj7nm+oiaxQSjfAzC5qU4_e8ng@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/6f9eff5c-ecc6-c0d5-df8e-8df9e2f10534%40enterprisedb.com>
Precedence: bulk

On 09.09.22 00:32, Jacob Champion wrote:
> On Thu, Jul 28, 2022 at 9:19 AM Jacob Champion <jchampion@timescale.com> wrote:
>> On Thu, Jul 21, 2022 at 4:29 PM Jacob Champion <jchampion@timescale.com> wrote:
>>> v4 attempts to fix this by letting the check hooks pass
>>> MCXT_ALLOC_NO_OOM to pg_clean_ascii(). (It's ignored in the frontend,
>>> which just mallocs.)
>>
>> Ping -- should I add an open item somewhere so this isn't lost?
> 
> Trying again. Peter, is this approach acceptable? Should I try something else?

This looks fine to me.  Committed.