Content-Type: multipart/alternative;
 boundary="------------7r45rQnMKk7KdMoX0R05czkp"
Message-ID: <6fbfb5ce-5613-43bf-8a84-3da1c0da4746@postgrespro.ru>
Date: Sun, 31 Dec 2023 13:52:28 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Things I don't like about \du's "Attributes" column
Content-Language: en-US, ru-RU
To: Isaac Morland <isaac.morland@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
References: <4133242.1687481416@sss.pgh.pa.us>
 <27f87cb9-229b-478b-81b2-157f94239d55@postgrespro.ru>
 <CAMsGm5fDAVUTPeLAK-CjhrC7obQd-+i0EFPzAHFTMQrRoFaydA@mail.gmail.com>
From: Pavel Luzanov <p.luzanov@postgrespro.ru>
In-Reply-To: <CAMsGm5fDAVUTPeLAK-CjhrC7obQd-+i0EFPzAHFTMQrRoFaydA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/6fbfb5ce-5613-43bf-8a84-3da1c0da4746%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------7r45rQnMKk7KdMoX0R05czkp
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 30.12.2023 17:33, Isaac Morland wrote:
> Would it make sense to make the column non-nullable and always set it 
> to infinity when there is no expiry?

A password is not required for roles. In many cases, external 
authentication is used in ph_hba.conf.
I think it would be strange to have 'infinity' for roles without a password.

Tom suggested to have 'infinity' in the \du output for roles with a 
password.
My doubt is that this will hide the real values (absence of values). So 
I suggested a separate column
'Has password?' to show roles with password and unmodified column 
'Password expire time'.

Yes, it's easy to replace NULL with "infinity" for roles with a 
password, but why?
What is the reason for this action? Absence of value for 'expire time' 
clear indicates that there is no time limit.
Also I don't see a practical reasons to execute next command, since it 
do nothing:

ALTER ROLE .. PASSWORD 'infinity';

So I think that in most cases there is no "infinity" in the 
rolvaliduntil column.

But of course, I can be wrong.

Thank you for giving your opinion.

-- 
Pavel Luzanov
Postgres Professional:https://postgrespro.com

--------------7r45rQnMKk7KdMoX0R05czkp
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <font face="monospace">On 30.12.2023 17:33, Isaac Morland wrote:</font><br>
    <blockquote type="cite"
cite="mid:CAMsGm5fDAVUTPeLAK-CjhrC7obQd-+i0EFPzAHFTMQrRoFaydA@mail.gmail.com">
      <div dir="ltr">
        <div class="gmail_quote">
          <div><font face="monospace">Would it make sense to make the
              column non-nullable and always set it to infinity when
              there is no expiry?</font></div>
        </div>
      </div>
    </blockquote>
    <font face="monospace"><br>
      A password is not required for roles. In many cases, external
      authentication is used in ph_hba.conf.<br>
      I think it would be strange to have 'infinity' for roles without a
      password.<br>
      <br>
      Tom suggested to have 'infinity' in the \du output for roles with
      a password.<br>
      My doubt is that this will hide the real values (absence of
      values). So I suggested a separate column<br>
      'Has password?' to show roles with password and unmodified column
      'Password expire time'.<br>
      <br>
      Yes, it's easy to replace NULL with "infinity" for roles with a
      password, but why?<br>
      What is the reason for this action? Absence of value for 'expire
      time' clear indicates that there is no time limit.<br>
      Also I don't see a practical reasons to execute next command, </font><font
      face="monospace">since it do nothing:</font><br>
    <font face="monospace"><br>
      ALTER ROLE .. PASSWORD 'infinity';<br>
      <br>
      So I think that in most cases there is no "infinity" in the
      rolvaliduntil column.<br>
      <br>
      But of course, I can be wrong.</font>
    <div class="gmail_quote">
      <div><font face="monospace"><br>
          Thank you for giving your opinion.<br>
        </font></div>
    </div>
    <font face="monospace"><br>
    </font>
    <pre class="moz-signature" cols="72">-- 
Pavel Luzanov
Postgres Professional: <a class="moz-txt-link-freetext" href="https://postgrespro.com">https://postgrespro.com</a></pre>
  </body>
</html>

--------------7r45rQnMKk7KdMoX0R05czkp--