public inbox for [email protected]  

help / color / mirror / Atom feed

From: Joel Jacobson <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: [PATCH] Remove obsolete LISTEN array growth isolation test
Date: Wed, 20 May 2026 04:50:06 -0700
Message-ID: <[email protected]> (raw)

Hi hackers,

This is a small patch that just removes an unnecessary test,
reported by Alexander Lakhin [1].

/Joel

[1] https://www.postgresql.org/message-id/037ce9cd-28ad-4c19-9be1-d8c1f577a322%40gmail.com


Attachments:

  [application/octet-stream] 0001-Remove-obsolete-LISTEN-array-growth-isolation-test.patch (3.1K, 2-0001-Remove-obsolete-LISTEN-array-growth-isolation-test.patch)
  download | inline diff:
From f8b2d97239918e176f4c61200690e50fe5a5ffdf Mon Sep 17 00:00:00 2001
From: Joel Jacobson <[email protected]>
Date: Wed, 20 May 2026 04:39:48 -0700
Subject: [PATCH] Remove obsolete LISTEN array growth isolation test

async-notify.spec still had a permutation and third listener
session for ChannelHashAddListener array growth.  That function was
removed by the LISTEN/NOTIFY rework, so the test no longer exercises a
meaningful path.

Remove the stale session, permutation, and expected output.
---
 src/test/isolation/expected/async-notify.out | 11 +----------
 src/test/isolation/specs/async-notify.spec   |  9 ---------
 2 files changed, 1 insertion(+), 19 deletions(-)

diff --git a/src/test/isolation/expected/async-notify.out b/src/test/isolation/expected/async-notify.out
index 5d6bcce2b02..55b7cbc6e02 100644
--- a/src/test/isolation/expected/async-notify.out
+++ b/src/test/isolation/expected/async-notify.out
@@ -1,4 +1,4 @@
-Parsed test spec with 7 sessions
+Parsed test spec with 6 sessions
 
 starting permutation: listenc notify1 notify2 notify3 notifyf
 step listenc: LISTEN c1; LISTEN c2;
@@ -149,13 +149,6 @@ notifier: NOTIFY "c1" with payload "msg15" from notifier
 notifier: NOTIFY "c1" with payload "msg16" from notifier
 notifier: NOTIFY "c1" with payload "msg17" from notifier
 
-starting permutation: listenc llisten l2listen l3listen lslisten
-step listenc: LISTEN c1; LISTEN c2;
-step llisten: LISTEN c1; LISTEN c2;
-step l2listen: LISTEN c1;
-step l3listen: LISTEN c1;
-step lslisten: LISTEN c1; LISTEN c2;
-
 starting permutation: llisten notify1 notify2 notify3 notifyf lcheck
 step llisten: LISTEN c1; LISTEN c2;
 step notify1: NOTIFY c1;
@@ -204,8 +197,6 @@ listener: NOTIFY "c2" with payload "" from notifier
 
 starting permutation: l2listen l2begin notify1 lbegins llisten lcommit l2commit l2stop
 step l2listen: LISTEN c1;
-listener2: NOTIFY "c1" with payload "" from notifier
-listener2: NOTIFY "c1" with payload "" from notifier
 step l2begin: BEGIN;
 step notify1: NOTIFY c1;
 step lbegins: BEGIN ISOLATION LEVEL SERIALIZABLE;
diff --git a/src/test/isolation/specs/async-notify.spec b/src/test/isolation/specs/async-notify.spec
index d09c2297f09..7aef2e8d180 100644
--- a/src/test/isolation/specs/async-notify.spec
+++ b/src/test/isolation/specs/async-notify.spec
@@ -68,12 +68,6 @@ step l2begin	{ BEGIN; }
 step l2commit	{ COMMIT; }
 step l2stop		{ UNLISTEN *; }
 
-# Third listener session for testing array growth.
-
-session listener3
-step l3listen	{ LISTEN c1; }
-teardown		{ UNLISTEN *; }
-
 # Listener session for cross-session notification test with channel 'ch'.
 
 session listener_ch
@@ -125,9 +119,6 @@ permutation lunlisten_all notify1 lcheck
 # Check notification_match function (triggered by hash table duplicate detection).
 permutation listenc notify_many_with_dup
 
-# Check ChannelHashAddListener array growth.
-permutation listenc llisten l2listen l3listen lslisten
-
 # Cross-backend notification delivery.  We use a "select 1" to force the
 # listener session to check for notifies.  In principle we could just wait
 # for delivery, but that would require extra support in isolationtester
-- 
2.52.0

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [PATCH] Remove obsolete LISTEN array growth isolation test
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox