From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Nitin Motiani <nitinmotiani@google.com>,
 Hannu Krosing <hannuk@google.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Horribly slow pg_upgrade performance with many Large Objects
In-reply-to: <aHUvLi_sdfBrxzYh@nathan>
References: 
 <CAMT0RQTXiqH7zdQEVSVd2L7_Cw4wQ1eHOD8hfZ+0vecMXJWc-w@mail.gmail.com>
 <aG2ISJC__3lQwRqY@nathan>
 <CAMT0RQStPtHfKwowd88Q0tynX0x=uJSKn=ihP8syhDJ6cH3DHQ@mail.gmail.com>
 <aG6srPib60NzJBeg@nathan>
 <CAMT0RQRT3KkwoQkx=YBdd_o9SqXxOt16fqQsscH_n+40Z57N7w@mail.gmail.com>
 <CAH5HC942o6j1qyVysiBtO+Vpb=XOBPbf3rKqsOLtpDpp0SzjkA@mail.gmail.com>
 <aHAzv9pgJh2Wa3M1@nathan>
 <CAH5HC94tYpgCnoPRYbCGQU0eCM8D7X+aEmB0GZrhjR16JEe5_A@mail.gmail.com>
 <aHEk_JEoNhIpuHd-@nathan>
 <CAH5HC96=3NjeYA5vuj8CyMmiFhU27jgvQ9WgXbUDccrE7xvwYw@mail.gmail.com>
 <aHUvLi_sdfBrxzYh@nathan>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Mon, 14 Jul 2025 11:24:14 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <700575.1752514083.1@sss.pgh.pa.us>
Date: Mon, 14 Jul 2025 13:28:03 -0400
Message-ID: <700576.1752514083@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/700576.1752514083%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> Here is what I have staged for commit, which (barring feedback or
> objections) I am planning to do towards the end of the week.

Is it intentional that this does

+#include "catalog/pg_largeobject_metadata.h"
+#include "catalog/pg_shdepend.h"

rather than including the corresponding *_d.h headers?
If so, why?  Our normal coding convention is that frontend
code should only include catalog *_d.h files, since the main
headers might contain frontend-unfriendly declarations.
If there is something we need to expose in these catalogs'
*_d.h headers, we should probably do that.

			regards, tom lane