Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1s4G-0002H0-QJ for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Mar 2019 12:24:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h1s4F-0006X5-6K for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Mar 2019 12:24:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1s4E-0006WJ-RT for pgsql-hackers@lists.postgresql.org; Thu, 07 Mar 2019 12:24:07 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1s4C-0001FV-8E for pgsql-hackers@postgresql.org; Thu, 07 Mar 2019 12:24:05 +0000 Received: from Davids-MacBook.local (unknown [185.245.87.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id 526EE5461E; Thu, 7 Mar 2019 12:24:00 +0000 (UTC) Subject: Re: Optimization of some jsonb functions To: Andrew Dunstan , Nikita Glukhov , PostgreSQL mailing lists References: <7c417f90-f95f-247e-ba63-d95e39c0ad14@postgrespro.ru> <5e8027a6-e175-55f8-96c8-0e24dd30e97f@pgmasters.net> <6467863b-4220-ebd1-536c-a39e7193dbac@2ndQuadrant.com> From: David Steele Message-ID: <700fcc48-7e30-aa80-83de-99d6015dfc81@pgmasters.net> Date: Thu, 7 Mar 2019 14:23:53 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <6467863b-4220-ebd1-536c-a39e7193dbac@2ndQuadrant.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi Andrew, On 3/6/19 9:50 PM, Andrew Dunstan wrote: > > On 3/5/19 5:24 AM, David Steele wrote: >> On 2/22/19 2:05 AM, Nikita Glukhov wrote: >>> Attached set of patches with some jsonb optimizations that were made >>> during >>> comparison of performance of ordinal jsonb operators and jsonpath >>> operators. >> >> This patch was submitted just before the last commitfest for PG12 and >> seems to have potential for breakage. >> >> I have updated the target to PG13. >> >> > > I think that's overly cautious. The first one I looked at, to optimize > JsonbExtractScalar, is very small, self-contained, and I think low risk. > I haven't looked at the others in detail, but I think at least some part > of this is reasonably committable. > > > I'll try to look at the others fairly shortly. If you decide all or part of this can be committed then feel free to update the target version. Regards, -- -David david@pgmasters.net