Message-ID: <701f45b5-13a3-6d75-cd24-835cc0716ecb@gmail.com>
Date: Fri, 4 Aug 2023 17:07:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Subject: "duplicated" wait events
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/701f45b5-13a3-6d75-cd24-835cc0716ecb%40gmail.com>
Precedence: bulk

Hi hackers,

while working on the new system catalog pg_wait_event (see [1]) I noticed that some wait
events are currently "duplicated":

postgres=# select wait_event_name,count(*) from pg_wait_event group by wait_event_name having count(*) > 1;
  wait_event_name | count
-----------------+-------
  SyncRep         |     2
  WALWrite        |     2
(2 rows)

Indeed:

SynRep currently appears in "IPC" and "LWLock" (see [2])
WALWrite currently appears in "IO" and "LWLock" (see [2])

I think that can lead to confusion and it would be better to avoid duplicate wait event
name across Wait Class (and so fix those 2 ones above), what do you think?

[1]: https://www.postgresql.org/message-id/0e2ae164-dc89-03c3-cf7f-de86378053ac%40gmail.com
[2]: https://www.postgresql.org/docs/current/monitoring-stats.html

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com