Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jqYEc-0001Td-14 for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Jul 2020 08:36:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jqYEa-0005G9-SW for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Jul 2020 08:36:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jqYEa-0005G1-LJ for pgsql-hackers@lists.postgresql.org; Wed, 01 Jul 2020 08:36:48 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jqYEY-0003Dk-Mz for pgsql-hackers@postgresql.org; Wed, 01 Jul 2020 08:36:48 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 51D862F6BA3C for ; Wed, 1 Jul 2020 10:36:45 +0200 (CEST) Received: from s645.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 306182E2DF64; Wed, 1 Jul 2020 10:36:45 +0200 (CEST) Received: from s476.loopia.se (unknown [172.22.191.5]) by s645.loopia.se (Postfix) with ESMTP id E5747156E5D7; Wed, 1 Jul 2020 10:36:44 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s498.loopia.se ([172.22.191.6]) by s476.loopia.se (s476.loopia.se [172.22.190.16]) (amavisd-new, port 10024) with LMTP id BBLCNjpAUTCk; Wed, 1 Jul 2020 10:36:44 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from [192.168.72.43] (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s498.loopia.se (Postfix) with ESMTPSA id 17B574708C7; Wed, 1 Jul 2020 10:36:44 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Subject: Re: Control your disk usage in PG: Introduction to Disk Quota Extension From: Daniel Gustafsson In-Reply-To: Date: Wed, 1 Jul 2020 10:36:43 +0200 Cc: David Steele , Michael Paquier , Alvaro Herrera , Hubert Zhang , Thomas Munro , Andres Freund , Robert Haas , "pgsql-hackers@postgresql.org" , Tomas Vondra , Heikki Linnakangas Content-Transfer-Encoding: quoted-printable Message-Id: <7025C3BF-C91E-44EB-AE45-121EC79DC1E4@yesql.se> References: <20190925195435.GA21518@alvherre.pgsql> <20191201032011.GC2355@paquier.xyz> To: Haozhou Wang X-Mailer: Apple Mail (2.3445.104.14) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk > On 27 Mar 2020, at 11:22, Haozhou Wang wrote: > We rebased this patch with the newest master. This patch now fails to build according to Travis: smgr.c: In function =E2=80=98smgrtruncate=E2=80=99: smgr.c:578:47: error: passing argument 4 of =E2=80=98smgrtruncate_hook=E2=80= =99 makes integer from pointer without a cast [-Werror=3Dint-conversion] (*smgrtruncate_hook)(reln, forknum, nforks, nblocks); ^ smgr.c:578:47: note: expected =E2=80=98BlockNumber {aka unsigned int}=E2=80= =99 but argument is of type =E2=80=98BlockNumber * {aka unsigned int = *}=E2=80=99 The warning is also present in the Windows build: src/backend/storage/smgr/smgr.c(578): warning C4047: 'function' : = 'BlockNumber' differs in levels of indirection from 'BlockNumber *' = [C:\projects\postgresql\postgres.vcxproj] src/backend/storage/smgr/smgr.c(578): warning C4024: 'smgrtruncate_hook' = : different types for formal and actual parameter 4 = [C:\projects\postgresql\postgres.vcxproj] 2 Warning(s) Marking the patch as Waiting for Author.=20 cheers ./daniel=