Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r8JZ1-009JIB-0f for pgsql-committers@arkaria.postgresql.org; Wed, 29 Nov 2023 12:21:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r8JYy-00ARL1-Qj for pgsql-committers@arkaria.postgresql.org; Wed, 29 Nov 2023 12:21:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r8JYy-00ARKs-Eg for pgsql-committers@lists.postgresql.org; Wed, 29 Nov 2023 12:21:08 +0000 Received: from mail-qv1-xf29.google.com ([2607:f8b0:4864:20::f29]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1r8JYs-007w2B-Gw for pgsql-committers@lists.postgresql.org; Wed, 29 Nov 2023 12:21:07 +0000 Received: by mail-qv1-xf29.google.com with SMTP id 6a1803df08f44-67a545a9462so13034106d6.0 for ; Wed, 29 Nov 2023 04:21:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dunslane-net.20230601.gappssmtp.com; s=20230601; t=1701260460; x=1701865260; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J61Q6+H3DLWokCzuMplCUseyroZ30kLP9N7kspWiWR4=; b=fqcFEwySCmkGzh4pyaxsnuHoBlBNzlg6xJBVSxQ9GSSUlySjCpbabxJQW6zbg4FylK n6vLkEuWKvCzuRTrVogILELX7Mil7BQTz5PzpuXv3sGycidllVHRpFm0Xidg6aVHyV0A COAqyEjcJZUBUFzLvFtR04LrblWdhG4NZ6L/IMwc3LYho/mUZUacwBvHcVld7b6ZnVRf 0gh4VFX/byA6z5jgQVDvZ55WpkZFKVK0aVqV+/bquacEdSuiFrXOj1FruqmMUatrtoam c/W+b+UE+n0/VCJlM2RMblT+mzJML9iclRv1SJ1qI1a/t8M85e7UPwAZmOR3zXnNGL5/ 0QBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701260460; x=1701865260; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J61Q6+H3DLWokCzuMplCUseyroZ30kLP9N7kspWiWR4=; b=QXgjWXWOwPLFqTtJRCIuelyZ59tY6BOfcN6ZGp0o8t9/vhBN4FsFmrIKimXpT5oDH5 HuqMkAJYF8ETlSNlkBacpYe7XGW+ZVQyqLexeENCHrWmThPfObWaieuh7OtGGDpligAw 0ukauzjZKzfof81YEznPm0wLzE8NKTczJwgEpmjj+hKQFDKg8s3esEwVW+qy7Bnxd1G6 szympGTnWQjTBRGLxdtcEnQ6PfE1c27Bwg9BEcvRpoCpYLwA7GJ81w67JnO0vJIs1WPs +WKsNYXHN/5zAIMSEWMjqOdKPhVaV9E0mWLG1OipwEOqcX4ffZRMBk4DM94q135gqu5l 0OkA== X-Gm-Message-State: AOJu0Yyccl4TTfgoDEmFppXm3pJfZ29Ifzedqsa0A2uBLMFLCvj7gzcC WtPhhDYTWlFXzCEXd4CSnK0wXsx7wt4lB/qtpaekrQ== X-Google-Smtp-Source: AGHT+IHpagycFKrUT9AVmpUjC5q5jTXxjJhtZa5qS3jnU+8SEcBJnAW1ehfwG4FJdgkRwQS3nv6IqQ== X-Received: by 2002:ad4:4310:0:b0:67a:369c:682 with SMTP id c16-20020ad44310000000b0067a369c0682mr13482986qvs.31.1701260460562; Wed, 29 Nov 2023 04:21:00 -0800 (PST) Received: from ?IPV6:2605:a601:9122:d800::2bb? ([2605:a601:9122:d800::2bb]) by smtp.googlemail.com with ESMTPSA id w5-20020a0c9c45000000b00678013cc898sm4108674qve.36.2023.11.29.04.20.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Nov 2023 04:21:00 -0800 (PST) Message-ID: <703110e4-b495-e409-26a5-28e9fca8f3a5@dunslane.net> Date: Wed, 29 Nov 2023 07:20:59 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-* Content-Language: en-US To: Andres Freund Cc: pgsql-committers@lists.postgresql.org References: <746ba786-85bb-d1f7-b613-57bec35c642a@dunslane.net> <20231129022843.6vfvgxjqpbgb62p5@awork3.anarazel.de> From: Andrew Dunstan In-Reply-To: <20231129022843.6vfvgxjqpbgb62p5@awork3.anarazel.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-11-28 Tu 21:28, Andres Freund wrote: > Hi, > > On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote: >> On 2023-11-20 Mo 20:53, Andres Freund wrote: >>> meson: docs: Add {html,man} targets, rename install-doc-* >>> >>> We have toplevel html, man targets in the autoconf build as well. It'd be odd >>> to have an 'html' target but have the install target be 'install-doc-html', >>> thus rename the install targets to match. >> >> This commit of one of its nearby friends appears to have broken crake's docs >> build: >> >> ERROR: Can't invoke target `html`: ambiguous name.Add target type and/or path: >> - ./doc/src/sgml/html:custom >> - ./doc/src/sgml/html:alias >> >> See > Ah, I realize now that this is from meson compile html, not 'ninja html'. That > explains why I couldn't reproduce this initially and why CI didn't complain. > I don't really understand why meson compile complains in this case. I assume > you don't want to disambiguate as suggested, by building html:alias instead? > I've done that as a temporary fix to get crake out of the hole, but it's pretty ugly, and I don't want to do it in a release if at all possible. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com