From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Alena Rybakina <a.rybakina@postgrespro.ru>,
        Pgsql Hackers <pgsql-hackers@postgresql.org>,
        Amit Langote <amitlangote09@gmail.com>
Subject: Re: Running the fdw test from the terminal crashes into the core-dump
In-reply-to: <202402211653.zuh6objy3z72@alvherre.pgsql>
References: <202402211653.zuh6objy3z72@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Wed, 21 Feb 2024 17:53:07 +0100"
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <708173.1708645648.0@sss.pgh.pa.us>
Date: Thu, 22 Feb 2024 18:48:20 -0500
Message-ID: <708233.1708645700@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/708233.1708645700%40sss.pgh.pa.us>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <708173.1708645648.1@sss.pgh.pa.us>

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> After having pushed that, I wonder if we should document this.  It seems
> quite the minor thing, but I'm sure somebody will complain if we don't.

Yup, no doubt.

> I propose the attached.  (Extra context so that the full paragraph can
> be read from the comfort of your email program.)

This reads awkwardly to me.  I think it'd be better to construct it
so that DO NOTHING's requirement is stated exactly parallel to the other
three clause types, more or less as attached.

> (While at it, I found the placement of the previous-to-last sentence in
> that paragraph rather strange, so I moved it to the end.)

Agreed, and done in my version too.

BTW, if you read it without paying attention to markup, you'll notice
that we are saying things like

    If you specify an insert action, you must have the INSERT
    privilege on the target_table_name.

which is fairly nonsensical: we don't define privileges on the name
of something.  While I've not done anything about that here,
I wonder if we shouldn't just write "privilege on the target table"
without any special markup.

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/x-diff; name="merge-privilege-doc.patch";
	charset="us-ascii"
Content-ID: <708173.1708645648.2@sss.pgh.pa.us>
Content-Description: merge-privilege-doc.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/doc/src/sgml/ref/merge.sgml b/doc/src/sgml/ref/merge.sgml
index 655f7dcc05..79ebff1033 100644
--- a/doc/src/sgml/ref/merge.sgml
+++ b/doc/src/sgml/ref/merge.sgml
@@ -104,12 +104,15 @@ DELETE
    privilege on the <replaceable class=3D"parameter">target_table_name</r=
eplaceable>.
    If you specify a delete action, you must have the <literal>DELETE</lit=
eral>
    privilege on the <replaceable class=3D"parameter">target_table_name</r=
eplaceable>.
-   Privileges are tested once at statement start and are checked
-   whether or not particular <literal>WHEN</literal> clauses are executed=
.
-   You will require the <literal>SELECT</literal> privilege on any column=
(s)
+   If you specify a <literal>DO NOTHING</literal> action, you must have
+   the <literal>SELECT</literal> privilege on at least one column
+   of <replaceable class=3D"parameter">target_table_name</replaceable>.
+   You will also need <literal>SELECT</literal> privilege on any column(s=
)
    of the <replaceable class=3D"parameter">data_source</replaceable> and
    <replaceable class=3D"parameter">target_table_name</replaceable> refer=
red to
    in any <literal>condition</literal> or <literal>expression</literal>.
+   Privileges are tested once at statement start and are checked
+   whether or not particular <literal>WHEN</literal> clauses are executed=
.
   </para>
 =

   <para>

------- =_aaaaaaaaaa0--