From: Antonin Houska <ah@cybertec.at>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Richard Guo <riguo@pivotal.io>, Tom Lane <tgl@sss.pgh.pa.us>,
    Michael Paquier <michael@paquier.xyz>,
    PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] WIP: Aggregation push-down
In-reply-to: <20190904202339.GA13644@alvherre.pgsql>
References: <20190904202339.GA13644@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
   message dated "Wed, 04 Sep 2019 16:23:39 -0400."
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7086.1567663857.1@localhost>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 05 Sep 2019 08:10:58 +0200
Message-ID: <7087.1567663858@localhost>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

> This stuff seems very useful.  How come it sits unreviewed for so long?

I think the review is hard for people who are not interested in the planne=
r
very much. And as for further development, there are a few design decision=
s
that can hardly be resolved without Tom Lane's comments. Right now I recal=
l
two problems: 1) is the way I currently store RelOptInfo for the grouped
relations correct?, 2) how should we handle types for which logical equali=
ty
does not imply physical (byte-wise) equality?

Fortunately it seems now that I'm not the only one who cares about 2), so =
this
problem might be resolved soon:

https://www.postgresql.org/message-id/CAH2-Wzn3Ee49Gmxb7V1VJ3-AC8fWn-Fr8pf=
WQebHe8rYRxt5OQ%40mail.gmail.com

But 1) still remains.

-- =

Antonin Houska
Web: https://www.cybertec-postgresql.com