Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\))
Subject: Re: Improve OAuth discovery logging
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <CAN4CZFNJftK8NaREYaLi-wqpEz3=crQ=1+3f_XUVji=aOrDSWA@mail.gmail.com>
Date: Tue, 24 Feb 2026 11:00:23 +0800
Cc: Jacob Champion <jacob.champion@enterprisedb.com>,
 Daniel Gustafsson <daniel@yesql.se>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Michael Paquier <michael@paquier.xyz>
Content-Transfer-Encoding: quoted-printable
Message-Id: <7094F798-8DD1-4974-9A04-10E147B29581@gmail.com>
References: <CAN4CZFPim7hUiyb7daNKQPSZ8CvQRBGkVhbvED7yZi8VktSn4Q@mail.gmail.com>
 <7DB528BA-C7A0-4B23-890C-5332FB35A16E@yesql.se>
 <CAN4CZFNNfhFCQdFWui5HWbQR60eM-cyndZ7YgSv7b5SKxB9C2A@mail.gmail.com>
 <CAOYmi+mDSmh6RNizHRmMAwg4ZP2W=uai3Fr3-wm186NMypf_Pg@mail.gmail.com>
 <CAN4CZFNJftK8NaREYaLi-wqpEz3=crQ=1+3f_XUVji=aOrDSWA@mail.gmail.com>
To: Zsolt Parragi <zsolt.parragi@percona.com>
Archived-At: <https://www.postgresql.org/message-id/7094F798-8DD1-4974-9A04-10E147B29581%40gmail.com>
Precedence: bulk


> On Feb 13, 2026, at 21:13, Zsolt Parragi <zsolt.parragi@percona.com> =
wrote:
>=20
> These all are good suggestions, attached updated patch.
>=20
>> Maybe something like PG_SASL_EXCHANGE_ABANDONED?
>=20
> This is the only one I wasn't sure of, I used RESTART because I was
> focusing more on the intention of the server ("please restart
> authentication with this additional information"), and a bit also on
> the idea that later restart could stay even within the same
> connection, both in this case and if we add support for
> reauthentication on token expiration.
>=20
> On the other hand I'm not 100% sure how the other two would work, and
> ABANDONED is a better description for the current situation, so I
> adjusted the patch to use that.
> <v3-0001-Improve-OAuth-discovery-logging.patch>

Hi Zsolt,

Thanks for the patch. A few small comments:

1 - commit message
```
SASL/Oauth code, by introducing a new SASL authentication status,
PG_SASL_EXCHANGE_RESTART. The expectation is that authentication
```

Looks like you forgot to update the commit message to change =
PG_SASL_EXCHANGE_RESTART to PG_SASL_EXCHANGE_ABANDONED.

2 - auth-oauth.c
```
 			/* The (failed) handshake is now complete. */
+			if (ctx->state =3D=3D =
OAUTH_STATE_ERROR_DISCOVERY)
+			{
+				ctx->state =3D OAUTH_STATE_FINISHED;
+				ereport(DEBUG1,
+						errmsg("OAuth issuer =
discovery requested"));
+				return PG_SASL_EXCHANGE_ABANDONED;
+			}
+
 			ctx->state =3D OAUTH_STATE_FINISHED;
 			return PG_SASL_EXCHANGE_FAILURE;
```

"ctx->state =3D OAUTH_STATE_FINISHED;" is duplicated in the =E2=80=9Cif=E2=
=80=9D and after the =E2=80=9Cif=E2=80=9D, so it can be pull up to =
before the =E2=80=9Cif=E2=80=9D.


Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/