Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: Add LZ4 compression in pg_dump
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <20220326235134.GK28503@telsasoft.com>
Date: Sun, 27 Mar 2022 21:55:52 +0200
Cc: Georgios <gkokolatos@protonmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Rachel Heaton <rachelmheaton@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <70C0B020-5E45-480B-9F49-41566A8CFC8E@yesql.se>
References: 
 <faUNEOpts9vunEaLnmxmG-DldLSg_ql137OC3JYDmgrOMHm1RvvWY2IdBkv_CRxm5spCCb_OmKNk2T03TMm0fBEWveFF9wA1WizPuAgB7Ss=@protonmail.com>
 <20220326162156.GI28503@telsasoft.com>
 <6FC5027A-1716-4D75-BF5B-2049A3698387@yesql.se>
 <20220326235134.GK28503@telsasoft.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/70C0B020-5E45-480B-9F49-41566A8CFC8E%40yesql.se>
Precedence: bulk

> On 27 Mar 2022, at 00:51, Justin Pryzby <pryzby@telsasoft.com> wrote:
>=20
> On Sun, Mar 27, 2022 at 12:37:27AM +0100, Daniel Gustafsson wrote:
>>> On 26 Mar 2022, at 17:21, Justin Pryzby <pryzby@telsasoft.com> =
wrote:
>>=20
>>> I suggested off-list to add an 0099 patch to change LZ4 to the =
default, to
>>> exercise it more on CI.
>>=20
>> No need to change the defaults in autoconf for that.  The CFBot uses =
the cirrus
>> file in the tree so changing what the job includes can be easily done =
(assuming
>> the CFBot hasn't changed this recently which I think it hasn't).  I =
used that
>> trick in the NSS patchset to add a completely new job for =
--with-ssl=3Dnss beside
>> the --with-ssl=3Dopenssl job.
>=20
> I think you misunderstood - I'm suggesting not only to use with-lz4 =
(which was
> always true since 93d973494), but to change pg_dump -Fc and -Fd to use =
LZ4 by
> default (the same as I suggested for toast_compression, =
wal_compression, and
> again in last year's patch to add zstd compression to pg_dump, for =
which
> postgres was not ready).

Right, I clearly misunderstood, thanks for the clarification.

--
Daniel Gustafsson		https://vmware.com/