Content-Type: multipart/alternative;
 boundary="------------OX50jIe6rJ5EmJCGtU00UrQp"
Message-ID: <70d20b11-8ed8-a34e-32d1-8f3015dd771b@dunslane.net>
Date: Thu, 25 Jan 2024 12:30:55 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
To: Michael Paquier <michael@paquier.xyz>,
 Dave Cramer <davecramer@postgres.rocks>
Cc: Anthony Roberts <anthony.roberts@linaro.org>,
 Peter Eisentraut <peter@eisentraut.org>, Daniel Gustafsson
 <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>,
 Mike Holmes <mike.holmes@linaro.org>, Andres Freund <andres@anarazel.de>,
 Thomas Munro <thomas.munro@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Lina Iyer <lina.iyer@linaro.org>
References: <305608.1693457047@sss.pgh.pa.us>
 <69a26a2a-feaa-43c0-bed3-0f5c2b569a28@eisentraut.org>
 <E9BEB24C-1F04-49BD-B70C-132C1ADF962C@yesql.se>
 <e393b473-6760-0ee4-3856-2ff353dbc96f@eisentraut.org>
 <f7249401-eee4-6eca-14fa-7e7a57bec238@linaro.org>
 <ZQon6cZInbQDWpHv@paquier.xyz>
 <CADK3HH+pKM_xyg2TiWtvtP=P0N-tMtXDKW2AT+7_FLmv4u9Jrg@mail.gmail.com>
 <CADK3HH+T0rQ58sYp0NnvkvopcEHA74Zmg=z7J5=skRrX+odnYw@mail.gmail.com>
 <ZbBMeMLXO0CtwY7X@paquier.xyz>
 <CADK3HHJ4uCsw0b5-c_HvYebHn1jQB-hV007Jf5c7FwGrCvDNSg@mail.gmail.com>
 <ZbGlFpeG-bPQIk-1@paquier.xyz>
Content-Language: en-US
From: Andrew Dunstan <andrew@dunslane.net>
Subject: Re: [PATCH] Add native windows on arm64 support
In-Reply-To: <ZbGlFpeG-bPQIk-1@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/70d20b11-8ed8-a34e-32d1-8f3015dd771b%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------OX50jIe6rJ5EmJCGtU00UrQp
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2024-01-24 We 19:02, Michael Paquier wrote:
> On Wed, Jan 24, 2024 at 06:45:21AM -0500, Dave Cramer wrote:
>> I managed to get it to build the vcvarsall arch needs to be x64. I need to
>> add some options, but the patch above needs to be applied to build it.
> Nice.  If I may ask, what kind of host and/or configuration have you
> used to reach a state where the code can be compiled and run tests
> with meson?  If you have found specific steps, it may be a good thing
> to document that on the wiki, say around [1].
>
> Perhaps you have not included TAP?  It may be fine in terms of runtime
> checks and coverage.
>
> [1]:https://wiki.postgresql.org/wiki/PostgreSQL_Buildfarm_Howto#Running_on_Windows


I now have an ARM64 machine, so I set up a W11 ARM64 VM. I think we 
really want to build with x64_arm64, i.e. to generate native arm64 
binaries. Setting just x64 will not do that, AIUI.

I tried that with the buidfarm, setting that in the config file's call 
to PGBuild::VSenv::getenv().

That upset msvc_gendef.pl, so I added this there to keep it happy:

    $arch = 'x86_64' if $arch eq 'aarch64';

After that things went ok until I got this:

[1453/2088] "link" @src/backend/postgres.exe.rsp
FAILED: src/backend/postgres.exe src/backend/postgres.pdb
"link" @src/backend/postgres.exe.rsp
    Creating library src\backend\postgres.exe.lib
storage_lmgr_s_lock.c.obj : error LNK2019: unresolved external symbol 
_mm_pause referenced in function perform_spin_delay
src\backend\postgres.exe : fatal error LNK1120: 1 unresolved externals


I haven't made further progress, but I will return to it in the next day 
or so.

While this will be nice to have, I think it won't really matter until 
there is ARM64 support in released versions of Windows Server. AFAICT 
they still only sell versions for x86_64


cheers


andrew


--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------OX50jIe6rJ5EmJCGtU00UrQp
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2024-01-24 We 19:02, Michael Paquier
      wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:ZbGlFpeG-bPQIk-1@paquier.xyz">
      <pre class="moz-quote-pre" wrap="">On Wed, Jan 24, 2024 at 06:45:21AM -0500, Dave Cramer wrote:
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">I managed to get it to build the vcvarsall arch needs to be x64. I need to
add some options, but the patch above needs to be applied to build it.
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
Nice.  If I may ask, what kind of host and/or configuration have you
used to reach a state where the code can be compiled and run tests
with meson?  If you have found specific steps, it may be a good thing
to document that on the wiki, say around [1].

Perhaps you have not included TAP?  It may be fine in terms of runtime
checks and coverage.

[1]: <a class="moz-txt-link-freetext" href="https://wiki.postgresql.org/wiki/PostgreSQL_Buildfarm_Howto#Running_on_Windows">https://wiki.postgresql.org/wiki/PostgreSQL_Buildfarm_Howto#Running_on_Windows</a>
</pre>
    </blockquote>
    <p><br>
    </p>
    <p><br>
    </p>
    <p>I now have an ARM64 machine, so I set up a W11 ARM64 VM. I think
      we really want to build with x64_arm64, i.e. to generate native
      arm64 binaries. Setting just x64 will not do that, AIUI.</p>
    <p>I tried that with the buidfarm, setting that in the config file's
      call to PGBuild::VSenv::getenv().</p>
    <p>That upset msvc_gendef.pl, so I added this there to keep it
      happy:</p>
    <blockquote>
      <p>$arch = 'x86_64' if $arch eq 'aarch64';</p>
    </blockquote>
    <p>After that things went ok until I got this:</p>
    <p>[1453/2088] "link" @src/backend/postgres.exe.rsp<br>
      FAILED: src/backend/postgres.exe src/backend/postgres.pdb<br>
      "link" @src/backend/postgres.exe.rsp<br>
         Creating library src\backend\postgres.exe.lib<br>
      storage_lmgr_s_lock.c.obj : error LNK2019: unresolved external
      symbol _mm_pause referenced in function perform_spin_delay<br>
      src\backend\postgres.exe : fatal error LNK1120: 1 unresolved
      externals <br>
    </p>
    <p><br>
    </p>
    <p>I haven't made further progress, but I will return to it in the
      next day or so.</p>
    <p>While this will be nice to have, I think it won't really matter
      until there is ARM64 support in released versions of Windows
      Server. AFAICT they still only sell versions for x86_64<br>
    </p>
    <p><br>
    </p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <p><br>
    </p>
    <pre class="moz-signature" signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------OX50jIe6rJ5EmJCGtU00UrQp--