Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ba15P-0003on-2s for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Aug 2016 13:40:51 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ba15O-0000me-Lz for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Aug 2016 13:40:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ba15M-0000l6-SB for pgsql-hackers@postgresql.org; Wed, 17 Aug 2016 13:40:48 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ba15J-0007EY-Mf for pgsql-hackers@postgresql.org; Wed, 17 Aug 2016 13:40:48 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id u7HDeftF007110; Wed, 17 Aug 2016 09:40:41 -0400 From: Tom Lane To: Oskari Saarenmaa cc: pgsql-hackers@postgresql.org Subject: Re: Use pread and pwrite instead of lseek + write and read In-reply-to: References: Comments: In-reply-to Oskari Saarenmaa message dated "Wed, 17 Aug 2016 10:58:09 +0300" Date: Wed, 17 Aug 2016 09:40:41 -0400 Message-ID: <7109.1471441241@sss.pgh.pa.us> X-Pg-Spam-Score: -2.5 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Oskari Saarenmaa writes: > On my laptop a simple pgbench run (scale 100, 15 minutes) shows a 1.5% > performance improvement. I would have hoped for a lot better result before anyone would propose that we should deal with all the portability issues this'll create. > A 1.5% performance improvement is small but > measurable - and IMV more importantly it allows us to drop more than 100 > lines of backwards (compatible?) code; maybe we could start targeting > more recent platforms in v10? That's basically nonsense: we'll end up adding way more than that to deal with platforms that haven't got these APIs. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers