public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alexander Lakhin <[email protected]>
To: Melanie Plageman <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Test 031_recovery_conflict.pl is not immune to autovacuum
Date: Wed, 20 Mar 2024 17:00:00 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAKRu_YRz5z=COe2U4OOj8e5imqmaSRBcFMo4XCngUY6dYownw@mail.gmail.com>
References: <[email protected]>
	<CAAKRu_YRz5z=COe2U4OOj8e5imqmaSRBcFMo4XCngUY6dYownw@mail.gmail.com>

Hello Melanie,

20.03.2024 16:15, Melanie Plageman wrote:
> Seems like we could just add autovacuum_enabled=false to the table like this:
> diff --git a/src/test/recovery/t/031_recovery_conflict.pl
> b/src/test/recovery/t/031_recovery_conflict.pl
> index d87efa823fd..65bc858c02d 100644
> --- a/src/test/recovery/t/031_recovery_conflict.pl
> +++ b/src/test/recovery/t/031_recovery_conflict.pl
> @@ -59,7 +59,7 @@ my $table1 = "test_recovery_conflict_table1";
>   my $table2 = "test_recovery_conflict_table2";
>   $node_primary->safe_psql(
>      $test_db, qq[
> -CREATE TABLE ${table1}(a int, b int);
> +CREATE TABLE ${table1}(a int, b int) WITH (autovacuum_enabled = false);
>   INSERT INTO $table1 SELECT i % 3, 0 FROM generate_series(1,20) i;
>   CREATE TABLE ${table2}(a int, b int);
>   ]);

Thanks for paying attention to it!

With such modification applied I've got another failure (on iteration 2):
[13:27:39.034](2.317s) ok 14 - startup deadlock: lock acquisition is waiting
Waiting for replication conn standby's replay_lsn to pass 0/343E6D0 on primary
done
timed out waiting for match: (?^:User transaction caused buffer deadlock with recovery.) at t/031_recovery_conflict.pl 
line 318.
# Postmaster PID for node "primary" is 1523036
### Stopping node "primary" using mode immediate

031_recovery_conflict_standby.log really doesn't contain the expected
message. I can share log files from a successful and failed test runs, if
they can be helpful, or I'll investigate this case today/tomorrow.

Best regards,
Alexander

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Test 031_recovery_conflict.pl is not immune to autovacuum
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox